Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021685
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2012-09-19 09:572012-10-04 11:39
ReporteriperdomoView Statuspublic 
Assigned ToAugustoMauch 
PriorityurgentResolutionno change requiredFixed in Version
StatusclosedFix in branchpiFixed in SCM revision
ProjectionnoneETAnoneTarget Version3.0MP17
OSLinux 64 bitDatabasePostgreSQLJava versionOpenJDK 1.6.0_24
OS Version3.5.3-1-ARCHDatabase version9.1.4Ant version1.8.2
Product VersionSCM revision 
Review Assigned To
Web browserApple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021685: A non authenticated Component needs to have the AdminMode context by default

DescriptionThe development in issue 0021508 adds the support for non authenticated Components.

Before the authentication happens the only available OBContext is AdminMode, therefore it makes sense that the code executed during the Component generation should be wrapped in a AdminMode context.
Steps To Reproduce* Using a non-authenticated Component, try to access the database using DAL
Proposed SolutionWrap the Component instantiation and code generation in a AdminMode context
TagsNo tags attached.
Attached Filesdiff file icon issue21685.diff [^] (971 bytes) 2012-10-01 10:36 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0021508 closedmarvintm Components require the user to be logged in to work correctly 

-  Notes
(0052945)
AugustoMauch (manager)
2012-10-01 10:37

A patch for this issue has been attached. It will be applied to pi when it is not logically frozen for MP16.
(0053025)
iperdomo (reporter)
2012-10-03 20:01

@AugustoMauch:
It is really need to modify HttpSecureAppServlet? There a dozens/hundreds of classes extending from this class.

I think that you should take a look into BaseKernelServlet that is a subclass of this one and handles the requests to the "KernelServlet" in Openbravo 3.
(0053026)
iperdomo (reporter)
2012-10-03 21:41

Thinking a bit more, notice that only *some* Component generation needs to be wrapped in a AdminContext. This one are the ones with bypassAuthentication() equals true. The current associated patch is not OK.
(0053028)
AugustoMauch (manager)
2012-10-04 11:39

The is no need to make any change, because the generation of components is already wrapped in an admin context, see [1].

[1] https://code.openbravo.com/erp/devel/pi/file/34211605322e/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ComponentGenerator.java#l62 [^]

- Issue History
Date Modified Username Field Change
2012-09-19 09:57 iperdomo New Issue
2012-09-19 09:57 iperdomo Assigned To => marvintm
2012-09-19 09:57 iperdomo Web browser => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
2012-09-19 09:57 iperdomo Modules => Core
2012-09-19 09:57 iperdomo Relationship added related to 0021508
2012-09-25 11:32 marvintm Web browser Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
2012-09-25 11:32 marvintm Target Version 3.0MP16 => 3.0MP17
2012-09-27 11:10 AugustoMauch Assigned To marvintm => AugustoMauch
2012-09-27 11:10 AugustoMauch Status new => scheduled
2012-09-27 11:10 AugustoMauch fix_in_branch => pi
2012-09-27 15:08 AugustoMauch Assigned To AugustoMauch => shankarb
2012-10-01 09:43 shankarb Assigned To shankarb => AugustoMauch
2012-10-01 10:36 AugustoMauch File Added: issue21685.diff
2012-10-01 10:37 AugustoMauch Note Added: 0052945
2012-10-03 20:01 iperdomo Note Added: 0053025
2012-10-03 21:41 iperdomo Note Added: 0053026
2012-10-04 11:39 AugustoMauch Note Added: 0053028
2012-10-04 11:39 AugustoMauch Status scheduled => closed
2012-10-04 11:39 AugustoMauch Resolution open => no change required


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker