0021664: bank statement post looks same way whether totalAmount>0 or totalAmount<0

Description

Bank statement post is always same and it does not depend of totalAmount sign. Post process use transit, and asset account but bank statement total amount only affect order in which this account appear in GL.

Steps To Reproduce

One can try to import bank statement with positive total amount, and then with negative total amount posts to GL will be the same.

Proposed Solution

Attachment is patch file (for a/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java) with one of the possible solutions.

Tags

No tags attached.

Attached Files

patch.diff [^] (1,374 bytes) 2012-09-17 10:06 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java b/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java
@@ -125,13 +125,11 @@
       }
       String Fact_Acct_Group_ID = SequenceIdData.getUUID();
       FIN_BankStatement bst = OBDal.getInstance().get(FIN_BankStatement.class, Record_ID);
-      fact.createLine(null, getAccount(conn, bst.getAccount(), as, totalAmount.signum() < 0),
-          C_Currency_ID,
+      fact.createLine(null, getAccount(conn, bst.getAccount(), as, true), C_Currency_ID,
           (totalAmount.signum() > 0 ? totalAmount.abs().toString() : ZERO.toString()),
           (totalAmount.signum() < 0 ? totalAmount.abs().toString() : ZERO.toString()),
           Fact_Acct_Group_ID, nextSeqNo(SeqNo), DocumentType, conn);
-      fact.createLine(null, getAccount(conn, bst.getAccount(), as, totalAmount.signum() > 0),
-          C_Currency_ID,
+      fact.createLine(null, getAccount(conn, bst.getAccount(), as, false), C_Currency_ID,
           (totalAmount.signum() < 0 ? totalAmount.abs().toString() : ZERO.toString()),
           (totalAmount.signum() > 0 ? totalAmount.abs().toString() : ZERO.toString()),
           Fact_Acct_Group_ID, nextSeqNo(SeqNo), DocumentType, conn);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0058405) hgbot (developer) 2013-05-02 11:52	Repository: erp/devel/pi Changeset: 1ec1a7c8ac33debf5454b84012c039fffe5ef7fd Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> Date: Thu May 02 11:52:17 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1ec1a7c8ac33debf5454b84012c039fffe5ef7fd [^] fixes bug 21664 --- M src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java ---

(0058457) dmiguelez (viewer) 2013-05-03 13:53	Code Review + Testing Ok

(0058757) hudsonbot (viewer) 2013-05-23 01:32	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/97c7f6256af7 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-09-17 10:06	vmatic	New Issue
2012-09-17 10:06	vmatic	Assigned To	=> dmiguelez
2012-09-17 10:06	vmatic	File Added: patch.diff
2012-09-17 10:06	vmatic	Modules	=> Core
2012-09-17 10:07	vmatic	Issue Monitored: vmatic
2013-05-02 11:28	eduardo_Argal	Assigned To	dmiguelez => eduardo_Argal
2013-05-02 11:29	eduardo_Argal	Status	new => scheduled
2013-05-02 11:29	eduardo_Argal	fix_in_branch	=> pi
2013-05-02 11:52	hgbot	Checkin
2013-05-02 11:52	hgbot	Note Added: 0058405
2013-05-02 11:52	hgbot	Status	scheduled => resolved
2013-05-02 11:52	hgbot	Resolution	open => fixed
2013-05-02 11:52	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/1ec1a7c8ac33debf5454b84012c039fffe5ef7fd [^]
2013-05-03 13:53	dmiguelez	Note Added: 0058457
2013-05-03 13:53	dmiguelez	Status	resolved => closed
2013-05-23 01:32	hudsonbot	Checkin
2013-05-23 01:32	hudsonbot	Note Added: 0058757