Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0021657
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2012-09-14 14:362012-09-26 17:32
ReporteregoitzView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0MP16
StatusclosedFix in branchFixed in SCM revisiond21ed23d426e
ProjectionnoneETAnoneTarget Version3.0MP16
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0MP14SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2011-10-26
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f9b05776d657 [^]
Triggers an Emergency Packyes
Summary

0021657: The windows were the id field is checked as show in grid does not work

DescriptionBy default the show in GRID field is filled with 'Y' (SHOWINRELATION).
Since mp12, the windows defined with the field of the primary key with
show in relation =Y does not work.
The save action can not be performed.

AS the default value is Y lof of the partners have modules defined on this way,what causes the windows not work.

This happens on "Import Loader Format" window on core.

Steps To Reproduce-Activate the instance to show properly the "Import Loader Format" window.
-Then accesss to the window and try to save a new recored.
*The save button is not enabled after enter data on the mandatory fields
Proposed SolutionIf all the fields pointing to key columns must be defined with SHOWINRELATION='N'
a modulescript should be created to solve that data in all the modules of the partners (also core) that have incorrect data.
(this has an inpediment becasue all the modules will still incorrectly defined)
Apart of that Add a trigger to avoid getting into this error or change the default of the column.

As in mp11.1 it was working well allow to having the fields on this way would be the best solution.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0021261 closedAugustoMauch It is not possible to save a new record in window which shows in grid the key field. 
related to design defect 0021688 newAugustoMauch Access to backend ID from the frontend (javascript) 

-  Notes
(0052157)
hgbot (developer)
2012-09-17 10:25

 Repository: erp/devel/pi
Changeset: 35a4bff5296e687ae949a2ae77a131baea047457
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Sep 17 10:22:29 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/35a4bff5296e687ae949a2ae77a131baea047457 [^]

Fixes issue 21657: It is possible to save views that have ids in its fields

If a window that an id in its fields, it was not possible to save new records because the ID was a mandatory field without value, so the save button was not enabled. Now the allRequiredFieldsSet function has been modified, so it does not take into account id fields, because its value will be set in dal before inserting the new row in the database.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0052220)
dbaz (developer)
2012-09-19 12:10

 To get "Import Loader Format" install this module:
https://code.openbravo.com/erp/mods/org.openbravo.importdata/ [^]
(0052224)
dbaz (developer)
2012-09-19 13:22

 Reviewed @ changeset: 17978 - 571b10dd474d
(0052661)
hgbot (developer)
2012-09-26 17:16

 Repository: erp/devel/pi
Changeset: d21ed23d426e4a8f9f6616231922c5c77a4bcfa4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Sep 17 10:22:29 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d21ed23d426e4a8f9f6616231922c5c77a4bcfa4 [^]

Fixes issue 21657: It is possible to save views that have ids in its fields

If a window that an id in its fields, it was not possible to save new records because the ID was a mandatory field without value, so the save button was not enabled. Now the allRequiredFieldsSet function has been modified, so it does not take into account id fields, because its value will be set in dal before inserting the new row in the database.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0052769)
hudsonbot (developer)
2012-09-26 17:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-09-14 14:36 egoitz New Issue
2012-09-14 14:36 egoitz Assigned To => AugustoMauch
2012-09-14 14:36 egoitz Modules => Core
2012-09-14 14:36 egoitz Resolution time => 1347832800
2012-09-14 14:37 egoitz Regression level => Production - QA Approved
2012-09-14 16:51 AugustoMauch Relationship added has duplicate 0021261
2012-09-17 10:17 AugustoMauch Closed by => dbaz
2012-09-17 10:17 AugustoMauch Regression level Production - QA Approved => Production - Confirmed Stable
2012-09-17 10:17 AugustoMauch Regression date => 2011-10-26
2012-09-17 10:17 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f9b05776d657 [^]
2012-09-17 10:25 hgbot Checkin
2012-09-17 10:25 hgbot Note Added: 0052157
2012-09-17 10:25 hgbot Status new => resolved
2012-09-17 10:25 hgbot Resolution open => fixed
2012-09-17 10:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/35a4bff5296e687ae949a2ae77a131baea047457 [^]
2012-09-19 11:28 AugustoMauch Issue Monitored: AugustoMauch
2012-09-19 11:28 AugustoMauch Issue End Monitor: AugustoMauch
2012-09-19 12:10 dbaz Note Added: 0052220
2012-09-19 13:22 dbaz Note Added: 0052224
2012-09-19 13:22 dbaz Status resolved => closed
2012-09-19 13:22 dbaz Fixed in Version => 3.0MP16
2012-09-19 15:20 dbaz Relationship added related to 0021688
2012-09-26 17:16 hgbot Checkin
2012-09-26 17:16 hgbot Note Added: 0052661
2012-09-26 17:16 hgbot Status closed => resolved
2012-09-26 17:16 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/35a4bff5296e687ae949a2ae77a131baea047457 [^] => http://code.openbravo.com/erp/devel/pi/rev/d21ed23d426e4a8f9f6616231922c5c77a4bcfa4 [^]
2012-09-26 17:19 hudsonbot Checkin
2012-09-26 17:19 hudsonbot Note Added: 0052769
2012-09-26 17:32 gorka_gil Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker