0021361: Data cannot be saved when server has no access to Internet

(0051324)
hgbot (developer)
2012-08-16 14:01

Repository: erp/devel/pi
Changeset: 78e4e8656a9db641c300170c8c43a8477d14c761
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Aug 16 13:58:02 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/78e4e8656a9db641c300170c8c43a8477d14c761 [^]

Fixes issue 21361: Data can be saved in local server without internet access

Before this fix, it was not possible to save data without being connected, because of this code in the saveData function:

        if (isc.Offline && isc.Offline.isOffline() && !this.dataSource.clientOnly) {
            isc.warn(this.offlineSaveMessage);
            return;
        }

Offline.isOffline() is defined as follows:

    isOffline : function () {
        if (this.explicitOffline !== null) return this.explicitOffline;
        var offline = window.navigator.onLine ? false : true;
        return offline;
    }

So, by setting Offline.explicitOffline to false, it is possible to go on with the saving process even if the browser detects there is no internet connectivity.

This value is set just before the save, and restored to its original value right after the saving process is completed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---

(0051325)
AugustoMauch (administrator)
2012-08-16 14:03

Now, if the user is working against a remote server and loses the network connectivity, the warning message he will receive will be the one shown in the attached screenshot.

(0051326)
AugustoMauch (administrator)
2012-08-16 14:04

I have tried to reproduce this issue with previous Openbravo version, and it has been always reproducible (I have gone back until Openbravo 3.0MP3)

(0051327)
AugustoMauch (administrator)
2012-08-16 14:05

In the changeset that fixed the issue I have not made clear that the code that prevented the saving process from working without internet connectivity belongs to Smartclient, not to Openbravo.

(0051339)
AugustoMauch (administrator)
2012-08-17 12:25

This issue is not a regression, it has been reproducible since 3.0MP1

(0051646)
migueldejuana (viewer)
2012-08-29 17:51

Tested and reviewed in pi@19952d22eb0a

Issue History
Date Modified	Username	Field	Change
2012-08-15 17:04	pjuvara	New Issue
2012-08-15 17:04	pjuvara	Assigned To	=> alostale
2012-08-15 17:04	pjuvara	File Added: Screenshot from 2012-07-31 12_11_04.png
2012-08-15 17:04	pjuvara	Web browser	=> Google Chrome
2012-08-15 17:04	pjuvara	Modules	=> Core
2012-08-15 17:04	pjuvara	OBNetwork customer	=> No
2012-08-15 17:18	iciordia	Web browser	Google Chrome => Google Chrome
2012-08-15 17:18	iciordia	Assigned To	alostale => AugustoMauch
2012-08-16 13:45	AugustoMauch	File Added: OfflineMessage.png
2012-08-16 14:01	hgbot	Checkin
2012-08-16 14:01	hgbot	Note Added: 0051324
2012-08-16 14:01	hgbot	Status	new => resolved
2012-08-16 14:01	hgbot	Resolution	open => fixed
2012-08-16 14:01	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/78e4e8656a9db641c300170c8c43a8477d14c761 [^]
2012-08-16 14:03	AugustoMauch	Note Added: 0051325
2012-08-16 14:04	AugustoMauch	Note Added: 0051326
2012-08-16 14:05	AugustoMauch	Note Added: 0051327
2012-08-17 12:25	AugustoMauch	Note Added: 0051339
2012-08-29 17:51	migueldejuana	Closed by	=> migueldejuana
2012-08-29 17:51	migueldejuana	Note Added: 0051646
2012-08-29 17:51	migueldejuana	Status	resolved => closed

Notes
(0051324) hgbot (developer) 2012-08-16 14:01	Repository: erp/devel/pi Changeset: 78e4e8656a9db641c300170c8c43a8477d14c761 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Aug 16 13:58:02 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/78e4e8656a9db641c300170c8c43a8477d14c761 [^] Fixes issue 21361: Data can be saved in local server without internet access Before this fix, it was not possible to save data without being connected, because of this code in the saveData function: if (isc.Offline && isc.Offline.isOffline() && !this.dataSource.clientOnly) { isc.warn(this.offlineSaveMessage); return; } Offline.isOffline() is defined as follows: isOffline : function () { if (this.explicitOffline !== null) return this.explicitOffline; var offline = window.navigator.onLine ? false : true; return offline; } So, by setting Offline.explicitOffline to false, it is possible to go on with the saving process even if the browser detects there is no internet connectivity. This value is set just before the save, and restored to its original value right after the saving process is completed. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js ---

(0051325) AugustoMauch (administrator) 2012-08-16 14:03	Now, if the user is working against a remote server and loses the network connectivity, the warning message he will receive will be the one shown in the attached screenshot.

(0051326) AugustoMauch (administrator) 2012-08-16 14:04	I have tried to reproduce this issue with previous Openbravo version, and it has been always reproducible (I have gone back until Openbravo 3.0MP3)

(0051327) AugustoMauch (administrator) 2012-08-16 14:05	In the changeset that fixed the issue I have not made clear that the code that prevented the saving process from working without internet connectivity belongs to Smartclient, not to Openbravo.

(0051339) AugustoMauch (administrator) 2012-08-17 12:25	This issue is not a regression, it has been reproducible since 3.0MP1

(0051646) migueldejuana (viewer) 2012-08-29 17:51	Tested and reviewed in pi@19952d22eb0a

Relationships [ Relation Graph ] [ Dependency Graph ]