0021079: Connectivity loss while cashing up causes application hangs

Description

While cashing up, if connectivity is lost, application hangs and it is not possible to recover it, even if connectivity returns.

Steps To Reproduce

* Execute a cash-up
* After starting the last step, disconnect wifi or cable
* "Loading..." message remains in the middle of the screen and no message informs the user about the situation
* Connectivity indicator remains as "Online"

Tags

No tags attached.

Attached Files

issue21079.diff [^] (581 bytes) 2012-12-12 17:27 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js b/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
--- a/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
+++ b/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
@@ -277,7 +277,7 @@
 
     //ready to send to the server
     server.exec(objToSend, function (data) {
-      if (data.error) {
+      if (data.error || data.exception) {
         OB.UTIL.showLoading(false);
         me.set("finishedWrongly", true);
       } else {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0050588) alostale (viewer) 2012-07-16 10:03	Note the Loading message is not actually shown when completing the cash up process, but when it has finished and the main window is being loaded. The way it works it is planned to be changed in short, after this change, moving between windows will not require to load (they will be in memory) so this issue shouldn't be reproducible afterwards.

(0054961) hgbot (developer) 2012-12-17 11:00	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 4952a0e04dd1bf00fbc750c7422ffe1bc3c6fbec Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon Dec 17 10:59:14 2012 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4952a0e04dd1bf00fbc750c7422ffe1bc3c6fbec [^] Fixed issue 21079: Connectivity loss in cash up, works well --- M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js ---

(0055082) guilleaer (viewer) 2012-12-19 18:51	tested & verified

Issue History
Date Modified	Username	Field	Change
2012-07-14 11:07	xplacesc	New Issue
2012-07-14 11:07	xplacesc	Assigned To	=> adrianromero
2012-07-16 10:03	alostale	Note Added: 0050588
2012-11-09 13:54	alostale	Status	new => scheduled
2012-11-09 13:54	alostale	Assigned To	adrianromero => migueldejuana
2012-11-09 13:54	alostale	fix_in_branch	=> pi
2012-12-12 17:27	migueldejuana	File Added: issue21079.diff
2012-12-17 11:00	hgbot	Checkin
2012-12-17 11:00	hgbot	Note Added: 0054961
2012-12-17 11:00	hgbot	Status	scheduled => resolved
2012-12-17 11:00	hgbot	Resolution	open => fixed
2012-12-17 11:00	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4952a0e04dd1bf00fbc750c7422ffe1bc3c6fbec [^]
2012-12-19 18:51	guilleaer	Note Added: 0055082
2012-12-19 18:51	guilleaer	Status	resolved => closed
2012-12-19 18:51	guilleaer	Fixed in Version	=> RMP18