Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021053
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2012-07-12 17:082012-07-13 11:57
ReportermiruritaView Statuspublic 
Assigned Tomirurita 
PriorityurgentResolutionfixedFixed in Version3.0MP13
StatusclosedFix in branchFixed in SCM revision745fd4a939d1
ProjectionnoneETAnoneTarget Version3.0MP13
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021053: C_INVOICELINE_TRG2: price including taxes logic not working in the trigger

DescriptionPrice including taxes functionality in C_INVOICELINE_TRG2 is not working properly when DELETE action is triggered.

v_istaxincluded variable is only initialized on INSERTING action

 IF INSERTING OR v_Insert THEN
   SELECT C_BPartner_ID, dateInvoiced, priceprecision, i.M_PriceList_ID,p.istaxincluded
    INTO v_BPartner_ID, v_DateInvoiced, v_Precision, v_PriceList_ID, v_istaxincluded
    ...

but then the variable is used inside DELETE action
CASE v_istaxincluded
                       WHEN 'Y' THEN grandtotal - v_oldgrossamt

this condition will never be satisfied because v_istaxincluded is NULL at this point.
Steps To Reproduce1. Enter as F&B Internation Group Admin role
2. Go to Price List window
3. Edit "Tarifa de Ventas" record by marking it as Including Taxes
4. Go to Sales Invoice window
5. Create a new document for "Alimentos y Supermercados" business partner. Add a discount
6. Create a new line for "Agua sin gas 1L"
7. Book the order
8. Total gross amount is: 1.38
9. Reactivate the sales invoice. realize that the total gross amount is = 1.38
Proposed Solution1. Assign value to v_istaxincluded also on DELETE action
2. Assign proper value to v_oldgrossamt
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0050535)
hgbot (developer)
2012-07-12 17:11

Repository: erp/devel/pi
Changeset: 745fd4a939d1971b93a248ada1427b7fb07c5d30
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Thu Jul 12 17:11:01 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/745fd4a939d1971b93a248ada1427b7fb07c5d30 [^]

Fixes issue 21053: C_INVOICELINE_TRG2: PIT logic not working

---
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
---
(0050551)
psarobe (manager)
2012-07-13 11:57

works fine

- Issue History
Date Modified Username Field Change
2012-07-12 17:08 mirurita New Issue
2012-07-12 17:08 mirurita Assigned To => mirurita
2012-07-12 17:08 mirurita Modules => Core
2012-07-12 17:11 hgbot Checkin
2012-07-12 17:11 hgbot Note Added: 0050535
2012-07-12 17:11 hgbot Status new => resolved
2012-07-12 17:11 hgbot Resolution open => fixed
2012-07-12 17:11 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/745fd4a939d1971b93a248ada1427b7fb07c5d30 [^]
2012-07-13 11:42 psarobe Steps to Reproduce Updated View Revisions
2012-07-13 11:57 psarobe Note Added: 0050551
2012-07-13 11:57 psarobe Status resolved => closed
2012-07-13 11:57 psarobe Fixed in Version => 3.0MP13


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker