Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020994
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2012-07-10 16:552012-07-10 17:55
ReportermiruritaView Statuspublic 
Assigned ToioritzCia 
PriorityurgentResolutionfixedFixed in Version3.0MP13
StatusclosedFix in branchFixed in SCM revisionbd214e633138
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression levelPre packaging ( pi )
Regression date2012-06-27
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/3b4adfb72e90 [^]
Triggers an Emergency PackNo
Summary

0020994: Add Details (Payment in/out): difference options are not properly calculated

DescriptionIf you have more than one record in the grid the difference options are not properly displayed.

Note: if you use the "select all" checkbox the difference options work.

For each record in the grid the updateReadOnly (FIN_Utilities.js) method is called.

expectedAmount = frm.inpExpectedPayment.value;

frm.inpExpectedPayment.value at this point is "" (empty string).
Before, at this point, updateAll method was previously called and it was calculating the expected payment.

and after this statement it takes "NaN.00" value
frm.inpExpectedPayment.value = subtract(expectedAmount, recordAmount);

(see attached screenshot)

for difference options the expected payment value is used. As it has an invalid value the difference options calculation does not work.
Steps To Reproduce1) Create two sales invoices for Healthy Food Supermarkets, Co.
   - SI1: 2.04$
   - SI2: 1.34$
2) Create a new Payment In
   - Business Partner: Healthy Food Supermarkets, Co.
3) Click on Add Details button
4) The option displayed in the bottom is: "Write off the difference"
5) Enter 3 in Actual Payment In. The amount is properly distributed.
6) Realize that the option has not changed, the only available option is "Write off the difference". This is wrong.
7) At this point if you try to modify the amounts in the grid manually the options are not properly recalculated
TagsNo tags attached.
Attached Filespng file icon Difference options.png [^] (45,636 bytes) 2012-07-10 16:56


png file icon ExpectedAmount.png [^] (113,515 bytes) 2012-07-10 16:56

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0050464)
hgbot (developer)
2012-07-10 17:51

Repository: erp/devel/pi
Changeset: bd214e6331389d964a7cf6b72ce834718c219ed3
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Tue Jul 10 17:49:42 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bd214e6331389d964a7cf6b72ce834718c219ed3 [^]

Fixes issue 20994: Backout of changeset 3b4adfb72e90.
Add Details (Payment in/out): difference options are not properly calculated.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
---
(0050465)
mirurita (developer)
2012-07-10 17:55

restored to the previous code

code review + testing OK

- Issue History
Date Modified Username Field Change
2012-07-10 16:55 mirurita New Issue
2012-07-10 16:55 mirurita Assigned To => ioritzCia
2012-07-10 16:55 mirurita Modules => Advanced Payables and Receivables Mngmt
2012-07-10 16:56 mirurita File Added: Difference options.png
2012-07-10 16:56 mirurita File Added: ExpectedAmount.png
2012-07-10 16:57 mirurita Regression level => Pre packaging ( pi )
2012-07-10 16:57 mirurita Regression date => 2012-06-27
2012-07-10 16:57 mirurita Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/3b4adfb72e90 [^]
2012-07-10 17:01 mirurita Description Updated View Revisions
2012-07-10 17:51 hgbot Checkin
2012-07-10 17:51 hgbot Note Added: 0050464
2012-07-10 17:51 hgbot Status new => resolved
2012-07-10 17:51 hgbot Resolution open => fixed
2012-07-10 17:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bd214e6331389d964a7cf6b72ce834718c219ed3 [^]
2012-07-10 17:55 mirurita Note Added: 0050465
2012-07-10 17:55 mirurita Status resolved => closed
2012-07-10 17:55 mirurita Fixed in Version => 3.0MP13


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker