Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0020905

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 09. Financial management

major

have not tried

2012-07-02 12:12

2012-07-10 10:35

Reporter

shuehner

View Status

public

Assigned To

ioritzCia

Priority

immediate

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0MP13

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

a4d3cc40e39f

Review Assigned To

Web browser

Modules

Core

Regression level

Pre packaging ( pi )

Regression date

2012-06-28

Regression introduced in release

Regression introduced by commit

http://code.openbravo.com/erp/devel/pi/rev/b7866285b3e41485cdb3e68027329ef97c88bf40 [^]

Triggers an Emergency Pack

No

Summary

0020905: change in 20858 uses rong limit probably causing bad performance and causes compile time warnings

Description

The change done in 20858 uses a batch size of 2 instead of the planned 999 probably causing bad performance.

Also it causes ugly compile time warnings to appear in every pi compile.

Steps To Reproduce

Check diff
Check compiler output on any pi compile

Tags

No tags attached.

20858_warning_fix.diff [^] (1,034 bytes) 2012-07-02 12:14 [Show Content] [Hide Content]

diff -r 2637b0fb27bb modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java	Sat Jun 30 05:09:30 2012 +0200
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java	Mon Jul 02 12:13:56 2012 +0200
@@ -1221,11 +1221,11 @@
     return obc.list();
   }
 
-  private void addPaymentMethodList(OBCriteria obc, List<String> paymentMethods) {
+  private void addPaymentMethodList(OBCriteria<FIN_PaymentMethod> obc, List<String> paymentMethods) {
     List<String> paymentMethodsToRemove;
     Criterion compoundExp = null;
     while (paymentMethods.size() > 2) {
-      paymentMethodsToRemove = new ArrayList(paymentMethods.subList(0, 2));
+      paymentMethodsToRemove = new ArrayList<String>(paymentMethods.subList(0, 2));
       if (compoundExp == null) {
         compoundExp = Restrictions.in("id", paymentMethods.subList(0, 2));
       } else {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

3.0MP13

closed

Error "maximum number of expressions in a list is 1000" in getFilteredPaymentMethods method

Notes
(0050314) hgbot (developer) 2012-07-02 12:35	Repository: erp/devel/pi Changeset: 0f7d2b1391ac08e699c5127812d125a98411df08 Author: Ioritz Cia <ioritz.cia <at> openbravo.com> Date: Mon Jul 02 12:18:03 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/0f7d2b1391ac08e699c5127812d125a98411df08 [^] Fixes issue 20905: change in 20858 uses wrong limit. It probably causes bad performance compile time warnings. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java ---

(0050324) maite (developer) 2012-07-02 17:43	verified

(0050417) hudsonbot (developer) 2012-07-10 10:35	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9f5eedec4e1a [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-07-02 12:12	shuehner	New Issue
2012-07-02 12:12	shuehner	Assigned To	=> ioritzCia
2012-07-02 12:12	shuehner	Modules	=> Core
2012-07-02 12:12	shuehner	Relationship added	related to 0020858
2012-07-02 12:13	shuehner	Regression level	=> Pre packaging ( pi )
2012-07-02 12:13	shuehner	Regression date	=> 2012-06-28
2012-07-02 12:13	shuehner	Regression introduced by commit	=> http://code.openbravo.com/erp/devel/pi/rev/b7866285b3e41485cdb3e68027329ef97c88bf40 [^]
2012-07-02 12:14	shuehner	File Added: 20858_warning_fix.diff
2012-07-02 12:35	hgbot	Checkin
2012-07-02 12:35	hgbot	Note Added: 0050314
2012-07-02 12:35	hgbot	Status	new => resolved
2012-07-02 12:35	hgbot	Resolution	open => fixed
2012-07-02 12:35	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/0f7d2b1391ac08e699c5127812d125a98411df08 [^]
2012-07-02 17:43	maite	Note Added: 0050324
2012-07-02 17:43	maite	Status	resolved => closed
2012-07-10 10:35	hudsonbot	Checkin
2012-07-10 10:35	hudsonbot	Note Added: 0050417

Copyright © 2000 - 2009 MantisBT Group