Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020892
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] 07. Sales managementminoralways2012-06-28 17:012012-10-18 11:06
ReporterxabiermerinoView Statuspublic 
Assigned Tojonalegriaesarte 
PrioritynormalResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revisionc265310457cd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0MP12SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020892: It is possible save a good shipment with more quantity than the order

DescriptionYou have achieve this in two ways:

1.-
Create an order with a line: Product A; Quantity 2
Good shipment: Copy the line using 'create lines from'
Change the quantity to 4
The trigger does not allow you save the line

2.-
Create an order with a line: Product A; Quantity 2
Good shipment: Copy the line using 'create lines from'
Copy the same line again using 'create lines from'
you are able to save it

The problem is that the trigger verifies only if the line has the same or less qauntity than the order's one, but does not add qunatity of different lines that are related with the same order's line.
Steps To ReproduceAs admin create an order with a line: Quantity 2
Good shipment: Copy the line using 'create lines from'
Copy the same line again using 'create lines from'
you are able to save it
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0021531 closedioritzCia Changeset c265310457cd does not allow to reactivate orders in environments with shipments with more quantity than the order. 

-  Notes
(0051040)
jonalegriaesarte (reporter)
2012-07-31 17:17

Moved to MP15 due to other priorities
(0051662)
hgbot (developer)
2012-08-30 09:57

Repository: erp/devel/pi
Changeset: c265310457cd89f1e90ea640666ccdb14933c1b0
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Wed Aug 29 10:14:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c265310457cd89f1e90ea640666ccdb14933c1b0 [^]

Fixes issue 20892: Goods Shipment line and Order line relation.
It is possible save a good shipment with more quantity than the order.

---
A src-db/database/model/triggers/M_INOUTLINE_TRG2.xml
---
(0051682)
xabiermerino (reporter)
2012-08-30 13:09

verified
(0051743)
hudsonbot (developer)
2012-09-01 01:03

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05b3ea484705 [^]

Maturity status: Test
(0051940)
ioritzCia (developer)
2012-09-07 14:37

Due to it's complexity this is changed to design defect. There are too many things to think about to be able to provide a simple solution:

- Changing create line process does not entirely fix the problem. As long as the quantity of the order does not get delivered, the create line process will suggest the order and it will copy the original quantity.

- It can be done by a trigger. But this has to take into account that you might want to distribute the quantity among the same goods shipment or different and that you might want to take the quantities from different warehouses.

- Another thing to take into account is isQuantityVariable column in product. If this is checked to yes, greater amounts should be allowed but not as to put double. With this last case the logic's complexity increases a lot.
(0052246)
dmiguelez (developer)
2012-09-19 18:20

Repository: erp/devel/pi
Changeset: 288baadd3b3c79495106300dd43091455064fd84
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Mon Sep 03 12:44:29 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/288baadd3b3c79495106300dd43091455064fd84 [^] [^]

Fixes issue 21531: Backout of the chageset c265310457cd.
Changeset c265310457cd does not allow to reactivate orders in environments with shipments with more quantity than the order.

---
R src-db/database/model/triggers/M_INOUTLINE_TRG2.xml

- Issue History
Date Modified Username Field Change
2012-06-28 17:01 xabiermerino New Issue
2012-06-28 17:01 xabiermerino Assigned To => mirurita
2012-06-28 17:01 xabiermerino Modules => Core
2012-06-28 17:01 xabiermerino Resolution time => 1343858400
2012-06-28 17:01 xabiermerino Issue Monitored: networkb
2012-06-28 17:15 mirurita Assigned To mirurita => jonalegriaesarte
2012-07-16 13:50 jonalegriaesarte Assigned To jonalegriaesarte => ioritzCia
2012-07-25 13:01 ioritzCia Status new => scheduled
2012-07-25 13:01 ioritzCia fix_in_branch => pi
2012-07-31 17:17 jonalegriaesarte Note Added: 0051040
2012-07-31 17:17 jonalegriaesarte Target Version 3.0MP14 => 3.0MP15
2012-07-31 17:17 jonalegriaesarte fix_in_branch pi =>
2012-08-09 13:10 jonalegriaesarte Severity major => minor
2012-08-30 09:57 hgbot Checkin
2012-08-30 09:57 hgbot Note Added: 0051662
2012-08-30 09:57 hgbot Status scheduled => resolved
2012-08-30 09:57 hgbot Resolution open => fixed
2012-08-30 09:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c265310457cd89f1e90ea640666ccdb14933c1b0 [^]
2012-08-30 13:09 xabiermerino Note Added: 0051682
2012-08-30 13:09 xabiermerino Status resolved => closed
2012-09-01 01:03 hudsonbot Checkin
2012-09-01 01:03 hudsonbot Note Added: 0051743
2012-09-03 12:42 ioritzCia Relationship added related to 0021531
2012-09-07 14:27 ioritzCia Status closed => new
2012-09-07 14:27 ioritzCia Resolution fixed => open
2012-09-07 14:37 ioritzCia Note Added: 0051940
2012-09-07 14:37 ioritzCia Type defect => design defect
2012-09-13 10:42 jonalegriaesarte Assigned To ioritzCia => dmiguelez
2012-09-19 13:30 ioritzCia Target Version 3.0MP15 =>
2012-09-19 18:20 dmiguelez Note Added: 0052246
2012-10-18 11:06 naiaramartinez Assigned To dmiguelez => jonalegriaesarte


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker