Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0020869 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2012-06-26 12:48 | 2012-06-30 05:10 | |||
| Reporter | psarobe | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0MP12.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e40f0602d615 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP13 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2012-05-13 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | yes | |||||||
| Summary | 0020869: Change dates in the grid is not working fine. The UI shows the dates changed but in the DB have not being changed | |||||||
| Description | Change dates in the grid is not working fine. The UI shows the dates changed but in the DB have not being changed See attaches | |||||||
| Steps To Reproduce | 1. Go to sales order window 2. Unbook several sales order 3. Change the order date and book every sales order 4. At some point something happens and for some of the orders the order date does not get changed in DB but in the UI so this mislead the end user The problem happens when you use the arrow-down to save/move across records to change the dates If you change the mouse to move/save across records it works fine or using the save button | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  create_shipment_from_orders.JPG [^] (92,965 bytes) 2012-06-26 13:43
sales_order.JPG [^] (154,743 bytes) 2012-06-26 13:43
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0050104) shuehner (administrator) 2012-06-26 17:53 |
Can be reproduced in MP12 but not in MP11 |
|
(0050196) AugustoMauch (administrator) 2012-06-27 19:23 |
In order for this to work, the updateValue function of the date item must be called before OBViewGrid.saveEditedValues, otherwise it will fetch the old date item value. This used to work because prior to the fix of 16502, a call to selectedItem.blur() was done before calling Super('cellEditEnd'). That fix moved the call to blur after the call to Super('cellEditEnd'), so saveEditedValues is fetching the yet-to-be-updated value. |
|
(0050255) mtaal (viewer) 2012-06-28 14:02 |
Hi Augusto, I would add this call to this.storeUpdatedEditorValue() either in celleditend of in saveeditedvalues Can you check if that helps? gr. Martin |
|
(0050257) hgbot (developer) 2012-06-28 16:32 |
Repository: erp/devel/pi Changeset: e40f0602d615e083538c3651c6c2fea6c7a1379e Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Jun 28 16:31:17 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e40f0602d615e083538c3651c6c2fea6c7a1379e [^] Fixes issue 20869: Dates are properly saved in the grid Due to the flags the prevent OBDateItem.updateValue from being called in certain conditions, it was not being executed on ListGrid.cellEditEnd. This has been changed to ensure that the date will be updated before sending its value to the datasource. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
|
(0050259) AugustoMauch (administrator) 2012-06-28 16:46 |
The only change introduced by the fix is that now there is an extra call to updateValue when calling OBViewGrid.cellEditEnd. Test plan: - Add a new record in the grid view. Select a date with the picker and save the row by: *Clicking the save row button *Using the shortcut Ctrl+S *Clicking the up or down arrow button to move to another record *Clicking in another tab - Repeat the previous steps but entering the date manually, not with the picker. - Repeat the previous steps but editing an existing record. - After every change, check that change is actually done by using the filter. |
|
(0050292) hudsonbot (viewer) 2012-06-30 05:10 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ce760b148e29 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-06-26 12:48 | psarobe | New Issue | |
| 2012-06-26 12:48 | psarobe | Assigned To | => AugustoMauch |
| 2012-06-26 12:48 | psarobe | Modules | => Core |
| 2012-06-26 12:48 | psarobe | OBNetwork customer | => No |
| 2012-06-26 12:56 | psarobe | Steps to Reproduce Updated | View Revisions |
| 2012-06-26 13:43 | psarobe | File Added: create_shipment_from_orders.JPG | |
| 2012-06-26 13:43 | psarobe | File Added: sales_order.JPG | |
| 2012-06-26 17:28 | plujan | Regression level | => Production - QA Approved |
| 2012-06-26 17:53 | shuehner | Note Added: 0050104 | |
| 2012-06-26 19:36 | shuehner | Issue Monitored: shuehner | |
| 2012-06-27 19:18 | AugustoMauch | Regression date | => 2012-05-13 |
| 2012-06-27 19:18 | AugustoMauch | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/8f6f2842e1f05bde4cd68f5a75ea7bbc20f3580b [^] |
| 2012-06-27 19:23 | AugustoMauch | Note Added: 0050196 | |
| 2012-06-28 14:02 | mtaal | Note Added: 0050255 | |
| 2012-06-28 16:32 | hgbot | Checkin | |
| 2012-06-28 16:32 | hgbot | Note Added: 0050257 | |
| 2012-06-28 16:32 | hgbot | Status | new => resolved |
| 2012-06-28 16:32 | hgbot | Resolution | open => fixed |
| 2012-06-28 16:32 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e40f0602d615e083538c3651c6c2fea6c7a1379e [^] |
| 2012-06-28 16:46 | AugustoMauch | Note Added: 0050259 | |
| 2012-06-29 16:57 | marvintm | Status | resolved => closed |
| 2012-06-29 16:57 | marvintm | Fixed in Version | => 3.0MP12.1 |
| 2012-06-30 05:10 | hudsonbot | Checkin | |
| 2012-06-30 05:10 | hudsonbot | Note Added: 0050292 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |