0020864: Search Field field can be changed with any module in "in development"

diff --git a/modules/org.openbravo.userinterface.selector/src-db/database/model/triggers/OBUISEL_SELECTOR_FLD_MOD_TRG.xml b/modules/org.openbravo.userinterface.selector/src-db/database/model/triggers/OBUISEL_SELECTOR_FLD_MOD_TRG.xml new file mode 100644 --- /dev/null +++ b/modules/org.openbravo.userinterface.selector/src-db/database/model/triggers/OBUISEL_SELECTOR_FLD_MOD_TRG.xml @@ -0,0 +1,105 @@ +<?xml version="1.0"?> + <database name="TRIGGER OBUISEL_SELECTOR_FLD_MOD_TRG"> + <trigger name="OBUISEL_SELECTOR_FLD_MOD_TRG" table="OBUISEL_SELECTOR_FIELD" fires="before" insert="true" update="true" delete="true" foreach="row"> + <body><![CDATA[ + +/************************************************************************* +* The contents of this file are subject to the Openbravo Public License +* Version 1.1 (the "License"), being the Mozilla Public License +* Version 1.1 with a permitted attribution clause; you may not use this +* file except in compliance with the License. You may obtain a copy of +* the License at http://www.openbravo.com/legal/license.html +* Software distributed under the License is distributed on an "AS IS" +* basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the +* License for the specific language governing rights and limitations +* under the License. +* The Original Code is Openbravo ERP. +* The Initial Developer of the Original Code is Openbravo SLU +* All portions are Copyright (C) 2010 Openbravo SLU +* All Rights Reserved. +* Contributor(s): ______________________________________. +************************************************************************/ + devTemplate NUMBER; + fieldCount NUMBER; + selectorCount NUMBER; + devModule CHAR(1); + currentModuleID VARCHAR2(32); + vAux NUMBER; + +BEGIN + + IF AD_isTriggerEnabled()='N' THEN RETURN; + END IF; + + -- check that we can't change to a module not in development + IF (UPDATING) THEN + IF (COALESCE(:NEW.AD_Module_ID , '.') != COALESCE(:OLD.AD_Module_ID , '.')) THEN + SELECT COUNT(*) + INTO vAux + FROM AD_MODULE + WHERE AD_MODULE_ID = :old.AD_Module_ID + AND isindevelopment = 'N'; + IF (vAux!=0) THEN + RAISE_APPLICATION_ERROR(-20000, '@ChangeNotInDevModule@'); + END IF; + END IF; + END IF; + + SELECT COUNT(*) + INTO devTemplate + FROM AD_MODULE + WHERE IsInDevelopment = 'Y' + AND Type = 'T'; + + IF (UPDATING OR INSERTING) THEN + currentModuleID := :new.AD_Module_ID; + ELSE + currentModuleID := :old.AD_Module_ID; + END IF; + + SELECT M.IsInDevelopment + INTO devModule + FROM AD_MODULE M + WHERE M.AD_MODULE_ID = currentModuleID; + + IF (UPDATING AND devTemplate=0 AND devModule='N') THEN + IF ( + COALESCE(:NEW.AD_Client_ID , '.') != COALESCE(:OLD.AD_Client_ID , '.') OR + COALESCE(:NEW.AD_Org_ID , '.') != COALESCE(:OLD.AD_Org_ID , '.') OR + COALESCE(:NEW.AD_Module_ID , '.') != COALESCE(:OLD.AD_Module_ID , '.') OR + COALESCE(:NEW.IsActive , '.') != COALESCE(:OLD.IsActive , '.') OR + COALESCE(:NEW.Name , '.') != COALESCE(:OLD.Name , '.') OR + COALESCE(:NEW.Description , '.') != COALESCE(:OLD.Description , '.') OR + COALESCE(:NEW.Help , '.') != COALESCE(:OLD.Help , '.') OR + COALESCE(:NEW.obuisel_selector_field_id , '.') != COALESCE(:OLD.obuisel_selector_field_id , '.') OR + COALESCE(:NEW.obuisel_selector_id , '.') != COALESCE(:OLD.obuisel_selector_id , '.') OR + COALESCE(:NEW.ad_column_id , '.') != COALESCE(:OLD.ad_column_id , '.') OR + COALESCE(:NEW.property , '.') != COALESCE(:OLD.property , '.') OR + COALESCE(:NEW.obserds_datasource_field_id , '.') != COALESCE(:OLD.obserds_datasource_field_id , '.') OR + COALESCE(:NEW.iscentrallymaintained , '.') != COALESCE(:OLD.iscentrallymaintained , '.') OR + COALESCE(:NEW.sort , '.') != COALESCE(:OLD.sort , '.') OR + COALESCE(:NEW.filter , '.') != COALESCE(:OLD.filter , '.') OR + COALESCE(:NEW.searchinsuggestionbox , '.') != COALESCE(:OLD.searchinsuggestionbox , '.') OR + COALESCE(:NEW.showingrid , '.') != COALESCE(:OLD.showingrid , '.') OR + COALESCE(:NEW.sortno , 0) != COALESCE(:OLD.sortno , 0) OR + COALESCE(:NEW.isoutfield , '.') != COALESCE(:OLD.isoutfield , '.') OR + COALESCE(:NEW.default_expression , '.') != COALESCE(:OLD.default_expression , '.') OR + COALESCE(:NEW.suffix , '.') != COALESCE(:OLD.suffix , '.') OR + COALESCE(:NEW.display_expression , '.') != COALESCE(:OLD.display_expression , '.') OR + COALESCE(:NEW.clause_left_part , '.') != COALESCE(:OLD.clause_left_part , '.') OR + COALESCE(:NEW.ad_reference_id , '.') != COALESCE(:OLD.ad_reference_id , '.') OR + COALESCE(:NEW.showinpicklist , '.') != COALESCE(:OLD.showinpicklist , '.') OR + 1=2) THEN + RAISE_APPLICATION_ERROR(-20000, '@20532@'); + END IF; + END IF; + + + -- don't allow insert/delete if not in development + IF ((DELETING OR INSERTING) AND devModule='N') THEN + RAISE_APPLICATION_ERROR(-20000, '@20533@'); + END IF; +END OBUISEL_SELECTOR_FLD_MOD_TRG +]]></body> + </trigger> + </database>

Notes
(0050534) AugustoMauch (manager) 2012-07-12 16:36	A fix for this issue has been attached. A trigger has been added to the table obuisel_selector_field to check that the field module is in development.

(0050769) hgbot (developer) 2012-07-20 10:29	Repository: erp/devel/pi Changeset: 76004d285e859fe3f589118de4258e41130894c1 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Jul 20 10:26:18 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/76004d285e859fe3f589118de4258e41130894c1 [^] Fixes issue 20864: Fields can not be modified in a module not in development The trigger to check that the module was in development was missing the in obuisel_selector_field table. --- A modules/org.openbravo.userinterface.selector/src-db/database/model/triggers/OBUISEL_SELECTOR_FLD_MOD_TRG.xml ---

(0050770) hgbot (developer) 2012-07-20 10:50	Repository: erp/devel/pi Changeset: 055275270ba380c6848e9c9476a5e885a9fb9c60 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Jul 20 10:49:59 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/055275270ba380c6848e9c9476a5e885a9fb9c60 [^] Related to issue 20864: Fixed copyright year of new trigger --- M modules/org.openbravo.userinterface.selector/src-db/database/model/triggers/OBUISEL_SELECTOR_FLD_MOD_TRG.xml ---

(0050863) hudsonbot (developer) 2012-07-26 02:42	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^] Maturity status: Test

(0050864) hudsonbot (developer) 2012-07-26 02:42	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^] Maturity status: Test

(0050913) caristu (developer) 2012-07-26 17:23	Verified

Issue History
Date Modified	Username	Field	Change
2012-06-26 09:51	caristu	New Issue
2012-06-26 09:51	caristu	Assigned To	=> alostale
2012-06-26 09:51	caristu	Modules	=> Core
2012-06-26 09:51	caristu	Resolution time	=> 1346623200
2012-06-26 09:51	caristu	Issue Monitored: networkb
2012-07-12 11:44	AugustoMauch	Assigned To	alostale => AugustoMauch
2012-07-12 15:13	alostale	Assigned To	AugustoMauch => guilleaer
2012-07-12 16:32	AugustoMauch	File Added: issue20864.diff
2012-07-12 16:33	AugustoMauch	Assigned To	guilleaer => AugustoMauch
2012-07-12 16:33	AugustoMauch	Status	new => scheduled
2012-07-12 16:33	AugustoMauch	fix_in_branch	=> pi
2012-07-12 16:36	AugustoMauch	Note Added: 0050534
2012-07-20 10:29	hgbot	Checkin
2012-07-20 10:29	hgbot	Note Added: 0050769
2012-07-20 10:29	hgbot	Status	scheduled => resolved
2012-07-20 10:29	hgbot	Resolution	open => fixed
2012-07-20 10:29	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/76004d285e859fe3f589118de4258e41130894c1 [^]
2012-07-20 10:50	hgbot	Checkin
2012-07-20 10:50	hgbot	Note Added: 0050770
2012-07-26 02:42	hudsonbot	Checkin
2012-07-26 02:42	hudsonbot	Note Added: 0050863
2012-07-26 02:42	hudsonbot	Checkin
2012-07-26 02:42	hudsonbot	Note Added: 0050864
2012-07-26 17:23	caristu	Note Added: 0050913
2012-07-26 17:23	caristu	Status	resolved => closed

Relationships [ Relation Graph ] [ Dependency Graph ]