Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020624
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2012-05-28 15:402012-05-30 18:13
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PriorityhighResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchFixed in SCM revision237ce7d9967e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020624: The check for local changes should be done before installing any modules or updates

DescriptionCurrently, the update.database task searches for possible local changes (in structure and data) in the database, and stops if it finds them, because the process would revert them.

However, in case a user installs a module in an instance with local changes, and then tries to do a rebuild (which stops because these local changes are found), he is in a difficult situation, because to be able to export his changes correctly, he needs to revert the installed modules first.

The correct thing to do would be to check if these local changes exist before allowing the user to install anything. This way, the changes would be detected early, and the user would be able to resolve his problems much easier.
Steps To Reproduce- Create a local change (by changing an AD element, for instance).
- Try to install a module. Notice that it can be done.
- Try to rebuild. The rebuild will fail, because the check for local changes will find your change.
Proposed SolutionThe install process will automatically search for local changes before doing anything else.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0049381)
hgbot (developer)
2012-05-28 17:54

Repository: erp/devel/pi
Changeset: 237ce7d9967e2037002129532d6e92e7bf58ab5e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 28 17:37:06 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/237ce7d9967e2037002129532d6e92e7bf58ab5e [^]

Fixed issue 20624. When installing/updating modules, the check for local changes will be done.
This check will from now on be done early, before installing anything, to prevent a situation in which the user installs modules, but then the rebuild fails with local changes. If these changes are detected early, then the user can more easily fix them by just exporting his changes before proceeding with the installation.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
A src/org/openbravo/erpCommon/ad_forms/ModuleManagement_LocalChanges.html
A src/org/openbravo/erpCommon/ad_forms/ModuleManagement_LocalChanges.xml
---
(0049394)
alostale (manager)
2012-05-29 08:35

code reviewed and verified on pi@0ed463f70606
(0049499)
hudsonbot (developer)
2012-05-30 18:13

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3752a665362c [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-28 15:40 marvintm New Issue
2012-05-28 15:40 marvintm Assigned To => marvintm
2012-05-28 15:40 marvintm Modules => Core
2012-05-28 17:54 hgbot Checkin
2012-05-28 17:54 hgbot Note Added: 0049381
2012-05-28 17:54 hgbot Status new => resolved
2012-05-28 17:54 hgbot Resolution open => fixed
2012-05-28 17:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/237ce7d9967e2037002129532d6e92e7bf58ab5e [^]
2012-05-29 08:35 alostale Note Added: 0049394
2012-05-29 08:35 alostale Status resolved => closed
2012-05-29 08:35 alostale Fixed in Version => 3.0MP12
2012-05-30 18:13 hudsonbot Checkin
2012-05-30 18:13 hudsonbot Note Added: 0049499


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker