Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020590
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] 09. Financial managementminoralways2012-05-23 13:502012-06-30 05:10
ReportermalsasuaView Statuspublic 
Assigned Toeduardo_Argal 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision37ec59d17ce1
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned To
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020590: method getDocumentConfirmation in DocXXX files is not customizable

DescriptionThe method getDocumentConfirmation in Doc files of accounting process should be customizable in a accounting template
Steps To Reproduce.create an accounting template and customize this method
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
has duplicate defect 00203463.0MP12 closedjecharri It should exist the posibility to define method "getDocumentConfirmation" in accounting templates 

-  Notes
(0049778)
eduardo_Argal (developer)
2012-06-12 17:30

"getDocumentConfirmation" is a method inside AcctServer which confirms a document is valid to be posted. This confirmation is run once and not once per accounting schema. Accounting templates applies to one single accounting schema, so it can not implement this method. It is true that now a days it may collide with existing templates as it could avoid template logic to be executed.
Proposed solution is to disable this confirmation when a template exists so that this validation needs to happen in template execution being this logic relegated to the template.
(0049791)
hgbot (developer)
2012-06-13 09:50

Repository: erp/devel/pi
Changeset: 8972f5cea24b3f2fbbaeba53eeb288afadd6d42e
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Tue Jun 12 17:30:48 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8972f5cea24b3f2fbbaeba53eeb288afadd6d42e [^]

Fixes bug 20590

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0049831)
eduardo_Argal (developer)
2012-06-14 11:37

https://code.openbravo.com/erp/devel/pi/rev/f210c7b288349b43e45369ad85d000cfafa6e882 [^]
(0049832)
eduardo_Argal (developer)
2012-06-14 11:38

Previous note is an additional change set required to fix this issue
(0050263)
hgbot (developer)
2012-06-28 18:29

Repository: erp/devel/pi
Changeset: 37ec59d17ce13d5172bc3923b8f1a9bb2b78cb40
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Thu Jun 28 18:28:10 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/37ec59d17ce13d5172bc3923b8f1a9bb2b78cb40 [^]

Fixes bug 20590. Code review applied + fix possible error

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0050271)
dmiguelez (developer)
2012-06-29 10:02

Code review + Tested
(0050295)
hudsonbot (developer)
2012-06-30 05:10

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ce760b148e29 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-23 13:50 malsasua New Issue
2012-05-23 13:50 malsasua Assigned To => eduardo_Argal
2012-05-23 13:50 malsasua Web browser => Google Chrome
2012-05-23 13:50 malsasua Modules => Core
2012-05-24 09:17 jonalegriaesarte Relationship added has duplicate 0020346
2012-06-01 12:00 dmiguelez Assigned To eduardo_Argal => dmiguelez
2012-06-01 12:19 dmiguelez Web browser Google Chrome => Google Chrome
2012-06-01 12:19 dmiguelez Type defect => design defect
2012-06-06 16:00 jecharri Issue Monitored: jecharri
2012-06-12 17:30 eduardo_Argal Status new => scheduled
2012-06-12 17:30 eduardo_Argal Note Added: 0049778
2012-06-12 17:30 eduardo_Argal Assigned To dmiguelez => eduardo_Argal
2012-06-12 17:30 eduardo_Argal fix_in_branch => pi
2012-06-13 09:50 hgbot Checkin
2012-06-13 09:50 hgbot Note Added: 0049791
2012-06-13 09:50 hgbot Status scheduled => resolved
2012-06-13 09:50 hgbot Resolution open => fixed
2012-06-13 09:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8972f5cea24b3f2fbbaeba53eeb288afadd6d42e [^]
2012-06-14 11:37 eduardo_Argal Note Added: 0049831
2012-06-14 11:38 eduardo_Argal Note Added: 0049832
2012-06-28 18:29 hgbot Checkin
2012-06-28 18:29 hgbot Note Added: 0050263
2012-06-28 18:29 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/8972f5cea24b3f2fbbaeba53eeb288afadd6d42e [^] => http://code.openbravo.com/erp/devel/pi/rev/37ec59d17ce13d5172bc3923b8f1a9bb2b78cb40 [^]
2012-06-29 10:02 dmiguelez Note Added: 0050271
2012-06-29 10:03 dmiguelez Status resolved => closed
2012-06-30 05:10 hudsonbot Checkin
2012-06-30 05:10 hudsonbot Note Added: 0050295


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker