Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020590Openbravo ERP09. Financial managementpublic2012-05-23 13:502012-06-30 05:10
Reportermalsasua 
Assigned Toeduardo_Argal 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020590: method getDocumentConfirmation in DocXXX files is not customizable
DescriptionThe method getDocumentConfirmation in Doc files of accounting process should be customizable in a accounting template
Steps To Reproduce.create an accounting template and customize this method
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 00203463.0MP12 closed jecharri It should exist the posibility to define method "getDocumentConfirmation" in accounting templates 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-23 13:50malsasuaNew Issue
2012-05-23 13:50malsasuaAssigned To => eduardo_Argal
2012-05-23 13:50malsasuaWeb browser => Google Chrome
2012-05-23 13:50malsasuaModules => Core
2012-05-24 09:17jonalegriaesarteRelationship addedhas duplicate 0020346
2012-06-01 12:00dmiguelezAssigned Toeduardo_Argal => dmiguelez
2012-06-01 12:19dmiguelezWeb browserGoogle Chrome => Google Chrome
2012-06-01 12:19dmiguelezTypedefect => design defect
2012-06-06 16:00jecharriIssue Monitored: jecharri
2012-06-12 17:30eduardo_ArgalStatusnew => scheduled
2012-06-12 17:30eduardo_ArgalNote Added: 0049778
2012-06-12 17:30eduardo_ArgalAssigned Todmiguelez => eduardo_Argal
2012-06-12 17:30eduardo_Argalfix_in_branch => pi
2012-06-13 09:50hgbotCheckin
2012-06-13 09:50hgbotNote Added: 0049791
2012-06-13 09:50hgbotStatusscheduled => resolved
2012-06-13 09:50hgbotResolutionopen => fixed
2012-06-13 09:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8972f5cea24b3f2fbbaeba53eeb288afadd6d42e [^]
2012-06-14 11:37eduardo_ArgalNote Added: 0049831
2012-06-14 11:38eduardo_ArgalNote Added: 0049832
2012-06-28 18:29hgbotCheckin
2012-06-28 18:29hgbotNote Added: 0050263
2012-06-28 18:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/8972f5cea24b3f2fbbaeba53eeb288afadd6d42e [^] => http://code.openbravo.com/erp/devel/pi/rev/37ec59d17ce13d5172bc3923b8f1a9bb2b78cb40 [^]
2012-06-29 10:02dmiguelezNote Added: 0050271
2012-06-29 10:03dmiguelezStatusresolved => closed
2012-06-30 05:10hudsonbotCheckin
2012-06-30 05:10hudsonbotNote Added: 0050295

Notes
(0049778)
eduardo_Argal   
2012-06-12 17:30   
"getDocumentConfirmation" is a method inside AcctServer which confirms a document is valid to be posted. This confirmation is run once and not once per accounting schema. Accounting templates applies to one single accounting schema, so it can not implement this method. It is true that now a days it may collide with existing templates as it could avoid template logic to be executed.
Proposed solution is to disable this confirmation when a template exists so that this validation needs to happen in template execution being this logic relegated to the template.
(0049791)
hgbot   
2012-06-13 09:50   
Repository: erp/devel/pi
Changeset: 8972f5cea24b3f2fbbaeba53eeb288afadd6d42e
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Tue Jun 12 17:30:48 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8972f5cea24b3f2fbbaeba53eeb288afadd6d42e [^]

Fixes bug 20590

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0049831)
eduardo_Argal   
2012-06-14 11:37   
https://code.openbravo.com/erp/devel/pi/rev/f210c7b288349b43e45369ad85d000cfafa6e882 [^]
(0049832)
eduardo_Argal   
2012-06-14 11:38   
Previous note is an additional change set required to fix this issue
(0050263)
hgbot   
2012-06-28 18:29   
Repository: erp/devel/pi
Changeset: 37ec59d17ce13d5172bc3923b8f1a9bb2b78cb40
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Thu Jun 28 18:28:10 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/37ec59d17ce13d5172bc3923b8f1a9bb2b78cb40 [^]

Fixes bug 20590. Code review applied + fix possible error

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0050271)
dmiguelez   
2012-06-29 10:02   
Code review + Tested
(0050295)
hudsonbot   
2012-06-30 05:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ce760b148e29 [^]

Maturity status: Test