0020498: With big number of rows in ad_session SqlC somtimes fail with OOM regarding heap-space

Description

With a sufficiently high number of rows in ad_session sometimes compilation fails with an OOM error regarding heap-space when processing the SessionLogin_data.xsql file.

Checking it shows that the first method in that file does 'select * from ad_session' without any filters but is never ever called from the erp.

As the xsql-file is not public that dummy method should be fixed or just be removed.

Steps To Reproduce

i.e. compile on butler

Proposed Solution

Reorder SqlMethods in that file not require an unused dummy method.

Attached patch implements that (only compile tested)

Tags

Performance

Attached Files

xsql-oom-ad_session.diff [^] (1,503 bytes) 2012-05-14 18:45 [Show Content] [Hide Content]

diff -r 075bbec1e396 src/org/openbravo/erpCommon/security/SessionLogin_data.xsql
--- a/src/org/openbravo/erpCommon/security/SessionLogin_data.xsql	Thu May 10 09:17:40 2012 +0200
+++ b/src/org/openbravo/erpCommon/security/SessionLogin_data.xsql	Thu May 10 11:40:58 2012 +0200
@@ -20,14 +20,16 @@
 
 <SqlClass name="SessionLoginData" package="org.openbravo.erpCommon.security">
    <SqlClassComment></SqlClassComment>
-   <SqlMethod name="select" type="preparedStatement" return="multiple">
-      <SqlMethodComment></SqlMethodComment>
-      <Sql>
-        select * from ad_session
-      </Sql>
+   
+  <SqlMethod name="activeSessions" type="preparedStatement" return="multiple">
+    <Sql><![CDATA[
+        SELECT AD_SESSION_ID, SERVER_URL
+          FROM AD_SESSION
+         WHERE SESSION_ACTIVE = 'Y'
+    ]]></Sql>
       <Field name="supportContact" value=""/>
-   </SqlMethod>
-   
+  </SqlMethod>
+
     <SqlMethod name="deactivate" type="preparedStatement" return="rowCount">
     <Sql><![CDATA[
         UPDATE AD_Session
@@ -46,15 +48,7 @@
     ]]></Sql>
     <Parameter name="adSessionId"/>
   </SqlMethod>
-  
-  <SqlMethod name="activeSessions" type="preparedStatement" return="multiple">
-    <Sql><![CDATA[
-        SELECT AD_SESSION_ID, SERVER_URL
-          FROM AD_SESSION
-         WHERE SESSION_ACTIVE = 'Y'
-    ]]></Sql>
-  </SqlMethod>
-  
+
   <SqlMethod name="selectSupportContact" type="preparedStatement" return="string">
     <Sql><![CDATA[
         SELECT SUPPORT_CONTACT

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0048669) hgbot (developer) 2012-05-16 08:25	Repository: erp/devel/pi Changeset: d4ef642f1e2aea82ef2afa8619f971f00f82272a Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Wed May 16 08:24:37 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/d4ef642f1e2aea82ef2afa8619f971f00f82272a [^] fixed bug 20498: Heap space error in SqlC with big number of rows in ad_session --- M src/org/openbravo/erpCommon/security/SessionLogin_data.xsql ---

(0048670) alostale (viewer) 2012-05-16 08:25	Code reviewed and tested on pi@d4ef642f1e2a

(0049142) hudsonbot (viewer) 2012-05-25 12:12	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-05-14 18:45	shuehner	New Issue
2012-05-14 18:45	shuehner	Assigned To	=> alostale
2012-05-14 18:45	shuehner	File Added: xsql-oom-ad_session.diff
2012-05-14 18:45	shuehner	Modules	=> Core
2012-05-14 18:45	shuehner	OBNetwork customer	=> No
2012-05-16 08:23	alostale	Tag Attached: Performance
2012-05-16 08:25	hgbot	Checkin
2012-05-16 08:25	hgbot	Note Added: 0048669
2012-05-16 08:25	hgbot	Status	new => resolved
2012-05-16 08:25	hgbot	Resolution	open => fixed
2012-05-16 08:25	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/d4ef642f1e2aea82ef2afa8619f971f00f82272a [^]
2012-05-16 08:25	alostale	Note Added: 0048670
2012-05-16 08:25	alostale	Status	resolved => closed
2012-05-16 08:25	alostale	Fixed in Version	=> 3.0MP12
2012-05-25 12:12	hudsonbot	Checkin
2012-05-25 12:12	hudsonbot	Note Added: 0049142