Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020496
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2012-05-14 16:582012-06-12 17:00
ReporteregoitzView Statuspublic 
Assigned Tomigueldejuana 
PriorityurgentResolutionfixedFixed in Version3.0MP13
StatusclosedFix in branchFixed in SCM revision0b5e6502cd76
ProjectionnoneETAnoneTarget Version3.0MP13
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0MP10.2SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020496: The date on the process monitor window changes when moving from form to grid depending on the timezone

DescriptionThe date on the process monitor window changes when moving from form to grid depending on the timezone.

When accessing to an application on from a client on USA the time on grid is one day bigger than the date on the form.

Attached two images.
Steps To Reproduce-From a computer on a Usa access to demo.openbravo.com
-Go to process monitor
-Select a row with a data for example 14-05-2012 09:30:00
-Open on form view. The data changes to 14-05-2012 19:00:00
TagsNo tags attached.
Attached Files? file icon issue20496.commit [^] (4,284 bytes) 2012-05-29 09:45

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 00204973.0MP12 closedalostale The date on the process monitor window changes when moving from form to grid depending on the timezone. 
related to defect 0020543 closedalostale Saving failed. java.text.ParseException: Unparseable date - when using a US date formatting 
related to design defect 0020563 closedalostale In Process Request window, Start Date doesn't change depending on our timezone 
related to defect 0020684 closedAugustoMauch Incorrect time in process request with different timezones in client/server 

-  Notes
(0048741)
migueldejuana (developer)
2012-05-17 16:53

 Opening form view, the startTime and endTime is changed to our timezone (in the grid it is already done).
The problem is in the processColumnValue method of the ob-view-form.js. The Date elements are processed AGAIN to be changed to our timezone and it causes an error when our timezone is a negative timezone(UTC-1 ,UTC-2...).
References "Date" and "DateTime" don't need to be processed in processColumnValue but "Time" reference has not been processed yet and it have to be changed to our timezone in processColumnValue.
(0048742)
migueldejuana (developer)
2012-05-17 18:01

 Risky fix.

Test plan:
It is enough if we change our computer timezone to prove it.
Prove it with different timezones (i.e:USA, Spain and India):

-Go to process monitor
-Select a row with a data for example 14-05-2012 09:30:00
-Open on form view. The data changes to 14-05-2012 19:00:00

There could be more cases not covered.
(0048743)
hgbot (developer)
2012-05-17 18:08

 Repository: erp/devel/pi
Changeset: f63f8665c1affa8e5594b0018508f73e2db86204
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu May 17 18:06:47 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f63f8665c1affa8e5594b0018508f73e2db86204 [^]

Fixed issue 20496: ProcessMonitor-FormView, negative Timezone print well DateTime
In Process Monitor window, opening form view, the startTime and endTime is changed to our timezone (in the grid it is already done).
The problem is in the processColumnValue method of the ob-view-form.js. The Date elements are processed AGAIN to be changed to our timezone and it causes an error when our timezone is a negative timezone(UTC-1 ,UTC-2...).
References "Date" and "DateTime" don't need to be processed in processColumnValue but "Time" reference has not been processed yet and it have to be changed to our timezone in processColumnValue.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0048767)
hgbot (developer)
2012-05-18 14:24

 Repository: erp/devel/pi
Changeset: 6a99934dbfc9271c7b1eb4ce4935dd58614a3269
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri May 18 14:23:27 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6a99934dbfc9271c7b1eb4ce4935dd58614a3269 [^]

Related to issue 20496: Backout error dateTime ProcessMonitor and code format

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0049158)
hudsonbot (developer)
2012-05-25 12:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049163)
hudsonbot (developer)
2012-05-25 12:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049404)
migueldejuana (developer)
2012-05-29 09:54

 It has been attached 'issue20496.commit' with the fix to this issue. It has not been pushed because it need to be tested.

Cases to test(following steps to reproduce):

- Server in negative timezone(San Francisco) and client in Madrid.
- Server in positive timezone(Tokyo) and client in Madrid.
- Test with differents date formats.
- If there are more DateTime in other windows, test their behaviour.
(0049775)
hgbot (developer)
2012-06-12 16:57

 Repository: erp/devel/pi
Changeset: 0b5e6502cd763b19322b45532b771ae678dd40f2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed May 23 10:55:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0b5e6502cd763b19322b45532b771ae678dd40f2 [^]

Fixed issue 20496: Process Monitor in Form view, startTime for all timezones
In Process Monitor window, When we open Form view, the StartTime field was wrong in some timezones. Now it works well.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/DateTimeUIDefinition.java
---
(0049776)
AugustoMauch (administrator)
2012-06-12 17:00

 Code reviewed and verified in pi@0b5e6502cd76

- Issue History
Date Modified Username Field Change
2012-05-14 16:58 egoitz New Issue
2012-05-14 16:58 egoitz Assigned To => alostale
2012-05-14 16:58 egoitz Modules => Core
2012-05-14 16:58 egoitz Resolution time => 1339711200
2012-05-15 09:13 alostale Relationship added has duplicate 0020497
2012-05-15 16:09 alostale Assigned To alostale => migueldejuana
2012-05-17 16:53 migueldejuana Note Added: 0048741
2012-05-17 18:01 migueldejuana Note Added: 0048742
2012-05-17 18:08 hgbot Checkin
2012-05-17 18:08 hgbot Note Added: 0048743
2012-05-17 18:08 hgbot Status new => resolved
2012-05-17 18:08 hgbot Resolution open => fixed
2012-05-17 18:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f63f8665c1affa8e5594b0018508f73e2db86204 [^]
2012-05-18 07:57 alostale Relationship added related to 0020543
2012-05-18 14:24 hgbot Checkin
2012-05-18 14:24 hgbot Note Added: 0048767
2012-05-18 14:26 migueldejuana Status resolved => new
2012-05-18 14:26 migueldejuana Resolution fixed => open
2012-05-21 17:25 migueldejuana Relationship added related to 0020563
2012-05-25 12:12 hudsonbot Checkin
2012-05-25 12:12 hudsonbot Note Added: 0049158
2012-05-25 12:12 hudsonbot Checkin
2012-05-25 12:12 hudsonbot Note Added: 0049163
2012-05-29 09:45 migueldejuana File Added: issue20496.commit
2012-05-29 09:54 migueldejuana Note Added: 0049404
2012-05-29 11:54 jonalegriaesarte Target Version 3.0MP12 => 3.0MP13
2012-06-06 09:41 alostale Relationship added related to 0020684
2012-06-12 16:57 hgbot Checkin
2012-06-12 16:57 hgbot Note Added: 0049775
2012-06-12 16:57 hgbot Status new => resolved
2012-06-12 16:57 hgbot Resolution open => fixed
2012-06-12 16:57 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/f63f8665c1affa8e5594b0018508f73e2db86204 [^] => http://code.openbravo.com/erp/devel/pi/rev/0b5e6502cd763b19322b45532b771ae678dd40f2 [^]
2012-06-12 17:00 AugustoMauch Note Added: 0049776
2012-06-12 17:00 AugustoMauch Status resolved => closed
2012-06-12 17:00 AugustoMauch Fixed in Version => 3.0MP13

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker