Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020495
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2012-05-14 16:552012-05-25 12:12
ReportershuehnerView Statuspublic 
Assigned Tomarvintm 
PriorityhighResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchFixed in SCM revision9d97cd717801
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020495: ant smartbuild (called without -Dlocal=no) should not call apply.module

DescriptionCalling:
1.) ant smartbuild -> does call apply.module once (via smartbuild directly)
2.) ant smartbuild -Dlocal=no -> does call apply.module twice (once indirectly via the update.database call + a second one like in case 1.)

As an apply.module not doing anything can cost up to 20s of runtime (indirect cost because of compile.apply.module) it should not be run twice.

Also ant smartbuild without the '-Dlocal=no' option does not request to update the database but apply.module does exactly that (import referencedata + translations).

Thus the function of 'ant smartbuild' should be changed to not call any 'apply.module' itself but only indirectly when requested via '-Dlocal=no'


Note: This is a behaviour change and probably should be announced somehow to all developers.
Steps To Reproduce-
Proposed SolutionThus the function of 'ant smartbuild' should be changed to not call any 'apply.module' itself but only indirectly when requested via '-Dlocal=no'
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0048645)
hgbot (developer)
2012-05-15 12:02

 Repository: erp/devel/pi
Changeset: 9d97cd71780173b4e52929001009a8a0123e29cd
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue May 15 12:01:27 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9d97cd71780173b4e52929001009a8a0123e29cd [^]

Fixed issue 20495. Apply.module has been removed from smartbuild.
- As update.database already calls apply.module, it was called twice in case smartbuild was called with -Dlocal=no.
- In case -Dlocal=no was not used, it was actually incorrect, as the user didn't specify that he wanted to update the database (that's what -Dlocal means).

---
M build.xml
---
(0048677)
alostale (manager)
2012-05-16 09:06

 Code reviewed and verified on pi@d4ef642f1e2a
(0049130)
hudsonbot (developer)
2012-05-25 12:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-14 16:55 shuehner New Issue
2012-05-14 16:55 shuehner Assigned To => marvintm
2012-05-14 16:55 shuehner Modules => Core
2012-05-15 12:02 hgbot Checkin
2012-05-15 12:02 hgbot Note Added: 0048645
2012-05-15 12:02 hgbot Status new => resolved
2012-05-15 12:02 hgbot Resolution open => fixed
2012-05-15 12:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9d97cd71780173b4e52929001009a8a0123e29cd [^]
2012-05-16 09:05 alostale Tag Attached: Performance
2012-05-16 09:06 alostale Note Added: 0048677
2012-05-16 09:06 alostale Status resolved => closed
2012-05-16 09:06 alostale Fixed in Version => 3.0MP12
2012-05-25 12:12 hudsonbot Checkin
2012-05-25 12:12 hudsonbot Note Added: 0049130

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker