Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020470
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionarytrivialalways2012-05-11 09:052012-05-31 11:31
ReporterSandrahuguetView Statuspublic 
Assigned ToSandrahuguet 
PriorityimmediateResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchFixed in SCM revision78e4246be14f
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned To
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020470: API Change: Change username column to NVARCHAR type in ad_user table

DescriptionIt only fails in Oracle.
Username column is defined as VARCHAR(60), and you cannot enter a 60 character long username in oracle containing special characters as @, _, ñ, ...
Username column should be defined as NVARCHAR(60) in ad_user table.
With the proposed solution "select COALESCE(TO_CHAR(name), username) from ad_user" does not work.
We have checked in all Openbravo code and modules and this code does not appear, consecuently this API change is not risk.
Steps To Reproduce[in oracle]
1) Go to User window
2) Enter a 60 character long username containing at least one special character
@bcdefghijklmñopqrstuvwzyz_abcdefghijklmnopqrstuvwzyz2345679
3) Try to save the record

Error
Saving failed. ORA-12899: value too large for column "INT_FULL_ORACLE"."AD_USER"."USERNAME" (actual: 61, maximum: 60)

1) Login as System Administrator
2) Go to Initial Client Setup window
3) Enter a 60 character long Client Username containing at least one special character
@bcdefghijklmñopqrstuvwzyz_abcdefghijklmnopqrstuvwzyz2345679
4) Fill other mandatory fields
5) Click on OK button

Error
Saving failed. ORA-12899: value too large for column "INT_FULL_ORACLE"."AD_USER"."USERNAME" (actual: 61, maximum: 60)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0020342 closedSandrahuguet Error when creating an user (in oracle) with username of 60 character long (containing special characters as @, _, ...) 

-  Notes
(0048574)
iciordia (manager)
2012-05-11 12:39

 Sandra, I need you to include a risk statement on this API change (what is the the likelihood of breaking modules or failing instance updates due to this change). It should be included in EVERY api change issue.

Thanks,

Ismael
(0048580)
Sandrahuguet (developer)
2012-05-11 13:53

 Risk statement:
- It only fails in Oracle: only instances using Oracle could be affected.
- No data problems: with NVARCHAR the number of characters allowed is actually 60 (including special characters). Before it was not possible to have an username of 60 characters containing special characters.
- The Java API has not changed both types are treated as string in Java. getUserName and setUsername

- Possible issue: using the username column (with the new type) in a coalesce that before worked, now, after the change it will fail.
   Oracle returns the following error:
   Error SQL: ORA-12704: no coincide el juego de caracteres
12704. 00000 - "character set mismatch"

- We have checked in all Openbravo code and we are not using this
- We have checked in all central repository modules and this code also does not appear.
   
- Furthermore, the api-check considers this change as a warning. This is the result:

[checkAPI] 31210 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 31219 WARN - Warnings in API model validation
 [checkAPI] 31228 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 31236 WARN - Column type change from VARCHAR to NVARCHAR: column:AD_USER.USERNAME
(0048591)
iciordia (manager)
2012-05-12 12:24

 Approved.

Ismael
(0048744)
hgbot (developer)
2012-05-17 18:14

 Repository: erp/devel/api-checks
Changeset: dd6185a8cb012fe6cdfdbd16aab1d1daf7fa2b51
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Thu May 17 18:01:06 2012 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/dd6185a8cb012fe6cdfdbd16aab1d1daf7fa2b51 [^]

Fixed issue 20470: API Change: Change username column to NVARCHAR in ad_user table

---
M model/src-db/database/model/tables/AD_USER.xml
---
(0048844)
hgbot (developer)
2012-05-22 09:30

 Repository: erp/devel/api-checks
Changeset: 78e4246be14f68175382b004239535410fefce75
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Thu May 17 18:01:06 2012 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/78e4246be14f68175382b004239535410fefce75 [^]

Fixed issue 20470: API Change: Change username column to NVARCHAR in ad_user table

---
M model/src-db/database/model/tables/AD_USER.xml
---
(0049524)
mirurita (developer)
2012-05-31 11:31

 API change risk analyzed and approved.

- Issue History
Date Modified Username Field Change
2012-05-11 09:05 Sandrahuguet New Issue
2012-05-11 09:05 Sandrahuguet Assigned To => iciordia
2012-05-11 09:05 Sandrahuguet Web browser => Google Chrome
2012-05-11 09:05 Sandrahuguet Modules => Core
2012-05-11 09:05 Sandrahuguet Relationship added related to 0020342
2012-05-11 12:39 iciordia Note Added: 0048574
2012-05-11 13:53 Sandrahuguet Note Added: 0048580
2012-05-12 12:24 iciordia Note Added: 0048591
2012-05-12 12:24 iciordia Assigned To iciordia => Sandrahuguet
2012-05-17 18:14 hgbot Checkin
2012-05-17 18:14 hgbot Note Added: 0048744
2012-05-17 18:14 hgbot Status new => resolved
2012-05-17 18:14 hgbot Resolution open => fixed
2012-05-17 18:14 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/dd6185a8cb012fe6cdfdbd16aab1d1daf7fa2b51 [^]
2012-05-22 09:30 hgbot Checkin
2012-05-22 09:30 hgbot Note Added: 0048844
2012-05-22 09:30 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/api-checks/rev/dd6185a8cb012fe6cdfdbd16aab1d1daf7fa2b51 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/78e4246be14f68175382b004239535410fefce75 [^]
2012-05-31 11:31 mirurita Note Added: 0049524
2012-05-31 11:31 mirurita Status resolved => closed
2012-05-31 11:31 mirurita Fixed in Version => 3.0MP12

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker