0020395: P&E: editable fields must be in edit mode at the start

Description

As per Paolo´s feedback, the Pick & Execute window for Edit Payment Plan is intended to be used to edit cells, nothing else. Therefore the editable fields should be switched to edit mode at the beginning already. Now, you first need to click a row to switch to edit mode.

Steps To Reproduce

n/a

Proposed Solution

Although the ideal solution was not implemented because of a restriction in the used grid SmartClient component, it is worth looking at workarounds.

See image of the original design: notice all editable fields are clearly indicated as such.

Tags

No tags attached.

Attached Files

issue20395.diff [^] (854 bytes) 2012-05-03 08:52 [Show Content] [Hide Content]

diff --git a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
--- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
+++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
@@ -214,6 +214,11 @@
     this.Super('dataArrived', arguments);
   },
 
+  setData: function (newData) {
+    this.Super('setData', arguments);
+    this.startEditing();
+  },
+
   recordClick: function (grid, record, recordNum, field, fieldNum, value, rawValue) {
     if (fieldNum === 0 && value.indexOf('unchecked.png') !== -1) {
       grid.endEditing();

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0051862) rgoris (developer) 2012-09-05 10:14	Closed because of technical constraint of Smarclient: we cannot have more than one row in edit mode at a time. The compromise would be having one editable row by default but this is not ideal: it would require an extra click to uncheck the selected row as this probably not the row the user intends to edit. With the new layer style (dimmed background and margins) that sits on top of the grid, I expect the intention of the P&E pattern to become more clear at first.

Issue History
Date Modified	Username	Field	Change
2012-05-02 18:25	rgoris	New Issue
2012-05-02 18:25	rgoris	Assigned To	=> alostale
2012-05-02 18:25	rgoris	Modules	=> Core
2012-05-02 18:27	rgoris	Type	design defect => defect
2012-05-03 08:52	iperdomo	File Added: issue20395.diff
2012-08-14 14:58	AugustoMauch	Assigned To	alostale => AugustoMauch
2012-09-05 10:14	rgoris	Closed by	=> rgoris
2012-09-05 10:14	rgoris	Note Added: 0051862
2012-09-05 10:14	rgoris	Status	new => closed