0020335: If rebuild window lose connection when rebuilding, I cannot restart Tomcat after logging back

Description

I installed a module. During rebuild, the connection dropped. Rebuild continued on the background, though. After closing the rebuild window, the Module Management window did not show the Restart Tomcat option.

This problem does not show on every execution.

Steps To Reproduce

1. Install a module.
2. While rebuilding, connection between the rebuild window and the ERP server is lost.
3. Rebuilding continues on the background. When it finishes, close the rebuild window (that is still showing as if the rebuild was in progress)
4. Logout and login. An expected message saying that the system is under maintenance is shown.
5. Go to Module Management window. There is no "Restart Tomcat" link.

Tags

No tags attached.

Attached Files

diffIssue20335.diff [^] (1,197 bytes) 2012-04-25 18:50 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/ad_process/ApplyModules.html b/src/org/openbravo/erpCommon/ad_process/ApplyModules.html
--- a/src/org/openbravo/erpCommon/ad_process/ApplyModules.html
+++ b/src/org/openbravo/erpCommon/ad_process/ApplyModules.html
@@ -404,7 +404,7 @@
           
         var state=msg.Response.state;
         var errorStatus=msg.Response.statusofstate;
-        if(msg.Response.processFinished==='Y' && !process_finished){
+        if((msg.Response.processFinished==='Y' || msg.processFinished==='Y') && !process_finished){
             process_finished=true;
             var frm = document.frmMain;
             submitXmlHttpRequest(update, frm, "UPDATESTATUS", "ApplyModulesCallServlet.html", false, null, null);
@@ -429,7 +429,7 @@
  
           error_status[getStatusIndex(state)]=errorStatus;
           var message;
-          if(msg.Response.lastmessage!==null){
+          if(msg.Response.lastmessage!==null && (typeof msg.Response.lastmessage!=='undefined')){
             message=msg.Response.lastmessage.substring(0,30);
           }else{
             message="";
@@ -852,4 +852,4 @@
   </form>
 
 
-</body></html>
\ No newline at end of file
+</body></html>

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0048452) hgbot (developer) 2012-05-08 15:18	Repository: erp/devel/pi Changeset: aaae4c594659c6ef323989fb67e7b6ad43e94d92 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue May 08 15:17:40 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/aaae4c594659c6ef323989fb67e7b6ad43e94d92 [^] Fixed issue 20335. Fixed a rare case in which the rebuild didn't process the data returned from the server correctly --- M src/org/openbravo/erpCommon/ad_process/ApplyModules.html ---

(0048518) AugustoMauch (manager) 2012-05-09 17:37	Code reviewed and verified in pi@e720f25cba62.

(0049051) hudsonbot (developer) 2012-05-25 12:10	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-04-24 16:02	plujan	New Issue
2012-04-24 16:02	plujan	Assigned To	=> marvintm
2012-04-24 16:02	plujan	Web browser	=> Mozilla Firefox
2012-04-24 16:02	plujan	Modules	=> Core
2012-04-25 18:50	marvintm	File Added: diffIssue20335.diff
2012-04-25 20:08	shuehner	Issue Monitored: shuehner
2012-04-25 20:57	szapata	Issue Monitored: szapata
2012-05-08 15:18	hgbot	Checkin
2012-05-08 15:18	hgbot	Note Added: 0048452
2012-05-08 15:18	hgbot	Status	new => resolved
2012-05-08 15:18	hgbot	Resolution	open => fixed
2012-05-08 15:18	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/aaae4c594659c6ef323989fb67e7b6ad43e94d92 [^]
2012-05-09 17:37	AugustoMauch	Note Added: 0048518
2012-05-09 17:37	AugustoMauch	Status	resolved => closed
2012-05-09 17:37	AugustoMauch	Fixed in Version	=> 3.0MP12
2012-05-25 12:10	hudsonbot	Checkin
2012-05-25 12:10	hudsonbot	Note Added: 0049051