Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020257
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] I. Performancemajoralways2012-04-12 17:412012-05-31 21:38
ReporteregoitzView Statuspublic 
Assigned ToAugustoMauch 
PriorityurgentResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchFixed in SCM revision8f2d220d1108
ProjectionnoneETAnoneTarget Version3.0MP12
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0MP9SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020257: The partner selector takes long to show data having more than 600k partners

DescriptionThe partner selector takes long to show data having more than 600k partners
Steps To Reproduce-Create 600k partners with their locations on the application
-Go to a sales order window
-Try to select a partner. Opening the selector or fileterin from field take long
and the cpu goes to 100%.
TagsPerformance
Attached Filesdiff file icon issue20257.diff [^] (11,979 bytes) 2012-04-19 10:29 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00203013.0MP12 closedAugustoMauch Bad performance on the old partner selector used on Openbravo 3 on manual forms 
related to defect 0020644 closedAugustoMauch The selector "Business partner with location and user" doesn't work correctly when used on the sales order window 
related to defect 0020648 closedAugustoMauch API change: selector fields removed 
related to defect 0020770 closednaiaramartinez when selecting a BP its address is not selecting by default if the field is not mandatory 
related to defect 0035662 closedmarkmm82 Open the business partner selector in financial account window takes too long in hgvol environment 

-  Notes
(0047733)
AugustoMauch (manager)
2012-04-19 10:29

 I've attached a patch which fixes the issue. It will not be pushed to pi until MP12, because we consider it a risky change.
(0049473)
hgbot (developer)
2012-05-30 11:57

 Repository: erp/devel/api-checks
Changeset: d76eebbc9e9dd888305550c43fcad4c2228ca505
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed May 30 11:56:33 2012 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/d76eebbc9e9dd888305550c43fcad4c2228ca505 [^]

Related to issue 20257: Prevents API-change false possitive

Some selector fields have been removed to fix the issue 20257. This change triggers an API change false possitive. The API is being updated with the new model.

---
M model/src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
---
(0049478)
hgbot (developer)
2012-05-30 12:33

 Repository: erp/devel/pi
Changeset: 8f2d220d11084e459ba568d13b57139cd4c534e8
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed May 30 12:09:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8f2d220d11084e459ba568d13b57139cd4c534e8 [^]

Fixes issue 20257: New, more efficient business partner selector

The default business partner selector has been changed:
- It does not contain location, contact and income fields
- It contains business partner category field

The previous behaviour can be found in a new Reference called Business Partner With Location and User

A callout has been modified so it supports both business partner selectors

---
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_SEARCH.xml
M src-db/database/sourcedata/OBCLKER_UIDEFINITION.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
---
(0049488)
AugustoMauch (manager)
2012-05-30 15:05

 Test plan:
- Test that the callout works fine (location and contact combos should be filled with the proper options)
- Change the Reference of a column from the current selector (Business Partner) to the new one that implements the old behaviour (Business Partner with Location and Contact). Test that works fine (the location and contact selected in the selector should be selected in their corresponding combos).
- Test that the following callouts work with both selectors:
  * SE_Order_BPartner
  * SE_Invoice_BPartner
  * SE_Project_BPartner
  * SE_Proposal_BPartner
  * SL_InOut_BPartner
(0049525)
hgbot (developer)
2012-05-31 11:31

 Repository: erp/devel/pi
Changeset: cf3e984e1fae85fd214630a73a47c0b726066ef8
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu May 31 11:28:27 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cf3e984e1fae85fd214630a73a47c0b726066ef8 [^]

Related to issue 20257: Callouts updated to select first contact

Without this change, no contact is set when selecting a business partner. Then, when sending an email, no email address is set in the "To" field

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Project_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Proposal_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SL_InOut_BPartner.java
---
(0049544)
marvintm (developer)
2012-05-31 16:00

 Latest changes reviewed.
(0049564)
hudsonbot (developer)
2012-05-31 21:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3ac036c08ee6 [^]

Maturity status: Test
(0049570)
hudsonbot (developer)
2012-05-31 21:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3ac036c08ee6 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-04-12 17:41 egoitz New Issue
2012-04-12 17:41 egoitz Assigned To => marvintm
2012-04-12 17:41 egoitz Modules => Core
2012-04-16 10:07 marvintm Assigned To marvintm => AugustoMauch
2012-04-18 13:06 egoitz Relationship added related to 0020301
2012-04-18 13:09 egoitz Priority urgent => immediate
2012-04-18 13:10 egoitz Priority immediate => urgent
2012-04-19 10:29 AugustoMauch File Added: issue20257.diff
2012-04-19 10:29 AugustoMauch Note Added: 0047733
2012-04-23 18:28 AugustoMauch Tag Attached: Performance
2012-05-02 17:04 AugustoMauch Target Version 3.0MP11 => 3.0MP12
2012-05-30 11:57 hgbot Checkin
2012-05-30 11:57 hgbot Note Added: 0049473
2012-05-30 12:33 hgbot Checkin
2012-05-30 12:33 hgbot Note Added: 0049478
2012-05-30 12:33 hgbot Status new => resolved
2012-05-30 12:33 hgbot Resolution open => fixed
2012-05-30 12:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8f2d220d11084e459ba568d13b57139cd4c534e8 [^]
2012-05-30 15:05 AugustoMauch Note Added: 0049488
2012-05-30 15:28 marvintm Relationship added related to 0020644
2012-05-30 16:16 marvintm Status resolved => closed
2012-05-30 16:16 marvintm Fixed in Version => 3.0MP12
2012-05-30 16:25 AugustoMauch Relationship added related to 0020648
2012-05-31 11:31 hgbot Checkin
2012-05-31 11:31 hgbot Note Added: 0049525
2012-05-31 16:00 marvintm Note Added: 0049544
2012-05-31 21:38 hudsonbot Checkin
2012-05-31 21:38 hudsonbot Note Added: 0049564
2012-05-31 21:38 hudsonbot Checkin
2012-05-31 21:38 hudsonbot Note Added: 0049570
2012-06-14 15:52 AugustoMauch Relationship added related to 0020770
2017-04-07 13:27 aferraz Relationship added related to 0035662

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker