Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020166
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2012-03-30 00:032012-07-11 12:11
Reportergregor1comView Statuspublic 
Assigned Tonaiaramartinez 
PrioritynormalResolutionfixedFixed in Version3.0MP14
StatusclosedFix in branchpiFixed in SCM revisiona8b18247dfc5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020166: GFR: Alert message gives inadequate instructions to user to resolve issue

DescriptionSI 105618 was reported as an alert with the following message:

"this invoice belongs to an order that has its payment plan wrong distributed through its invoices"

the wording of this message should change. However -

"please reactivate all the invoices related to the order and complete them again"

this part of the message is not correct in this case because the re-activate button does not appear and the user cannot reactivate the document.
Steps To ReproduceI believe that the issue here is that the document was voided, yet is still being taken into account by the alert.

Note that the related order has a payment in plan that was fully paid. This voided SI does not have a payment in plan associated with it.
Proposed Solution1) that the voided document not generate this alert.
2) that the message be reviewed. Need to know all the conditions in the code that could give rise to the alerted message, and I will propose a new message.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0048925)
naiaramartinez (developer)
2012-05-25 08:02

 Hi Greg,

The invoice number described in the issue (105618) does not exist in the Openbravo demo data, so we cannot research this particular invoice.
Based on the information provided, we have tried to reproduce the situation but the following scenarios are working fine, they are not creating any alert:
a) Invoice one order in a single invoice. Void the invoice.
b) Invoice one order in a single invoice. Add a partial payment against the invoice. Void the invoice.
c) Invoice one order in a two different invoices. Void one invoice.
d) Invoice one order in a two different invoices. Add a partial payment against one invoice. Void the invoice previously paid.

This alert was created to detect invoices affected by the issue 0017760 (one year old).
Probably the invoices caught by the alert in your instance are quite old invoices.

If you want to analyze deeper the problem with the invoice 105618 you should contact with Openbravo support team and they will kindly find out what is wrong with this particular invoice.

From our side, we will improve the message displayed in the alert and voided invoices will be discarded.
(0050479)
hgbot (developer)
2012-07-11 12:05

 Repository: erp/devel/pi
Changeset: a8b18247dfc503b7380b21413b66798f5e54f8c1
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Thu May 24 16:44:45 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a8b18247dfc503b7380b21413b66798f5e54f8c1 [^]

Fixed bug 20166: do not take into account voided invoices in insertAlertRule

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/buildvalidation/WrongPaymentScheduleDetailsCheckData.class
M modules/org.openbravo.advpaymentmngt/src-util/buildvalidation/src/org/openbravo/advpaymentmngt/buildvalidation/WrongPaymentScheduleDetailsCheck_data.xsql
M modules/org.openbravo.advpaymentmngt/src-util/buildvalidation/src/src/org/openbravo/advpaymentmngt/buildvalidation/WrongPaymentScheduleDetailsCheckData.java
---
(0050480)
mirurita (developer)
2012-07-11 12:11

 code review + testing OK

Testing Plan
1) Create a sales order (SO1)
2) Create a sales invoice (SI1) for previous order
3) Create inconsistent data through sql updates:
-- the parameter is the psd of the order and invoice
update fin_payment_scheduledetail set fin_payment_schedule_order = null where fin_payment_scheduledetail_id = ?;
-- first parameter is the SO1 payment schedule id
-- second parameter is any psd of the system
update fin_payment_scheduledetail set fin_payment_schedule_order = ? where fin_payment_scheduledetail_id = ?;
4) void the invoice
5) run update.database
6) the alert is not created

- Issue History
Date Modified Username Field Change
2012-03-30 00:03 gregor1com New Issue
2012-03-30 00:03 gregor1com Assigned To => vmromanos
2012-03-30 00:03 gregor1com Modules => Core
2012-05-10 12:12 gorka_gil Assigned To vmromanos => mirurita
2012-05-25 08:02 naiaramartinez Note Added: 0048925
2012-06-11 11:07 naiaramartinez Assigned To mirurita => naiaramartinez
2012-06-11 11:08 naiaramartinez Status new => scheduled
2012-06-11 11:08 naiaramartinez fix_in_branch => pi
2012-07-11 12:05 hgbot Checkin
2012-07-11 12:05 hgbot Note Added: 0050479
2012-07-11 12:05 hgbot Status scheduled => resolved
2012-07-11 12:05 hgbot Resolution open => fixed
2012-07-11 12:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a8b18247dfc503b7380b21413b66798f5e54f8c1 [^]
2012-07-11 12:11 mirurita Note Added: 0050480
2012-07-11 12:11 mirurita Status resolved => closed
2012-07-11 12:11 mirurita Fixed in Version => 3.0MP14

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker