Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020093
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2012-03-22 18:252012-04-17 05:31
ReporterdalsasuaView Statuspublic 
Assigned Tonaiaramartinez 
PriorityurgentResolutionfixedFixed in Version3.0MP11
StatusclosedFix in branchFixed in SCM revisione8c1e6c5054d
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabaseOracleJava version1.6.0_21
OS VersionUbuntu 10.10Database version11.2.0 SEAnt version1.8.0
Product Version3.0MP8.1SCM revision 
Review Assigned To
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020093: Message not clear when processing a payment for financial account without the chosen payment method

DescriptionMessage not clear when processing a payment for financial account without the chosen payment method
Steps To Reproduce1. Go to Financial Account Banco de España - Cuenta 1
2. Go to Payment Method tab and create a new one: "Al Contado".
3. Go to Payment In window, create a new one, and choose F&B España - Región Norte, 334.32 amount, Al contado Payment Method and EUR-Banco de España-Cuenta 1 For Deposit To field. Save.
4. Go back to Payment Method tab of Financial Account Banco de España - Cuenta 1, and delete the "Al Contado" payment method created in step 2.
5. Go to Payment In created in step 3, and click on Add Details.
6. Set Transaction Type to Orders or Invoices and activate Show payments in for alternative payment methods.
7. Choose the first payment for 334.32, and click on Process and Ok.
8. Realize that an error "Index: 0, Size: 0" is shown. This message has nothing to do with the actual error.
Proposed SolutionFin_PaymentPorcess servlet, in line 221 says:
if (dao.isAutomatedExecutionPayment(payment.getAccount(), payment.getPaymentMethod(), payment.isReceipt())) { (...)
this call to isAutomatedExecutionPayment function executes this code:
FinAccPaymentMethod finAccPaymentMethod = getFinancialAccountPaymentMethod(account, paymentMethod);
and this call to getFinancialAccountPaymentMethod executes a query, assuming that the result set will be of 1 row, at least, as the return statement says:
return obc.list().get(0);

Several possibilities can be followed in order to fix this:
1.- Before calling to isAutomatedExecutionPayment, check whether there exists that payment method for that financial account or not.
2.- Catch the exception in Fin_PaymentProcess and show a correct message.
3.- Throw a concrete exception in isAutomatedExecutionPayment or getFinancialAccountPaymentMethod
TagsVMA-Reviewed
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0047481)
naiaramartinez (developer)
2012-04-11 12:41

 Test Plan:
1. Go to Financial Account Banco de España - Cuenta 1
2. Go to Payment Method tab and create a new one: "Al Contado".
3. Go to Payment In window, create a new one, and choose F&B España - Región Norte, 334.32 amount, Al contado Payment Method and EUR-Banco de España-Cuenta 1 For Deposit To field. Save.
4. Go back to Payment Method tab of Financial Account Banco de España - Cuenta 1, and delete the "Al Contado" payment method created in step 2.
5. Go to Payment In created in step 3, and click on Add Details.
6. Set Transaction Type to Orders or Invoices and activate Show payments in for alternative payment methods.
7. Choose the first payment for 334.32, and click on Process and Ok.
You can see that the error is 'Selected payment method doesn't exist.'
(0047548)
hgbot (developer)
2012-04-13 09:36

 Repository: erp/devel/pi
Changeset: e8c1e6c5054d59054ea198a880493dda2a30dc6f
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Wed Apr 11 12:29:37 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e8c1e6c5054d59054ea198a880493dda2a30dc6f [^]

fixed issue 20093 APRM Set a correct error message and catch the exception

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0047549)
vmromanos (manager)
2012-04-13 09:36

 code review + testing OK
(0047647)
hudsonbot (developer)
2012-04-17 05:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-03-22 18:25 dalsasua New Issue
2012-03-22 18:25 dalsasua Assigned To => vmromanos
2012-03-22 18:25 dalsasua Modules => Core
2012-03-22 18:26 dalsasua Issue Monitored: gregor1com
2012-03-23 12:08 dalsasua Assigned To vmromanos => dalsasua
2012-03-23 12:08 dalsasua Status new => scheduled
2012-03-23 12:08 dalsasua fix_in_branch => pi
2012-03-23 12:09 dalsasua Modules Core => Advanced Payables and Receivables Mngmt
2012-03-23 12:09 dalsasua fix_in_branch pi =>
2012-03-26 14:22 dalsasua Priority immediate => urgent
2012-03-26 14:22 dalsasua Severity critical => major
2012-03-30 13:44 dalsasua Assigned To dalsasua => vmromanos
2012-04-11 11:32 vmromanos Tag Attached: VMA-Reviewed
2012-04-11 12:38 naiaramartinez Assigned To vmromanos => naiaramartinez
2012-04-11 12:41 naiaramartinez Note Added: 0047481
2012-04-13 09:36 hgbot Checkin
2012-04-13 09:36 hgbot Note Added: 0047548
2012-04-13 09:36 hgbot Status scheduled => resolved
2012-04-13 09:36 hgbot Resolution open => fixed
2012-04-13 09:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8c1e6c5054d59054ea198a880493dda2a30dc6f [^]
2012-04-13 09:36 vmromanos Note Added: 0047549
2012-04-13 09:36 vmromanos Status resolved => closed
2012-04-13 09:36 vmromanos Fixed in Version => 3.0MP11
2012-04-17 05:31 hudsonbot Checkin
2012-04-17 05:31 hudsonbot Note Added: 0047647

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker