Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0020071 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2012-03-21 12:22 | 2012-04-02 15:29 | |||
| Reporter | dmitry_mezentsev | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0MP9 | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 0a30d7aaaed2 | |||
| Projection | none | ETA | none | Target Version | 3.0MP9 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0020071: Change in the date field is not saved when editing it using keyboard and then navigating from it directly to the child tab | |||||||
| Description | Change in the date field is not saved when editing it using keyboard and then navigating from it directly to the child tab using mouse But It works if tabbing out of this field or saving using toolbar save button. | |||||||
| Steps To Reproduce | live.builds.pi, standard user. 1. New Purchase Invoice. 2. Select any Business Partner. 3. Then change Invoice Date (or Accounting Date) and without tabbing out from this field click with a mouse on a Lines part of the screen. 4. Header is saved and displays correct date in the field. 5. Now go to Header and refresh it with a toolbar button. Mention that after refresh date field is changed. | |||||||
| Tags | Regression | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0046629) hgbot (developer) 2012-03-21 18:23 |
Repository: erp/devel/pi Changeset: 3520624041bc91cc1dafe8651d437fa17ba21720 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Mar 21 18:21:23 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/3520624041bc91cc1dafe8651d437fa17ba21720 [^] Fixes issue 20071: Now autosave will work when focus is in a date field The ob-formitem-date.js now overwrites the blur method in order to make sure that its value is updated when the autosave is done. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js --- |
|
(0046632) AugustoMauch (manager) 2012-03-21 18:39 |
If the user moves to another tab while the focus is on a date field that has been just modified, the autosave was being done before the updateValue of the date field was executed. The blur method of the focused field is called inside the autosave method. ob-formitem-date now overwrites the blur function, calling updateValue so that the value of the date is updated when the autosave is done. This is only done is the form is visible, it is not needed in the grid. |
|
(0046633) marvintm (developer) 2012-03-21 18:48 |
The problem is fixed in form view, but in grid view the same problem happens. It can be easily reproduced by following the same steps, but in grid view instead of form view. |
|
(0046661) hgbot (developer) 2012-03-22 18:18 |
Repository: erp/devel/pi Changeset: 092c6bff0a7435105c4441c34c36a566c2506a52 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Mar 22 18:18:00 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/092c6bff0a7435105c4441c34c36a566c2506a52 [^] Fixes issue 20071: Autosave with date field focus works both in grid and form view The previous fix only achieved to fix the issue when the change of tab was done while the date field was focus in the form view. Now it also works if it is focused in grid view. This solution works for date fields that have callouts and for date fields that do not. Additional changes have been made to allow to save a date multiple times in a row. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
|
(0046689) hgbot (developer) 2012-03-23 14:09 |
Repository: erp/devel/pi Changeset: db4c8e8f034548ba09b2ec101d8227d2d83fe2b3 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Mar 23 14:07:26 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/db4c8e8f034548ba09b2ec101d8227d2d83fe2b3 [^] Related to issue 20071: Added unit test compatibility. The changes made to fix the issue 20071 worked when the change of the date fields were done through user interaction. The unit tests call directly the setValue method of the dateTextField property of the date, scenario which had not been considered, and the date field was not being flagged as changed. This has been fixed by overwriting the setValue method of the dateTextField of the date field. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js --- |
|
(0047019) hgbot (developer) 2012-04-01 20:34 |
Repository: erp/devel/pi Changeset: 55e501dad3b7d63773f6054bffc08b08999b527d Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Mar 21 18:21:23 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/55e501dad3b7d63773f6054bffc08b08999b527d [^] Fixes issue 20071: Now autosave will work when focus is in a date field The ob-formitem-date.js now overwrites the blur method in order to make sure that its value is updated when the autosave is done. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js --- |
|
(0047020) hgbot (developer) 2012-04-01 20:34 |
Repository: erp/devel/pi Changeset: 0a30d7aaaed2e14a9904808e7135b93665f23737 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Mar 22 18:18:00 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/0a30d7aaaed2e14a9904808e7135b93665f23737 [^] Fixes issue 20071: Autosave with date field focus works both in grid and form view The previous fix only achieved to fix the issue when the change of tab was done while the date field was focus in the form view. Now it also works if it is focused in grid view. This solution works for date fields that have callouts and for date fields that do not. Additional changes have been made to allow to save a date multiple times in a row. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
|
(0047021) hgbot (developer) 2012-04-01 20:34 |
Repository: erp/devel/pi Changeset: e022f7514b6b059c4d56890b0edec92bb39bf359 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Mar 23 14:07:26 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/e022f7514b6b059c4d56890b0edec92bb39bf359 [^] Related to issue 20071: Added unit test compatibility. The changes made to fix the issue 20071 worked when the change of the date fields were done through user interaction. The unit tests call directly the setValue method of the dateTextField property of the date, scenario which had not been considered, and the date field was not being flagged as changed. This has been fixed by overwriting the setValue method of the dateTextField of the date field. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js --- |
|
(0047197) hudsonbot (developer) 2012-04-02 06:11 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
(0047205) hudsonbot (developer) 2012-04-02 06:11 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
(0047214) hudsonbot (developer) 2012-04-02 06:11 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
(0047313) AugustoMauch (manager) 2012-04-02 15:27 |
Reopened to add relationship |
|
(0047314) AugustoMauch (manager) 2012-04-02 15:29 |
This regression was caused by the changeset that fixed issue 18513. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-03-21 12:22 | dmitry_mezentsev | New Issue | |
| 2012-03-21 12:22 | dmitry_mezentsev | Assigned To | => AugustoMauch |
| 2012-03-21 12:22 | dmitry_mezentsev | Modules | => Core |
| 2012-03-21 18:23 | hgbot | Checkin | |
| 2012-03-21 18:23 | hgbot | Note Added: 0046629 | |
| 2012-03-21 18:23 | hgbot | Status | new => resolved |
| 2012-03-21 18:23 | hgbot | Resolution | open => fixed |
| 2012-03-21 18:23 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3520624041bc91cc1dafe8651d437fa17ba21720 [^] |
| 2012-03-21 18:39 | AugustoMauch | Note Added: 0046632 | |
| 2012-03-21 18:48 | marvintm | Note Added: 0046633 | |
| 2012-03-21 18:48 | marvintm | Status | resolved => new |
| 2012-03-21 18:48 | marvintm | Resolution | fixed => open |
| 2012-03-22 18:18 | hgbot | Checkin | |
| 2012-03-22 18:18 | hgbot | Note Added: 0046661 | |
| 2012-03-22 18:18 | hgbot | Status | new => resolved |
| 2012-03-22 18:18 | hgbot | Resolution | open => fixed |
| 2012-03-22 18:18 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/3520624041bc91cc1dafe8651d437fa17ba21720 [^] => http://code.openbravo.com/erp/devel/pi/rev/092c6bff0a7435105c4441c34c36a566c2506a52 [^] |
| 2012-03-22 19:07 | marvintm | Status | resolved => closed |
| 2012-03-23 14:09 | hgbot | Checkin | |
| 2012-03-23 14:09 | hgbot | Note Added: 0046689 | |
| 2012-04-01 20:34 | hgbot | Checkin | |
| 2012-04-01 20:34 | hgbot | Note Added: 0047019 | |
| 2012-04-01 20:34 | hgbot | Status | closed => resolved |
| 2012-04-01 20:34 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/092c6bff0a7435105c4441c34c36a566c2506a52 [^] => http://code.openbravo.com/erp/devel/pi/rev/55e501dad3b7d63773f6054bffc08b08999b527d [^] |
| 2012-04-01 20:34 | hgbot | Checkin | |
| 2012-04-01 20:34 | hgbot | Note Added: 0047020 | |
| 2012-04-01 20:34 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/55e501dad3b7d63773f6054bffc08b08999b527d [^] => http://code.openbravo.com/erp/devel/pi/rev/0a30d7aaaed2e14a9904808e7135b93665f23737 [^] |
| 2012-04-01 20:34 | hgbot | Checkin | |
| 2012-04-01 20:34 | hgbot | Note Added: 0047021 | |
| 2012-04-02 06:11 | hudsonbot | Checkin | |
| 2012-04-02 06:11 | hudsonbot | Note Added: 0047197 | |
| 2012-04-02 06:11 | hudsonbot | Checkin | |
| 2012-04-02 06:11 | hudsonbot | Note Added: 0047205 | |
| 2012-04-02 06:11 | hudsonbot | Checkin | |
| 2012-04-02 06:11 | hudsonbot | Note Added: 0047214 | |
| 2012-04-02 10:23 | AugustoMauch | Status | resolved => closed |
| 2012-04-02 10:23 | AugustoMauch | Fixed in Version | => 3.0MP9 |
| 2012-04-02 13:40 | dmitry_mezentsev | Tag Attached: Regression | |
| 2012-04-02 15:27 | AugustoMauch | Note Added: 0047313 | |
| 2012-04-02 15:27 | AugustoMauch | Status | closed => new |
| 2012-04-02 15:27 | AugustoMauch | Resolution | fixed => open |
| 2012-04-02 15:27 | AugustoMauch | Fixed in Version | 3.0MP9 => |
| 2012-04-02 15:28 | AugustoMauch | Relationship added | related to 0018513 |
| 2012-04-02 15:28 | AugustoMauch | Status | new => scheduled |
| 2012-04-02 15:28 | AugustoMauch | fix_in_branch | => pi |
| 2012-04-02 15:28 | AugustoMauch | Status | scheduled => resolved |
| 2012-04-02 15:28 | AugustoMauch | Fixed in Version | => 3.0MP9 |
| 2012-04-02 15:28 | AugustoMauch | Resolution | open => fixed |
| 2012-04-02 15:28 | AugustoMauch | Status | resolved => closed |
| 2012-04-02 15:29 | AugustoMauch | Note Added: 0047314 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |