Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020029
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] B. User interfaceminorhave not tried2012-03-15 09:482012-04-02 06:12
ReporterplujanView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version3.0MP10
StatusclosedFix in branchFixed in SCM revisionc459bea5041f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Review Assigned To
Web browserInternet Explorer
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020029: It is possible to expand bottom section even if there are no tabs

DescriptionOn windows with three or more levels it is possible to expand bottom section to see those tabs' contents. However in a two level windows, it has no sense at all to expand an empty section.
Steps To Reproduce1. Go to Business Partner window
2. Go to Customer tab
3. Check there are no other tabs below Customer
4. Click the grey bar on the bottom. The section is expanded. See screenshot.
TagsNo tags attached.
Attached Filespng file icon Empty_Section_Click.png [^] (49,910 bytes) 2012-03-15 09:48

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0046476)
AugustoMauch (manager)
2012-03-15 18:06

 In order to be able to reproduce the issue, the "Show accounting tabs" option has to be unchecked:
- Open Session Preferences
- Uncheck the "Show accounting tabs" checkbox.
- Save the preferences
(0046535)
hgbot (developer)
2012-03-20 11:32

 Repository: erp/devel/pi
Changeset: c459bea5041f670caa664cb28223ac5aa62a2032
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 20 11:31:24 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c459bea5041f670caa664cb28223ac5aa62a2032 [^]

Fixes issue 20029: Tab bar is not created if it is not needed.

The hasChildTabs attribute initialized in ob-view-tab.js is used to decide whether a new tabset has to be created, and whether a view has to include a maximize/minimize button.
Prior to this fix, this attribute was set to true if the tab had any child, regardless of the type of the tab (accounting, translation or other (always visible). When a tab had only one accounting tab and the ShowAcct session preferences was false, the tabset was created even though it was not going to contain any visible tab.
Now, if a tab has only accounting or translation tabs, the value of hasChildTabs will depend on the value of the ShowAcct and ShowTrl session properties.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
---
(0046536)
AugustoMauch (manager)
2012-03-20 11:43

 Test plan:
1 - Login as F&B admin
2 - Open session preferences and uncheck the Show Accounting Tabs checkbox.
3 - Open Business Partner window
4 - There should not be a tab bar under the Customer tab.

5 - Login as system admin
6 - Open session preferences and uncheck the Show Translation Tabs checkbox.
7 - Open Windows, Tabs and Fields window
8 - There should not be a tab bar under the Field tab.
(0046537)
AugustoMauch (manager)
2012-03-20 11:46

 Only the initialization of hasChildTabs has been modified. This attribute takes part in the creation of the windows. On one hand, it decides whether a tab bar should be created for the children of a tab. On the other hand, it is also used to decide whether a tab should include a maximize-minimize button.

Both parts work fine after the fix, so I think it is not risky.
(0046728)
hgbot (developer)
2012-03-26 12:23

 Repository: erp/devel/pi
Changeset: f3875cc346c0924426a963a85e31d9be0d1f387e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 26 12:22:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f3875cc346c0924426a963a85e31d9be0d1f387e [^]

Related to issue 20029: Moved fix from freemarker to java file

The logic of the fix has been moved from the .ftl file to the java file, for the sake of clarity and ease of debugging.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
---
(0046810)
alostale (manager)
2012-03-28 11:55

 Code review:
  -The standard way to populate ftl is through java class, not using ftl functions. Changed by f3875cc346c0924426a963a85e31d9be0d1f387e
  -Try to keep API as small as possible: don't add new public methods if they are used only internally in the class (hasAlwaysVisibleChildTab, hasAccountingChildTab and hasTranslationChildTab)
(0046836)
hgbot (developer)
2012-03-28 15:10

 Repository: erp/devel/pi
Changeset: 5438f39cd04764a212126084f823ddd303bce40d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Mar 28 15:09:37 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5438f39cd04764a212126084f823ddd303bce40d [^]

Related to issue 20029: Changed signature of some functions from public to private

Of the four functions created in the previous changeset (f3875cc346c0924426a963a85e31d9be0d1f387e), only one of them should be public. The other three functions have been changed to private, because they are only called from inside the class.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
---
(0046845)
alostale (manager)
2012-03-28 17:21

 Code reviewed and verified on pi@5438f39cd047
(0047166)
hudsonbot (developer)
2012-04-02 06:10

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047232)
hudsonbot (developer)
2012-04-02 06:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047260)
hudsonbot (developer)
2012-04-02 06:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-03-15 09:48 plujan New Issue
2012-03-15 09:48 plujan Assigned To => AugustoMauch
2012-03-15 09:48 plujan File Added: Empty_Section_Click.png
2012-03-15 09:48 plujan Web browser => Internet Explorer
2012-03-15 09:48 plujan Modules => Core
2012-03-15 18:06 AugustoMauch Note Added: 0046476
2012-03-20 11:32 hgbot Checkin
2012-03-20 11:32 hgbot Note Added: 0046535
2012-03-20 11:32 hgbot Status new => resolved
2012-03-20 11:32 hgbot Resolution open => fixed
2012-03-20 11:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c459bea5041f670caa664cb28223ac5aa62a2032 [^]
2012-03-20 11:43 AugustoMauch Note Added: 0046536
2012-03-20 11:46 AugustoMauch Note Added: 0046537
2012-03-26 12:23 hgbot Checkin
2012-03-26 12:23 hgbot Note Added: 0046728
2012-03-28 11:55 alostale Note Added: 0046810
2012-03-28 15:10 hgbot Checkin
2012-03-28 15:10 hgbot Note Added: 0046836
2012-03-28 17:21 alostale Note Added: 0046845
2012-03-28 17:21 alostale Status resolved => closed
2012-03-28 17:21 alostale Fixed in Version => 3.0MP10
2012-04-02 06:10 hudsonbot Checkin
2012-04-02 06:10 hudsonbot Note Added: 0047166
2012-04-02 06:12 hudsonbot Checkin
2012-04-02 06:12 hudsonbot Note Added: 0047232
2012-04-02 06:12 hudsonbot Checkin
2012-04-02 06:12 hudsonbot Note Added: 0047260

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker