Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0020018 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2012-03-14 10:48 | 2012-04-02 06:10 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0MP9 | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 757c16d46fa0 | |||
| Projection | none | ETA | none | Target Version | 3.0MP9 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | Google Chrome, Mozilla Firefox | |||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0020018: Error in the initialization of the foreign key selectors when creating a new row in grid view | |||||||
| Description | When a new record is created in grid view, the foreign key selectors are not properly initialized. There is not any option selected by default, and if the user opens the selector and selects one, that option is actually not selected. The fix of issue 19984 changed the way the ForeignKeyUIDefinition class initializes the 'length' grid field property in the getGridFieldProperties method. Now it is initialized with the value of ad_field.displaylength, and it used to be initialized with ad_column.length. The problem is that the ad_column.length is in some cases smaller than the UUIDs of the selectors, so they are being truncated, and that causes the error in the initialization of the foreign key selector field. | |||||||
| Steps To Reproduce | - Open sales order - Create a new record in grid view | |||||||
| Proposed Solution | Change the way the ForeignKeyUIDefinition class initializes the 'length' grid field property in the getGridFieldProperties class, so it uses the value of ad_column.length again. | |||||||
| Tags | Regression QA | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0046378) AugustoMauch (manager) 2012-03-14 11:19 |
The fix to this issue was linked mistakenly to the issue that caused it (https://issues.openbravo.com/view.php?id=19984 [^]) |
|
(0046379) AugustoMauch (manager) 2012-03-14 11:36 |
Repository: erp/devel/pi Changeset: 757c16d46fa08e9335db75a8cb3aa7f6bdabdc82 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Tue Mar 13 23:42:12 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/757c16d46fa08e9335db75a8cb3aa7f6bdabdc82 [^] Related to issue 19984: ForeignKeyUIDefinition uses ad_field.displaylength for length After the fix of issue 19984 (changeset 15784), all the UIDefinition classes that defined the grid length property, took that value from ad_column.length. It works on most cases, but it does not in the ForeignKeyUIDefinition class. If it is used in the ForeignKeyUIDefinition class, when a new row is entered in the grid, the foreign key fields are not initialized properly. Now the ForeignKeyUIDefinition class initializes the length grid field with the value of ad_field.displaylength. Changing this does not have any repercusion on determining the maximum number of characters allowed for the field. This class represents foreign keys, so its value can not be entered manually. --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java --- |
|
(0046380) AugustoMauch (manager) 2012-03-14 11:37 |
Reopened to enter properly the 'Fixed in SCM revision' field |
|
(0046383) hgbot (developer) 2012-03-14 12:09 |
Repository: erp/devel/pi Changeset: 74b1d0de99e26044b27bd516c22b05488ddacd37 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Mar 14 12:07:58 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/74b1d0de99e26044b27bd516c22b05488ddacd37 [^] Related to issue 20018: Removed length property from ForeignKeyUIDefinition Instead of initializing the length property of getGridFieldProperties with the ad_column.length value, the length property has been removed. This will prevent errors if in the future someone enters an ad_column.length value smaller than the size of the UUIDs. --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java --- |
|
(0046388) dbaz (developer) 2012-03-14 12:59 |
Reviewed @ changeset 15798 - 74b1d0de99e2 |
|
(0047008) hgbot (developer) 2012-04-01 20:33 |
Repository: erp/devel/pi Changeset: 543c6a45715a8d5520c8d1f7396426659c4c3874 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Mar 14 12:07:58 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/543c6a45715a8d5520c8d1f7396426659c4c3874 [^] Related to issue 20018: Removed length property from ForeignKeyUIDefinition Instead of initializing the length property of getGridFieldProperties with the ad_column.length value, the length property has been removed. This will prevent errors if in the future someone enters an ad_column.length value smaller than the size of the UUIDs. --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java --- |
|
(0047128) hudsonbot (developer) 2012-04-02 06:10 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-03-14 10:48 | AugustoMauch | New Issue | |
| 2012-03-14 10:48 | AugustoMauch | Assigned To | => AugustoMauch |
| 2012-03-14 10:48 | AugustoMauch | Web browser | => Google Chrome, Mozilla Firefox |
| 2012-03-14 10:48 | AugustoMauch | Modules | => Core |
| 2012-03-14 10:50 | AugustoMauch | Tag Attached: Regression QA | |
| 2012-03-14 11:16 | AugustoMauch | Relationship added | related to 0019984 |
| 2012-03-14 11:16 | AugustoMauch | Status | new => scheduled |
| 2012-03-14 11:16 | AugustoMauch | fix_in_branch | => pi |
| 2012-03-14 11:19 | AugustoMauch | Note Added: 0046378 | |
| 2012-03-14 11:19 | AugustoMauch | Status | scheduled => resolved |
| 2012-03-14 11:19 | AugustoMauch | Fixed in Version | => 3.0MP9 |
| 2012-03-14 11:19 | AugustoMauch | Fixed in SCM revision | => 757c16d46fa08e9335db75a8cb3aa7f6bdabdc82 |
| 2012-03-14 11:19 | AugustoMauch | Resolution | open => fixed |
| 2012-03-14 11:36 | AugustoMauch | Note Added: 0046379 | |
| 2012-03-14 11:37 | AugustoMauch | Note Added: 0046380 | |
| 2012-03-14 11:37 | AugustoMauch | Status | resolved => new |
| 2012-03-14 11:37 | AugustoMauch | Resolution | fixed => open |
| 2012-03-14 11:37 | AugustoMauch | Fixed in Version | 3.0MP9 => |
| 2012-03-14 11:37 | AugustoMauch | Status | new => scheduled |
| 2012-03-14 11:37 | AugustoMauch | Status | scheduled => resolved |
| 2012-03-14 11:37 | AugustoMauch | Fixed in Version | => 3.0MP9 |
| 2012-03-14 11:37 | AugustoMauch | Fixed in SCM revision | 757c16d46fa08e9335db75a8cb3aa7f6bdabdc82 => http://code.openbravo.com/erp/devel/pi/rev/757c16d46fa08e9335db75a8cb3aa7f6bdabdc82 [^] |
| 2012-03-14 11:37 | AugustoMauch | Resolution | open => fixed |
| 2012-03-14 12:09 | hgbot | Checkin | |
| 2012-03-14 12:09 | hgbot | Note Added: 0046383 | |
| 2012-03-14 12:59 | dbaz | Note Added: 0046388 | |
| 2012-03-14 12:59 | dbaz | Status | resolved => closed |
| 2012-04-01 20:33 | hgbot | Checkin | |
| 2012-04-01 20:33 | hgbot | Note Added: 0047008 | |
| 2012-04-02 06:10 | hudsonbot | Checkin | |
| 2012-04-02 06:10 | hudsonbot | Note Added: 0047128 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |