Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019878
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2012-02-26 22:212012-08-22 10:54
ReportermtaalView Statuspublic 
Assigned Todbaz 
PrioritynormalResolutionfixedFixed in Version3.0MP15
StatusclosedFix in branchFixed in SCM revision4441eebd812c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019878: Modify payment in plan button not working if modules in development

DescriptionWhen the core, kernel and application modules are in development then the 'modify payment in plan' button in sales invoices does nothing. This because the classname of the pne view does not contain the dev suffix (the milliseconds), see the implementation of openProcess in ob-standard-window.js and the way the classname of the pne window gets created in the java class OBViewTab.getProcessViews()
Steps To Reproduce- set the core, kernel and client.application module in development
- restart the app
- goto sales invoice and create a sales invoice with lines and complete
- select the created invoice
- click the modify payment in plan button, nothing happens
TagsNo tags attached.
Attached Filesdiff file icon ob-standard-window.js.diff [^] (1,053 bytes) 2012-02-27 13:34 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0020403 closedalostale Button Edit Payment Plan does not work 

-  Notes
(0045474)
iperdomo (reporter)
2012-02-27 13:38

 Attached a proposed fix. All the modules in the window must be in-development.

In this case, Core is in development the owner of the window, but the "Modify Payment Plan" button belongs to another module: ARPM (Advanced Payables and Receivables).

The owner of the window, and the process must be in-sync. In-development or not-in-development.

The patch proposes a logWarn() but is more visible if logError() is used.
(0051310)
dbaz (developer)
2012-08-14 22:07
edited on: 2012-08-14 22:08

 The issue has a duplicate (already fixed) issue:
https://issues.openbravo.com/view.php?id=20403 [^]

but I am going to improve the fix by setting the message in the database and showing an error dialog (not all users know the 'console' existence and not all browsers support it)
(0051311)
hgbot (developer)
2012-08-14 22:13

 Repository: erp/devel/pi
Changeset: 4441eebd812cf7ad9cbffcf94962637c3dad61b9
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Aug 14 22:12:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4441eebd812cf7ad9cbffcf94962637c3dad61b9 [^]

Fixed issue 19878 - Fixed issue 20403:
* Added message to database
* Changed window.console.error by an isc.warn

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0051450)
AugustoMauch (manager)
2012-08-22 10:54

 Code reviewed and verified in pi@fb014b417c71

- Issue History
Date Modified Username Field Change
2012-02-26 22:21 mtaal New Issue
2012-02-26 22:21 mtaal Assigned To => iperdomo
2012-02-26 22:21 mtaal Modules => Core
2012-02-27 13:34 iperdomo File Added: ob-standard-window.js.diff
2012-02-27 13:38 iperdomo Status new => scheduled
2012-02-27 13:38 iperdomo Note Added: 0045474
2012-02-27 13:38 iperdomo Assigned To iperdomo => dbaz
2012-02-27 13:38 iperdomo fix_in_branch => pi
2012-08-14 22:06 dbaz Relationship added has duplicate 0020403
2012-08-14 22:07 dbaz Note Added: 0051310
2012-08-14 22:08 dbaz Note Edited: 0051310 View Revisions
2012-08-14 22:11 dbaz Closed by => AugustoMauch
2012-08-14 22:11 dbaz Web browser => Google Chrome
2012-08-14 22:11 dbaz fix_in_branch pi =>
2012-08-14 22:13 hgbot Checkin
2012-08-14 22:13 hgbot Note Added: 0051311
2012-08-14 22:13 hgbot Status scheduled => resolved
2012-08-14 22:13 hgbot Resolution open => fixed
2012-08-14 22:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4441eebd812cf7ad9cbffcf94962637c3dad61b9 [^]
2012-08-22 10:54 AugustoMauch Note Added: 0051450
2012-08-22 10:54 AugustoMauch Status resolved => closed
2012-08-22 10:54 AugustoMauch Fixed in Version => 3.0MP15

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker