Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019878Openbravo ERPA. Platformpublic2012-02-26 22:212012-08-22 10:54
Reportermtaal 
Assigned Todbaz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019878: Modify payment in plan button not working if modules in development
DescriptionWhen the core, kernel and application modules are in development then the 'modify payment in plan' button in sales invoices does nothing. This because the classname of the pne view does not contain the dev suffix (the milliseconds), see the implementation of openProcess in ob-standard-window.js and the way the classname of the pne window gets created in the java class OBViewTab.getProcessViews()
Steps To Reproduce- set the core, kernel and client.application module in development
- restart the app
- goto sales invoice and create a sales invoice with lines and complete
- select the created invoice
- click the modify payment in plan button, nothing happens
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0020403 closed alostale Button Edit Payment Plan does not work 
Attached Filesdiff ob-standard-window.js.diff (1,053) 2012-02-27 13:34
https://issues.openbravo.com/file_download.php?file_id=5028&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-02-26 22:21mtaalNew Issue
2012-02-26 22:21mtaalAssigned To => iperdomo
2012-02-26 22:21mtaalModules => Core
2012-02-26 22:21mtaalOBNetwork customer => No
2012-02-27 13:34iperdomoFile Added: ob-standard-window.js.diff
2012-02-27 13:38iperdomoStatusnew => scheduled
2012-02-27 13:38iperdomoNote Added: 0045474
2012-02-27 13:38iperdomoAssigned Toiperdomo => dbaz
2012-02-27 13:38iperdomofix_in_branch => pi
2012-08-14 22:06dbazRelationship addedhas duplicate 0020403
2012-08-14 22:07dbazNote Added: 0051310
2012-08-14 22:08dbazNote Edited: 0051310bug_revision_view_page.php?bugnote_id=0051310#r3721
2012-08-14 22:11dbazClosed by => AugustoMauch
2012-08-14 22:11dbazWeb browser => Google Chrome
2012-08-14 22:11dbazfix_in_branchpi =>
2012-08-14 22:13hgbotCheckin
2012-08-14 22:13hgbotNote Added: 0051311
2012-08-14 22:13hgbotStatusscheduled => resolved
2012-08-14 22:13hgbotResolutionopen => fixed
2012-08-14 22:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4441eebd812cf7ad9cbffcf94962637c3dad61b9 [^]
2012-08-22 10:54AugustoMauchNote Added: 0051450
2012-08-22 10:54AugustoMauchStatusresolved => closed
2012-08-22 10:54AugustoMauchFixed in Version => 3.0MP15

Notes
(0045474)
iperdomo   
2012-02-27 13:38   
Attached a proposed fix. All the modules in the window must be in-development.

In this case, Core is in development the owner of the window, but the "Modify Payment Plan" button belongs to another module: ARPM (Advanced Payables and Receivables).

The owner of the window, and the process must be in-sync. In-development or not-in-development.

The patch proposes a logWarn() but is more visible if logError() is used.
(0051310)
dbaz   
2012-08-14 22:07   
(edited on: 2012-08-14 22:08)
The issue has a duplicate (already fixed) issue:
https://issues.openbravo.com/view.php?id=20403 [^]

but I am going to improve the fix by setting the message in the database and showing an error dialog (not all users know the 'console' existence and not all browsers support it)
(0051311)
hgbot   
2012-08-14 22:13   
Repository: erp/devel/pi
Changeset: 4441eebd812cf7ad9cbffcf94962637c3dad61b9
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Aug 14 22:12:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4441eebd812cf7ad9cbffcf94962637c3dad61b9 [^]

Fixed issue 19878 - Fixed issue 20403:
* Added message to database
* Changed window.console.error by an isc.warn

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0051450)
AugustoMauch   
2012-08-22 10:54   
Code reviewed and verified in pi@fb014b417c71