Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019564 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | critical | always | 2012-01-25 21:09 | 2012-01-28 04:10 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 1d21ce53b5f6 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP8 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019564: Selected record is persisted in grid state, resulting in selected record when grid is re-opened with empty child tab | |||||||
| Description | The grid states is persisted to often, everytime when the viewstate of a grid changes. This is often, when a sort happens, when a record is selected etc. This is caused by changes for this issue: https://issues.openbravo.com/view.php?id=19422 [^] Particurarly this change: https://code.openbravo.com/erp/devel/pi/diff/fe6c4992e9bc/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js#l1.44 [^] The selected record state should not be persisted, and persisting of state should only happen in specific cases (reorder, hide/show and resize of fields). | |||||||
| Steps To Reproduce | Choose a window with a child tab, open the chrome dev console. Open the window select a record, check the network tab in the google dev console, a post is done everytime a record is selected. This post stores the grid state. Then close and re-open the window, the record in the grid is re-selected but the child tab will show no record selected, See the attached image. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Screenshot at 2012-01-25 21:08:48.png [^] (52,718 bytes) 2012-01-25 21:09
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0044591) hgbot (developer) 2012-01-25 21:44 |
Repository: erp/devel/pi Changeset: 1d21ce53b5f69461cf9d3062f7e33ac293b605af Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Jan 25 21:43:38 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/1d21ce53b5f69461cf9d3062f7e33ac293b605af [^] Fixes issue 19564: Selected record is persisted in grid state, resulting in selected record when grid is re-opened with empty child tab --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js --- |
|
(0044612) hgbot (developer) 2012-01-26 15:28 |
Repository: erp/devel/pi Changeset: 02169171a052c892bc071081df418d1de1b24b67 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Jan 26 15:28:03 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/02169171a052c892bc071081df418d1de1b24b67 [^] Related to issue 19564: Selected record is persisted in grid state, resulting in selected record when grid is re-opened with empty child tab Moved if statement inside method --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js --- |
|
(0044616) iperdomo (reporter) 2012-01-26 16:24 |
* Code review and proposed the changes in changeset 02169171a052 * Tested on pi @ rev 02169171a052 * Shown some hidden column in grid, resized columns width * Checked that the selected record is not in the request payload * Closed the window, reopen again and widths and shown columns are still there |
|
(0044663) hudsonbot (developer) 2012-01-28 04:10 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8e16ef45b30c [^] Maturity status: Test |
|
(0044669) hudsonbot (developer) 2012-01-28 04:10 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8e16ef45b30c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-01-25 21:09 | mtaal | New Issue | |
| 2012-01-25 21:09 | mtaal | Assigned To | => mtaal |
| 2012-01-25 21:09 | mtaal | File Added: Screenshot at 2012-01-25 21:08:48.png | |
| 2012-01-25 21:09 | mtaal | Modules | => Core |
| 2012-01-25 21:44 | mtaal | Relationship added | related to 0019422 |
| 2012-01-25 21:44 | hgbot | Checkin | |
| 2012-01-25 21:44 | hgbot | Note Added: 0044591 | |
| 2012-01-25 21:44 | hgbot | Status | new => resolved |
| 2012-01-25 21:44 | hgbot | Resolution | open => fixed |
| 2012-01-25 21:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/1d21ce53b5f69461cf9d3062f7e33ac293b605af [^] |
| 2012-01-26 15:28 | hgbot | Checkin | |
| 2012-01-26 15:28 | hgbot | Note Added: 0044612 | |
| 2012-01-26 16:24 | iperdomo | Note Added: 0044616 | |
| 2012-01-26 16:24 | iperdomo | Status | resolved => closed |
| 2012-01-28 04:10 | hudsonbot | Checkin | |
| 2012-01-28 04:10 | hudsonbot | Note Added: 0044663 | |
| 2012-01-28 04:10 | hudsonbot | Checkin | |
| 2012-01-28 04:10 | hudsonbot | Note Added: 0044669 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |