Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019489
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajoralways2012-01-13 10:232012-04-02 06:11
ReporterjvazquezView Statuspublic 
Assigned Toguilleaer 
PrioritynormalResolutionfixedFixed in Version3.0MP10
StatusclosedFix in branchFixed in SCM revision360551790353
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019489: Variables cannot be used in "Document Type" -> "Report templates" -> "Report filename" field

DescriptionWiki page http://wiki.openbravo.com/wiki/Projects/Outbound_Email/Technical_Documentation [^]
states:

"The Report Filename can use the following tags. These tags will be replaced with the proper values when a document is send
@cus_ref@ => The reference of the document which the customer specified
@our_ref@ => The reference of the document within openbravo
@cus_nam@ => The name of the customer
@sal_nam@ => The name of the sales rep."

Only variable @our_ref@ is correctly replaced, the rest are not replaced. Moreover, the current date is always automatically appended to the filename.
Steps To ReproduceGo to "Document Type". Filter by a document name, for example, "Standard order". Select the "Report template" provided by default. Change "Report filename" field entering any of the variables @cus_ref@, @cus_nam@, @sal_nam@.
Print a Standard Order and check PDF filename is not the expected.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00245313.0MP27 closedvmromanos @cus_nam@ in report filename replaced by business partner name instead of user name as it's done in email's subject and body 

-  Notes
(0046385)
hgbot (developer)
2012-03-14 12:36

 Repository: erp/devel/pi
Changeset: 360551790353128a5498057855089c2cc74592aa
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Mar 14 12:34:28 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/360551790353128a5498057855089c2cc74592aa [^]

Fixed issue 19489: Now variables can be used in the report filename.

In purchase transactions the text @sal_nam@ is ignored.

---
M src/org/openbravo/erpCommon/utility/reporting/Report.java
M src/org/openbravo/erpCommon/utility/reporting/Report_data.xsql
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0046387)
guilleaer (developer)
2012-03-14 12:55

 The current date is always automatically appended to the filename in order to avoid errors caused by equals filenames.

The are 4 types of reports [quotations & orders, invoices, shipments, payments]
Test Plan:
1. Logged as F&B admin
2. Go to "Document Type". Filter by a document name, for example, "Standard order". Select the "Report template" provided by default. Change "Report filename" field entering any of the variables @cus_ref@, @cus_nam@, @sal_nam@.
3. Print the following documents
 - Standard Order [sale / purchase]
 - Invoice [sale / invoice]
 - Good recipt or out shipment
 - Payment in or payment out

The filename should have correct values in the vars positions.

Probably, documentation should be improved indicating that in case of purchase transactions the text @sal_nam@ is ignored.
(0046708)
hgbot (developer)
2012-03-26 10:28

 Repository: erp/devel/pi
Changeset: d63853373a536f0d70c3a75d56c60ff9d3c89575
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Mar 26 10:26:57 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d63853373a536f0d70c3a75d56c60ff9d3c89575 [^]

Related to issue 19489: Reverting unnecesary changes in printcontroller.
These changes shouldn't have been done in the previous commit

---
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0046811)
alostale (manager)
2012-03-28 11:57

 Code reviewed and tested on pi@0fc0c86395e6
(0047129)
hudsonbot (developer)
2012-04-02 06:10

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047221)
hudsonbot (developer)
2012-04-02 06:11

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-01-13 10:23 jvazquez New Issue
2012-01-13 10:23 jvazquez Assigned To => jonalegriaesarte
2012-01-13 10:23 jvazquez Modules => Core
2012-02-15 19:03 iciordia Assigned To jonalegriaesarte => vmromanos
2012-02-16 18:30 vmromanos Assigned To vmromanos => alostale
2012-03-09 09:25 alostale Assigned To alostale => guilleaer
2012-03-14 12:36 hgbot Checkin
2012-03-14 12:36 hgbot Note Added: 0046385
2012-03-14 12:36 hgbot Status new => resolved
2012-03-14 12:36 hgbot Resolution open => fixed
2012-03-14 12:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/360551790353128a5498057855089c2cc74592aa [^]
2012-03-14 12:55 guilleaer Note Added: 0046387
2012-03-26 10:28 hgbot Checkin
2012-03-26 10:28 hgbot Note Added: 0046708
2012-03-28 11:57 alostale Note Added: 0046811
2012-03-28 11:57 alostale Status resolved => closed
2012-03-28 11:57 alostale Fixed in Version => 3.0MP10
2012-04-02 06:10 hudsonbot Checkin
2012-04-02 06:10 hudsonbot Note Added: 0047129
2012-04-02 06:11 hudsonbot Checkin
2012-04-02 06:11 hudsonbot Note Added: 0047221
2013-08-16 10:32 vmromanos Relationship added related to 0024531

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker