0019411: Wrong built OB.OnChangeRegistry function

Description

Right now there is a "registry = []" array.
Then there is an assignation like
registry[tabId] = {};

This is wrong because registry is defined as an array and not like an object.
This could cause things like
tabId = '1000500000';
registry[tabId] = {};

Generate a registry.length of 1000500001

Steps To Reproduce

You can do it all in the console. Just paste this:

OB.OnChangeRegistry.register('1000500000', 'test', function() { return true; });
console.log(OB.OnChangeRegistry.registry.length);

Notice that the returned length is 1000500001

Proposed Solution

In ob-change-registry.js change line 25.

registry: [],

by

registry: {},

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0044116) hgbot (developer) 2012-01-04 13:22	Repository: erp/devel/pi Changeset: edf472b58e99d5c8ba2835799c1c514aa105d0ef Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Wed Jan 04 13:22:17 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/edf472b58e99d5c8ba2835799c1c514aa105d0ef [^] Fixed issue 19411: OB.OnChangeRegistry function now is well built --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-onchange-registry.js ---

(0044125) mtaal (manager) 2012-01-04 21:31	Reviewed

(0044287) hudsonbot (developer) 2012-01-12 10:26	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e05372cda9e0 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-01-04 13:15	dbaz	New Issue
2012-01-04 13:15	dbaz	Assigned To	=> dbaz
2012-01-04 13:15	dbaz	Modules	=> Core
2012-01-04 13:22	hgbot	Checkin
2012-01-04 13:22	hgbot	Note Added: 0044116
2012-01-04 13:22	hgbot	Status	new => resolved
2012-01-04 13:22	hgbot	Resolution	open => fixed
2012-01-04 13:22	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/edf472b58e99d5c8ba2835799c1c514aa105d0ef [^]
2012-01-04 21:31	mtaal	Note Added: 0044125
2012-01-04 21:31	mtaal	Status	resolved => closed
2012-01-04 21:31	mtaal	Fixed in Version	=> 3.0MP8
2012-01-12 10:26	hudsonbot	Checkin
2012-01-12 10:26	hudsonbot	Note Added: 0044287