Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019403
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2012-01-03 17:392012-03-02 15:39
ReporterVictorVillarView Statuspublic 
Assigned Toguilleaer 
PriorityhighResolutionfixedFixed in Version3.0MP9
StatusclosedFix in branchFixed in SCM revision609fffb254cf
ProjectionnoneETAnoneTarget Version3.0MP9
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0MP6SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019403: Wrong performance of Rowspan value.

DescriptionWe have realised that it is a wrong performance of Rowspan and Colspan values in different cases.
It seems that it does not matter the value of Rowspan.
Steps To ReproduceAs System Admin role,
navigate to Windows, tabs and fields window:
   - select Financial Account || Reconciliations || Details (is a widget)
     Open in Form view, the rowspan and colspan appear and it works fine.
   - select Product || product || Name
     Open in Form view we cannot see the rowspan and colspan fields. This fields are showed if the column associated is 'OBKMO_Widget in Form Reference' (they have a displaylogic:@OBUIAPP_Field_Reference@ ='FF8080813123BF670131241C2BB30012'
     They appear in Grid view, if we change this values (Rowspan:8 and Colspan:4), only it works fine the colspan value, the field Name always is 1 row it does not matter the rowspan value.
   - If we try to create a new field, it does not appear the rowspan and colspan fields in form view. In grid view you can change those values but it happens the same as before.

As Group Admin role,
Go to Product window
Click in Form personalization button:
   - select Name field
   - change the rowspan value it does not happen anything in the preview
   - change the colspan value, it works fine.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0019923 closedguilleaer Image type fields should adapt itself to the defined rowspan and colspan 
related to defect 0020133 closedalostale Some fields have changed from text area to text field 
blocks defect 0010601 closedguilleaer The process log field in the Process Execution window is unnecessarily small 

-  Notes
(0045395)
hgbot (developer)
2012-02-23 10:53

 Repository: erp/devel/pi
Changeset: 609fffb254cf1a9ff156a4703fcacd1ce7b50455
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Feb 23 10:46:21 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/609fffb254cf1a9ff156a4703fcacd1ce7b50455 [^]

Fixed issue 19403: fields which are drawn as textarea adapts the height considering the defined rowspan.
When textarea is created, the rowspan of the cell which contains it is checked. Then, the height of the texarea is calculated to fill the cell space.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-textarea.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-form-styles.js
---
(0045402)
guilleaer (developer)
2012-02-23 11:18

 This fix only works with fields which are drawn as textarea.

One field will be drawn as textarea when:
- The reference of the column related to the field is defined as Text.
- The reference of the column related to the field is defined as string and the length is greater than 255 characters.

If the rowspan of textfield is changed using form personalization utility, it will not work because this field is a textfield and it cannot be changed. In this case the reference of the column should be changed in the Application dictionary to work properly.
(0045404)
guilleaer (developer)
2012-02-23 12:24

 I was wrong in the previous note.

One field will be drawn as textarea only when:
- The reference of the column related to the field is defined as Text.
(0045405)
hgbot (developer)
2012-02-23 12:47

 Repository: erp/devel/pi
Changeset: 8f8ae175ff2bc581616ec0d3aadfef300220ea35
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Feb 23 12:45:14 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8f8ae175ff2bc581616ec0d3aadfef300220ea35 [^]

Related to issue 19403: Display logic for rowSpan has been changed.
Now row span field is shown in the form view when the column reference of the field is TEXT

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
---
(0045410)
guilleaer (developer)
2012-02-23 13:43

 Test plan:
1. Logged as System administrator
2. Windows tab & fields
3. Look for a field with a TEXT reference (E.g. sales orders/sales orders/description)
4. Change rowspan (Should be displayed in form view because the change in display logic)
5. Save and log in as F&BAdmin
6. Check the field in the form view. It should have a height which fills the space of the cell.

Risk of regressions
- affects to textareas
(0045537)
hgbot (developer)
2012-02-28 14:52

 Repository: erp/devel/pi
Changeset: 512d578b41e380ac61ccf2ebe8f3747e6921c72d
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Feb 28 14:51:17 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/512d578b41e380ac61ccf2ebe8f3747e6921c72d [^]

Related to issue 19403: colspan also is visible in form view.
Display logic has been changed to be displayed with TEXT references

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
---
(0045554)
AugustoMauch (administrator)
2012-02-28 17:12

 Code reviewed and verified
(0045933)
hudsonbot (developer)
2012-03-02 15:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045940)
hudsonbot (developer)
2012-03-02 15:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045973)
hudsonbot (developer)
2012-03-02 15:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-01-03 17:39 VictorVillar New Issue
2012-01-03 17:39 VictorVillar Assigned To => alostale
2012-01-03 17:39 VictorVillar Modules => Core
2012-01-03 17:39 VictorVillar Resolution time => 1331247600
2012-01-03 17:39 VictorVillar Issue Monitored: networkb
2012-01-09 16:59 VictorVillar Steps to Reproduce Updated View Revisions
2012-01-16 16:46 mirurita Issue Monitored: mirurita
2012-01-17 09:03 shuehner Issue Monitored: shuehner
2012-01-23 09:25 guilleaer Assigned To alostale => guilleaer
2012-02-23 10:53 hgbot Checkin
2012-02-23 10:53 hgbot Note Added: 0045395
2012-02-23 10:53 hgbot Status new => resolved
2012-02-23 10:53 hgbot Resolution open => fixed
2012-02-23 10:53 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/609fffb254cf1a9ff156a4703fcacd1ce7b50455 [^]
2012-02-23 11:18 guilleaer Note Added: 0045402
2012-02-23 12:24 guilleaer Note Added: 0045404
2012-02-23 12:47 hgbot Checkin
2012-02-23 12:47 hgbot Note Added: 0045405
2012-02-23 13:43 guilleaer Note Added: 0045410
2012-02-28 09:54 alostale Relationship added blocks 0010601
2012-02-28 14:52 hgbot Checkin
2012-02-28 14:52 hgbot Note Added: 0045537
2012-02-28 17:12 AugustoMauch Note Added: 0045554
2012-02-28 17:12 AugustoMauch Status resolved => closed
2012-02-28 17:12 AugustoMauch Fixed in Version => 3.0MP9
2012-02-29 17:27 dbaz Relationship added related to 0019923
2012-03-02 15:38 hudsonbot Checkin
2012-03-02 15:38 hudsonbot Note Added: 0045933
2012-03-02 15:39 hudsonbot Checkin
2012-03-02 15:39 hudsonbot Note Added: 0045940
2012-03-02 15:39 hudsonbot Checkin
2012-03-02 15:39 hudsonbot Note Added: 0045973
2012-03-28 13:21 alostale Relationship added related to 0020133

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker