Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019338 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2011-12-20 12:20 | 2011-12-28 04:38 | |||
| Reporter | jecharri | View Status | public | |||||
| Assigned To | marvintm | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0MP7 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 222a1f0084c5 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP7 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019338: The readonlylogic is not working properly in subtabs | |||||||
| Description | The readonlylogic is not working properly in subtabs. If you have one read only logic defined in a column that it is in a subtab (Header->tab->subtab) it doesn't work in one case. | |||||||
| Steps To Reproduce | As "System Administrator" go to window "Tables and Columns": -choose the table "c_invoicelinetax" and go to column "Line" -put "@Processed@='Y'" as "Read Only Logic". Now go to "Windows,tabs and fields" and select the window "Sales Invoice": -choose the tab "Line Tax" and change the value of field "UI Pattern" from "Read Only" to "Standard". Do "ant smartbuild" and restart Tomcat. Now, as "Group Admin" go to window sales invoice: -choose one invoice that it is "Completed" and have lines and taxes. -after select one invoice, go to tab "Lines" and after that to tab "Line Tax" -you will see that you can edit the field "Line No." and you will not be able to edit.[error.png] After that return to the tab line and open it in mode Form: -if you go again to tab "Line Tax" you will see that you can not edit the fields. This is the desired behaviour.[correct.png] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  error.png [^] (68,410 bytes) 2011-12-20 12:20
correct.png [^] (81,118 bytes) 2011-12-20 12:20
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0043977) alostale (manager) 2011-12-21 10:39 |
C_Invoice.Processed column should be marked as stored in session, even doing so the issue can be reproduced. The problem seems to be FIC is not setting session values for grand parent and above tabs. |
|
(0043978) hgbot (developer) 2011-12-21 12:10 |
Repository: erp/devel/pi Changeset: 222a1f0084c5fc5fff2855d52364159867d97793 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Wed Dec 21 12:10:00 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/222a1f0084c5fc5fff2855d52364159867d97793 [^] Fixed issue 19338. When computing session attributes, readonly logic will be considered in addition to display logic --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java --- |
|
(0043979) marvintm (developer) 2011-12-21 12:14 |
The issue in this case was that the read only logic was not being considered in the Form Initialization Component, when the session values were being computed. This meant that in this case, even when the column was marked as Store in Session, its value wasn't returned in the JSON returned by the FIC. The change done has been to add all the columns used in the read only logic to the session attributes, in addition to the ones used in display logic. Things which should be verified when reviewing the issue: - That the readonly logic works (in the example described in the issue, that the field can be modified when the invoice is not processed, and cannot be modified when the invoice is processed). - That fields with displaylogic which depend on session variables still work correctly (that the field is shown and hidden appropriately depending on its display logic). |
|
(0044001) alostale (manager) 2011-12-22 09:21 |
Verified on pi@d17b74061474 |
|
(0044040) hudsonbot (developer) 2011-12-28 04:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05d50af83cc8 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-12-20 12:20 | jecharri | New Issue | |
| 2011-12-20 12:20 | jecharri | Assigned To | => alostale |
| 2011-12-20 12:20 | jecharri | File Added: error.png | |
| 2011-12-20 12:20 | jecharri | Modules | => Core |
| 2011-12-20 12:20 | jecharri | Resolution time | => 1327878000 |
| 2011-12-20 12:20 | jecharri | File Added: correct.png | |
| 2011-12-20 12:22 | jecharri | Steps to Reproduce Updated | View Revisions |
| 2011-12-21 10:37 | alostale | Assigned To | alostale => marvintm |
| 2011-12-21 10:39 | alostale | Note Added: 0043977 | |
| 2011-12-21 12:10 | hgbot | Checkin | |
| 2011-12-21 12:10 | hgbot | Note Added: 0043978 | |
| 2011-12-21 12:10 | hgbot | Status | new => resolved |
| 2011-12-21 12:10 | hgbot | Resolution | open => fixed |
| 2011-12-21 12:10 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/222a1f0084c5fc5fff2855d52364159867d97793 [^] |
| 2011-12-21 12:14 | marvintm | Note Added: 0043979 | |
| 2011-12-22 09:21 | alostale | Note Added: 0044001 | |
| 2011-12-22 09:21 | alostale | Status | resolved => closed |
| 2011-12-22 09:21 | alostale | Fixed in Version | => 3.0MP7 |
| 2011-12-28 04:38 | hudsonbot | Checkin | |
| 2011-12-28 04:38 | hudsonbot | Note Added: 0044040 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |