0019154: Buffer too small to concatenate strings in section "Create default Cash entry" in c_order_post1

Description

In the section "Create default Cash entry" there is a concatenation and the variable v_DocumentNo is too small (200), in the function c_order_post1, when you post a Sales Order

Steps To Reproduce

When you post a Sales Order, it happens the following concatenation:
C_ORDER.DOCUMENTNO||' - '||C_BPARTNER.NAME||' - '||C_ORDER.GRANDTOTAL
and it stores in v_DocumentNo

We can see in PL/SQL c_order_post1 the definition of the variable:
v_DocumentNo VARCHAR (200)
and the section "Create default Cash entry" has the following code:

/**************************************************************************
  * Create default Cash entry
  *************************************************************************/
  DECLARE
    v_PaymentRule VARCHAR(60) ;
    CUR_CB RECORD;
    v_debtPaymentID VARCHAR(32); --OBTG:varchar2--
    v_totalCash NUMERIC;
  v_CB_Curr VARCHAR(32); --OBTG:varchar2--
  BEGIN
    /* ALO
    */
    UPDATE C_DEBT_PAYMENT SET IsValid='Y' WHERE C_Order_ID=v_Record_ID;
    SELECT C_ORDER.PAYMENTRULE,
      C_ORDER.DOCUMENTNO||' - '||C_BPARTNER.NAME||' - '||C_ORDER.GRANDTOTAL,
      C_ORDER.GRANDTOTAL,
      C_ORDER.M_WAREHOUSE_ID
    INTO v_PaymentRule,
      v_DocumentNo,
      v_GrandTotal,
      v_M_Warehouse_ID
    FROM C_ORDER,
      C_BPARTNER
    WHERE C_ORDER.C_BPARTNER_ID=C_BPARTNER.C_BPARTNER_ID
      AND C_ORDER_ID=v_Record_ID;
    SELECT MAX(NAME)
    INTO v_WarehouseName
    FROM M_WAREHOUSE
    WHERE M_WAREHOUSE_ID=v_M_Warehouse_ID;

Proposed Solution

It should be fix with the next statement:
substr(C_ORDER.DOCUMENTNO||' - '||C_BPARTNER.NAME||' - '||C_ORDER.GRANDTOTAL||' ...',1,200)

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

0019155

2.50MP37

closed

umartirena

Buffer too small to concatenate strings in section "Create default Cash entry" in c_order_post1

Notes
(0043972) VictorVillar (developer) 2011-12-20 12:47	verified

Issue History
Date Modified	Username	Field	Change
2011-11-23 16:58	VictorVillar	New Issue
2011-11-23 16:58	VictorVillar	Assigned To	=> jonalegriaesarte
2011-11-23 16:58	VictorVillar	Modules	=> Core
2011-11-23 16:58	VictorVillar	Resolution time	=> 1323990000
2011-11-23 16:59	VictorVillar	Status	new => scheduled
2011-11-23 16:59	VictorVillar	fix_in_branch	=> pi
2011-12-13 13:16	jonalegriaesarte	Assigned To	jonalegriaesarte => umartirena
2011-12-20 12:46	VictorVillar	Status	scheduled => resolved
2011-12-20 12:46	VictorVillar	Fixed in Version	=> pi
2011-12-20 12:46	VictorVillar	Fixed in SCM revision	=> https://code.openbravo.com/erp/devel/pi/rev/adf768df23c5 [^]
2011-12-20 12:46	VictorVillar	Resolution	open => fixed
2011-12-20 12:47	VictorVillar	Note Added: 0043972
2011-12-20 12:47	VictorVillar	Status	resolved => closed
2011-12-20 12:47	VictorVillar	Fixed in Version	pi =>