Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019083
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Modules] Payment ReportmajorN/A2011-11-16 12:002011-12-01 10:06
ReportervmromanosView Statuspublic 
Assigned Tovmromanos 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision1f4815271d27
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_12
OS VersionDebian 5.0Database version8.3.8Ant version1.7.0
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0019083: Add balance information when grouping and remove some useless fields

DescriptionSeveral improvements need to be added to the payment report:

1. Remove the Subtotal for the grouping criteria because it provides useless information

2. Remove the sum of trans. amount because it may sum amounts from different currencies

3. Remove the last grand total line because it provides useless information

4. Add a balance field when grouping. This balance will show the difference between the pending credit to be used and the pending payments. This information is specially useful when grouping by business partner.

The pending credit to take into account belongs to payments with the following status: Withdrawn not cleared, Payment Received, Payment Cleared, Payment Made and Deposited not Clear.

The pending payments to take into account do NOT have the following status: Withdrawn not cleared, Payment Received, Payment Cleared, Payment Made, Deposited not Clear and Voided
Steps To ReproduceSee description
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to backport 0019084 closedvmromanos Add balance information when grouping and remove some useless fields 

-  Notes
(0042919)
hgbot (developer)
2011-11-17 11:19

 Repository: erp/devel/pi
Changeset: 1f4815271d279811aed6e8e7d19a56930905f7c5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Nov 16 18:50:44 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1f4815271d279811aed6e8e7d19a56930905f7c5 [^]

Fixed issue 19083:

Several improvements added to the payment report:

1. Remove the Subtotal for the grouping criteria because it provides
useless information

2. Remove the sum of trans. amount because it may sum amounts from
different currencies

3. Remove the last grand total line because it provides useless
information

4. Add a balance field when grouping. This balance will show the
difference between the pending credit to be used and the pending
payments. This information is specially useful when grouping by
business partner.

   The pending credit to take into account belongs to payments with the
following status: Withdrawn not cleared, Payment Received, Payment
Cleared, Payment Made and Deposited not Clear.

   The pending payments to take into account do NOT have the following
status: Withdrawn not cleared, Payment Received, Payment Cleared,
Payment Made, Deposited not Clear and Voided


Apart from that, some minor bugs have been fixed:
- Order by clause orders by invoice payment schedule
- Improved code that prints the asterisks in case of credit payments
- In the PDF report, the group criteria band is now shown only when
the user has selected a grouping criteria

---
M modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.html
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.java
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.xml
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportPDF.jrxml
---
(0043041)
hudsonbot (developer)
2011-11-22 03:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ebd713dfe507 [^]

Maturity status: Test
(0043625)
eduardo_Argal (developer)
2011-12-01 10:06

 Testes and working. A fix was required:
19218: When filtering in payment report (no credit payments) invoices awaiting payment are not displayed.

Comment: when coding and using values is better to create final variables which name is self explanatory. Open source needs code to be easy readable. Example:
if (!isCreditPayment && status != null && "PWNC RPR RPPC PPM RDNC RPVOID".indexOf(status) == -1)

- Issue History
Date Modified Username Field Change
2011-11-16 12:00 vmromanos New Issue
2011-11-16 12:00 vmromanos Assigned To => vmromanos
2011-11-16 12:03 vmromanos Description Updated View Revisions
2011-11-16 12:16 vmromanos Issue cloned 0019084
2011-11-16 12:16 vmromanos Relationship added related to 0019084
2011-11-16 12:24 vmromanos Status new => scheduled
2011-11-16 12:24 vmromanos fix_in_branch => pi
2011-11-16 12:53 vmromanos fix_in_branch pi =>
2011-11-16 12:53 vmromanos Description Updated View Revisions
2011-11-17 11:19 hgbot Checkin
2011-11-17 11:19 hgbot Note Added: 0042919
2011-11-17 11:19 hgbot Status scheduled => resolved
2011-11-17 11:19 hgbot Resolution open => fixed
2011-11-17 11:19 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1f4815271d279811aed6e8e7d19a56930905f7c5 [^]
2011-11-22 03:50 hudsonbot Checkin
2011-11-22 03:50 hudsonbot Note Added: 0043041
2011-12-01 10:06 eduardo_Argal Note Added: 0043625
2011-12-01 10:06 eduardo_Argal Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker