Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019016 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 05. Production management | minor | always | 2011-11-08 13:00 | 2012-04-28 02:31 | |||
| Reporter | deepacp | View Status | public | |||||
| Assigned To | naiaramartinez | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP12 | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 9f1665574f35 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | Oracle | Java version | 1.6.0_20 | |||
| OS Version | Ubuntu 10.04 LTS | Database version | 11.1.0.6.0 | Ant version | 1.7.1 | |||
| Product Version | 2.50MP31 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | Mozilla Firefox | |||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019016: Process "Insert Maintenances" incorrectly calculates the weekend | |||||||
| Description | Process "Insert Maintenances" checks for weekend as to_char (date, 'd') = 6 or 7. However, Sunday is defined as the first day of the week, ie. 1 and Saturday as the last, ie.7. Hence, it wrongly schedules the maintenances that fall on Friday to the coming Sunday, with "Exclude Weekend" option checked. This issue is visible for periodicity types - daily, M1, M2, M3, M6 PS: Checked the NLS_TERRITORY to see if the day of the week varies as per this. Changed it to Spain, Germany, UK and America and it still behaved the same. In my case, NLS_TERRITORY is set to INDIA. | |||||||
| Steps To Reproduce | 1. Production Management || Setup || Machine || Machine >> Maintenance: Define maintenance as Preventive 2. Production Management || Setup || Machine || Machine >> Maintenance >> Periodicity: Define periodicity as daily 3. Go to Production Management and run process "Insert Maintenances" setting dates that include a weekend, say 11/08/2011 to 11/15/2011. | |||||||
| Proposed Solution | Change the checks for weekend to 1. For Saturday, to_char (date, 'd') = '7' 2. For Sunday, to_char (date, 'd') = '1' | |||||||
| Tags | VMA-Reviewed | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0047660) naiaramartinez (developer) 2012-04-17 11:48 |
Test Plan: Go to Machine window. Create a new record. Go to Maintenance tab and create a new record. Set Maintenance type as preventive. Go to Periodicity tab and create a new record. Set Periodicity type as daily. Go to Insert Maintenance process. Set the startint day to 17-04-2012 and Ending date to 30-04-2012. Press OK. Go to Maintenance Plan. Notice that a record has been created for each day but for weekends (Saturday and Sunday). |
|
(0048017) hgbot (developer) 2012-04-26 12:45 |
Repository: erp/devel/pi Changeset: 9f1665574f3582d6f1415e356ff0021fcff4aa4a Author: Naiara Martinez <naiara.martinez <at> openbravo.com> Date: Thu Apr 26 10:01:01 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/9f1665574f3582d6f1415e356ff0021fcff4aa4a [^] fixed bug 19016 Calculate the weekends in Insert Maintenances --- M src-db/database/model/functions/C_PAYMENTDUEDATE.xml M src-db/database/model/functions/MA_MAINTENANCE_SCHEDULE.xml A src-db/database/model/functions/C_GET_ISO_DAYS.xml --- |
|
(0048018) mirurita (developer) 2012-04-26 12:46 |
code review + testing OK new function working in Oracle and PostgreSQL |
|
(0048027) hgbot (developer) 2012-04-26 13:37 |
Repository: erp/devel/pi Changeset: c03f5142dd6067200aba8e4681f891f7ababdadc Author: Mikel Irurita <mikel.irurita <at> openbravo.com> Date: Thu Apr 26 13:35:37 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/c03f5142dd6067200aba8e4681f891f7ababdadc [^] Related to issue 19016: rename function to C_GET_ISOWEEK_DAY --- M src-db/database/model/functions/C_PAYMENTDUEDATE.xml M src-db/database/model/functions/MA_MAINTENANCE_SCHEDULE.xml A src-db/database/model/functions/C_GET_ISOWEEK_DAY.xml R src-db/database/model/functions/C_GET_ISO_DAYS.xml --- |
|
(0048158) hudsonbot (developer) 2012-04-28 02:31 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cd923b317af4 [^] Maturity status: Test |
|
(0048160) hudsonbot (developer) 2012-04-28 02:31 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cd923b317af4 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-11-08 13:00 | deepacp | New Issue | |
| 2011-11-08 13:00 | deepacp | Assigned To | => jonalegriaesarte |
| 2011-11-08 13:00 | deepacp | Web browser | => Mozilla Firefox |
| 2011-11-08 13:00 | deepacp | Modules | => Core |
| 2011-11-08 13:01 | deepacp | Issue Monitored: deepacp | |
| 2011-12-27 11:41 | RenateNieuwkoop | Issue Monitored: RenateNieuwkoop | |
| 2012-04-03 12:20 | jonalegriaesarte | Assigned To | jonalegriaesarte => vmromanos |
| 2012-04-11 09:23 | vmromanos | Tag Attached: VMA-Reviewed | |
| 2012-04-17 11:48 | naiaramartinez | Note Added: 0047660 | |
| 2012-04-17 11:48 | naiaramartinez | Assigned To | vmromanos => naiaramartinez |
| 2012-04-17 11:48 | naiaramartinez | Status | new => scheduled |
| 2012-04-17 11:48 | naiaramartinez | fix_in_branch | => pi |
| 2012-04-26 12:45 | hgbot | Checkin | |
| 2012-04-26 12:45 | hgbot | Note Added: 0048017 | |
| 2012-04-26 12:45 | hgbot | Status | scheduled => resolved |
| 2012-04-26 12:45 | hgbot | Resolution | open => fixed |
| 2012-04-26 12:45 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/9f1665574f3582d6f1415e356ff0021fcff4aa4a [^] |
| 2012-04-26 12:46 | mirurita | Note Added: 0048018 | |
| 2012-04-26 12:46 | mirurita | Status | resolved => closed |
| 2012-04-26 12:46 | mirurita | Fixed in Version | => 3.0MP12 |
| 2012-04-26 13:37 | hgbot | Checkin | |
| 2012-04-26 13:37 | hgbot | Note Added: 0048027 | |
| 2012-04-28 02:31 | hudsonbot | Checkin | |
| 2012-04-28 02:31 | hudsonbot | Note Added: 0048158 | |
| 2012-04-28 02:31 | hudsonbot | Checkin | |
| 2012-04-28 02:31 | hudsonbot | Note Added: 0048160 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |