0018998: Copy GL Journal does not respect organization of original batch

Notes
(0042641) pjuvara (reporter) 2011-11-07 00:34	When fixing this issue, care should be taken to avoid functional regressions. If I have two organizations A and B and I create a journal with all lines in A, then I can copy that journal into organization B and I should expect that all lines are moved to organization B. However, if I have a journal in organization A with lines across organizations B and C and I copy that journal again into A, the resulting lines should be across B and C. In other words: 1) If the target batch is in the same organization as source batch, target lines should take organization from source lines 2) If the target batch is in a different organization than source batch, target lines should take organization from target batch.

(0049792) hgbot (developer) 2012-06-13 09:50	Repository: erp/devel/pi Changeset: 8f9fe48cbf5cdd366d07c1fded3517f741f03fc7 Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> Date: Tue Jun 12 18:51:10 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/8f9fe48cbf5cdd366d07c1fded3517f741f03fc7 [^] Fixes bug 18998 --- M src/org/openbravo/erpCommon/ad_process/CopyFromGLJournal.java M src/org/openbravo/erpCommon/ad_process/CopyFromGLJournal_data.xsql ---

(0049796) eduardo_Argal (developer) 2012-06-13 10:33	TESTING PLAN: 1) Create a GLJournal and flag it as template. It should contain lines using different organizations 2) Create a new one and copy details from previous. 3) Mind that newly created lines are pointing to organizations which are the same as the source (that from which you are coping and not the organization of the header)

(0049804) eduardo_Argal (developer) 2012-06-13 12:31	Previous change was not complete. New change set required

(0049808) hgbot (developer) 2012-06-13 12:49	Repository: erp/devel/pi Changeset: 4bd3811f32a2e5e02885d2d9b935533d5787ff4c Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> Date: Wed Jun 13 12:33:11 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/4bd3811f32a2e5e02885d2d9b935533d5787ff4c [^] Fixes bug 18998. [Related to commit 8f9fe48cbf5c] Missing change in previous commit --- M src/org/openbravo/erpCommon/ad_process/CopyFromGLJournal.java ---

(0050106) mirurita (developer) 2012-06-26 17:56	Related issue 0020746: it was possible to copy a G/L journal from a organization not in the same tree. For example, you could copy in 'F&B US, Inc.' line details from a G/L journal created for 'F&B España, S.A'. From a target batch you should be able to copy only batches that belong to the same org or child orgs. It is consistent with the behavior using the UI. 1) If I have two organizations A and B and I create a journal with all lines in A, then I can copy that journal into organization B and I should expect that all lines are moved to organization B. As explained before (issue 0020746), this scenario is only possible if org A is a child of org B. In that case, target lines will be created for org A. 2) Working fine.

Issue History
Date Modified	Username	Field	Change
2011-11-07 00:30	pjuvara	New Issue
2011-11-07 00:30	pjuvara	Assigned To	=> jonalegriaesarte
2011-11-07 00:30	pjuvara	File Added: out.ogv
2011-11-07 00:30	pjuvara	Modules	=> Core
2011-11-07 00:34	pjuvara	Note Added: 0042641
2011-11-07 00:34	pjuvara	Relationship added	depends on 0018996
2011-11-07 01:43	pjuvara	Tag Attached: AccountingDemo
2012-06-12 18:50	eduardo_Argal	Status	new => scheduled
2012-06-12 18:50	eduardo_Argal	Assigned To	jonalegriaesarte => eduardo_Argal
2012-06-12 18:50	eduardo_Argal	fix_in_branch	=> pi
2012-06-13 09:50	hgbot	Checkin
2012-06-13 09:50	hgbot	Note Added: 0049792
2012-06-13 09:50	hgbot	Status	scheduled => resolved
2012-06-13 09:50	hgbot	Resolution	open => fixed
2012-06-13 09:50	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/8f9fe48cbf5cdd366d07c1fded3517f741f03fc7 [^]
2012-06-13 10:33	eduardo_Argal	Note Added: 0049796
2012-06-13 12:31	eduardo_Argal	Note Added: 0049804
2012-06-13 12:31	eduardo_Argal	Status	resolved => new
2012-06-13 12:31	eduardo_Argal	Resolution	fixed => open
2012-06-13 12:31	eduardo_Argal	Status	new => scheduled
2012-06-13 12:49	hgbot	Checkin
2012-06-13 12:49	hgbot	Note Added: 0049808
2012-06-13 12:49	hgbot	Status	scheduled => resolved
2012-06-13 12:49	hgbot	Resolution	open => fixed
2012-06-13 12:49	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/devel/pi/rev/8f9fe48cbf5cdd366d07c1fded3517f741f03fc7 [^] => http://code.openbravo.com/erp/devel/pi/rev/4bd3811f32a2e5e02885d2d9b935533d5787ff4c [^]
2012-06-26 17:56	mirurita	Note Added: 0050106
2012-06-26 17:56	mirurita	Status	resolved => closed
2012-06-26 17:56	mirurita	Fixed in Version	=> 3.0MP13