Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0018779
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2011-10-16 11:062012-03-02 15:38
ReportershuehnerView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in Version3.0MP9
StatusclosedFix in branchFixed in SCM revision324daab48217
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0018779: Removed duplicate extra call to FIC-setsession when selecting new row in grid

DescriptionWhen selecting a new/different record in at least the 'Windows, Tabs & Fields' window then in addition to the two expected SETSESSION calls (1*parent, 1*child) another for the parent is fired so in total there are:

1* setsession parent
1* load new child-row
1* setsession child-row
1* setsession parent-row
Steps To ReproduceOpen 'Windows, Tabs & fields' window
click on record to select it in the grid

Now click another record to select it in the grid
Check http requests done after this last selection
Proposed SolutionDon't issue two setsession calls for the new parent row.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0045357)
hgbot (developer)
2012-02-22 12:49

Repository: erp/devel/pi
Changeset: 324daab482176f482e87d3b5817d0f2318fbcd66
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Feb 22 12:48:24 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/324daab482176f482e87d3b5817d0f2318fbcd66 [^]

Fixed issue 18779. Only do FIC requests for current active view

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0045359)
marvintm (developer)
2012-02-22 12:55

The method responsible for the calls to the FIC in SETSESSION mode has been changed. Before, it made a call for each buttoncontext (so, for each tab). Now, it only does a call to the FIC for the active tab. If the active tab is a children tab, the FIC finds the parent record, and computes its session variables automatically, so the rest of the calls were not necessary.

The following things need to be tested:
- The provided example in the issue works correctly (so, only two calls to the FIC are done, not three).
- Attachments in parent/child are correctly detected and the attachments button in the toolbar is correctly updated (all combinations need to be tested: parent with attachments and children without, parent without and child with attachments, parent and child with attachments, and parent and child without attachments).
- A window with a children tab which has a button whose display logic depends on a field belonging to the parent also needs to be tested. AFAIK, we currently don't have an example of this in the application, but it can be easily generated.
(0045617)
alostale (manager)
2012-02-29 14:57

Code reviewed and tested on pi@3afb79bd3730
(0045922)
hudsonbot (developer)
2012-03-02 15:38

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-10-16 11:06 shuehner New Issue
2011-10-16 11:06 shuehner Assigned To => jonalegriaesarte
2011-10-16 11:06 shuehner Modules => Core
2012-02-15 19:04 iciordia Assigned To jonalegriaesarte => vmromanos
2012-02-16 16:46 vmromanos Assigned To vmromanos => alostale
2012-02-17 14:36 alostale Assigned To alostale => marvintm
2012-02-22 12:49 hgbot Checkin
2012-02-22 12:49 hgbot Note Added: 0045357
2012-02-22 12:49 hgbot Status new => resolved
2012-02-22 12:49 hgbot Resolution open => fixed
2012-02-22 12:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/324daab482176f482e87d3b5817d0f2318fbcd66 [^]
2012-02-22 12:55 marvintm Note Added: 0045359
2012-02-29 14:57 alostale Note Added: 0045617
2012-02-29 14:57 alostale Status resolved => closed
2012-02-29 14:57 alostale Fixed in Version => 3.0MP9
2012-03-02 15:38 hudsonbot Checkin
2012-03-02 15:38 hudsonbot Note Added: 0045922


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker