Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0018561
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 01. General setupmajoralways2011-09-20 08:062012-01-20 13:11
ReporterroklenardicView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision067d0992e67d
ProjectionnoneETAnoneTarget Version3.0MP7
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0MP4.1SCM revision 
Review Assigned To
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0018561: Time reference showed incorrectly in Process Request window

DescriptionWhen entering Start Time in Process Request window, the saved value is not displayed correctly.
Steps To Reproduce1) Go to General Setup || Process Scheduling || Process Request screen and enter a new record for any of the background processes
2) select Timing = Schedule
3) Enter 12:30 into Start Time
4) Save
5) refresh the record and the Start Time changes to 11:30

PS: try entering 6:05 into Start time and refreshing, it changes to 0:00.
TagsNo tags attached.
Attached Filestgz file icon time.tgz [^] (625 bytes) 2011-11-24 11:28
? file icon issue-18561.export [^] (6,190 bytes) 2011-11-24 11:49

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00184843.0MP5 closedmtaal Fields Updated and Created do not have the hour 
related to defect 0016014 closedmtaal Date fields on edit mode decrease by one day 
has duplicate defect 0018257 closedmarvintm Process request shows different start time in grid and form view 
related to defect 00193663.0MP8 closedalostale Refreshing Work Effort Header window changes values in the Starting Time & Ending Time columns/fields. 
related to defect 0020684 closedAugustoMauch Incorrect time in process request with different timezones in client/server 

-  Notes
(0043147)
alostale (manager)
2011-11-24 11:42

 This seems to be an issue with SmartClient and how it sends time to backend.

From SmartClient documentation:
"time field values in requests will be serialized out as full times in UTC using the standard XML Schema date / time format - HH:MM:SS" (http://www.smartclient.com/docs/8.0/a/b/c/go.html#group..dateFormatAndStorage [^])

The problem seems to be time zone is not taken into account, so regardless client's timezone, the time entered in the field is sent to backend. Backened is assuming UTC in case no timezone offset is sent, so it takes it as UTC time.

In case DataSource.serializeTimeAsDatetime class property is set to true (which is false by default), complete date in UTC time is sent to backend, making all stuff to work. The problem this is a DataSource class property, which might affect to any Datasource instances.
(0043148)
alostale (manager)
2011-11-24 11:51

 Changed target release to mp7, as the changeset needs to be reviewed, because it might create some regressions as it is changing global DataSource behavior.

Attached proposed patch though.
(0043149)
alostale (manager)
2011-11-24 11:53

 Test plan:
-In Process Request edit start time
-Save
-Refresh
-Check time is not changed

Test with different times, i.e: 10:10, 1:05, 13:14...

Regression check:
This changeset is setting a global DataSource setting which makes to change the way times are sent to backend. Check possible collaterals for this change.
(0043769)
hgbot (developer)
2011-12-12 08:31

 Repository: erp/devel/pi
Changeset: 54a304b3a7ab26c18b4eef13cf657f99668e5bc6
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Nov 24 11:47:05 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/54a304b3a7ab26c18b4eef13cf657f99668e5bc6 [^]

fixed bug 18561: Time reference showed incorrectly in Process Request window

Setting isc.DataSource.serializeTimeAsDatetime=true so time references are sent as complete
UTC date time rather than just truncating timezone information.

Formatting it properly in the FIC response.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/TimeUIDefinition.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0043786)
mtaal (manager)
2011-12-12 11:19

 2 issues:
- in grid editing the error still occurs, when the time is 06:00 then in grid editing the edit field shows: 07:00, note that the displayformatting is caused by another issue (19114)
- there is a javascript error in the pushed code:
     for (i = 0; i < toolBarButtons.leftMembers.length; i++) {
        if (toolBarButtons.leftMembers[i].updateState) {
          toolBarButtons.leftMembers[i].updateState();
        }
      }
 
should be changed to:
      for (i = 0; i < toolBarButtons.length; i++) {
        if (toolBarButtons[i].updateState) {
          toolBarButtons[i].updateState();
        }
      }
(0043790)
hgbot (developer)
2011-12-12 11:34

 Repository: erp/devel/pi
Changeset: 45ff7d718f068d025dc75b25b3807de2f03a4376
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Dec 12 11:33:03 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/45ff7d718f068d025dc75b25b3807de2f03a4376 [^]

fixed bug 18561: Fixed js error

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
---
(0043791)
mtaal (manager)
2011-12-12 11:50

 To solve issue with moving time
(0043792)
mtaal (manager)
2011-12-12 11:50

 Also 16014 needs to be retested when closing this issue
(0043793)
hgbot (developer)
2011-12-12 11:53

 Repository: erp/devel/pi
Changeset: bd7c690a637aabb8469e33a356d7fb74177aa33d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Dec 12 11:52:38 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bd7c690a637aabb8469e33a356d7fb74177aa33d [^]

Fixes issue 18561: Time reference showed incorrectly in Process Request window

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0043795)
hgbot (developer)
2011-12-12 12:02

 Repository: erp/devel/pi
Changeset: c4639a1013b7274f6bd697d6a7d6e31d108d90b5
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Dec 12 12:02:23 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c4639a1013b7274f6bd697d6a7d6e31d108d90b5 [^]

Related to issue 18561: Time reference showed incorrectly in Process Request window
Also show seconds in edit mode

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
---
(0043804)
marvintm (developer)
2011-12-12 16:31

 The fix doesn't work in case the server and the client are in different timezones
(0043813)
hgbot (developer)
2011-12-13 10:32

 Repository: erp/devel/pi
Changeset: 067d0992e67d8907efbcb7c2e1ae24a2dd52c3cd
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Dec 13 10:31:10 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/067d0992e67d8907efbcb7c2e1ae24a2dd52c3cd [^]

fixed bug 18561: Time reference showed incorrectly in Process Request window

  Now when server and client are in different time zones, hour is correctly kept:
    -Backed out changeset bd7c690a637aabb8469e33a356d7fb74177aa33d
    -Take into account time zone in OBTimeItem if it is sent in the string

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0043836)
hudsonbot (developer)
2011-12-13 16:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test
(0043843)
hudsonbot (developer)
2011-12-13 16:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test
(0043844)
hudsonbot (developer)
2011-12-13 16:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test
(0043845)
hudsonbot (developer)
2011-12-13 16:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test
(0043864)
hudsonbot (developer)
2011-12-14 10:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8dbb94fbbb00 [^]

Maturity status: Test
(0043874)
marvintm (developer)
2011-12-14 12:51

 Now it works even when the client and server are in different timezones
(0044469)
RenateNieuwkoop (reporter)
2012-01-20 13:10

 Please make sure to test the scenarios that are described in issue 19366 also

- Issue History
Date Modified Username Field Change
2011-09-20 08:06 roklenardic New Issue
2011-09-20 08:06 roklenardic Assigned To => jonalegriaesarte
2011-09-20 08:06 roklenardic Web browser => Google Chrome
2011-09-20 08:06 roklenardic Modules => Core
2011-10-31 16:51 VictorVillar Web browser Google Chrome => Google Chrome
2011-10-31 16:51 VictorVillar Resolution time => 1323039600
2011-10-31 16:51 VictorVillar Priority normal => urgent
2011-10-31 16:51 VictorVillar Severity minor => major
2011-10-31 16:51 VictorVillar version pi => 3.0MP4.1
2011-10-31 16:51 VictorVillar Target Version => 3.0MP6
2011-11-15 15:10 jonalegriaesarte Assigned To jonalegriaesarte => alostale
2011-11-15 16:56 alostale Relationship added related to 0018484
2011-11-24 11:28 alostale File Added: time.tgz
2011-11-24 11:42 alostale Note Added: 0043147
2011-11-24 11:42 alostale Web browser Google Chrome => Google Chrome
2011-11-24 11:42 alostale Target Version 3.0MP6 => 3.0MP7
2011-11-24 11:49 alostale File Added: issue-18561.export
2011-11-24 11:51 alostale Note Added: 0043148
2011-11-24 11:53 alostale Note Added: 0043149
2011-12-12 08:31 hgbot Checkin
2011-12-12 08:31 hgbot Note Added: 0043769
2011-12-12 08:31 hgbot Status new => resolved
2011-12-12 08:31 hgbot Resolution open => fixed
2011-12-12 08:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/54a304b3a7ab26c18b4eef13cf657f99668e5bc6 [^]
2011-12-12 11:19 mtaal Note Added: 0043786
2011-12-12 11:19 mtaal Status resolved => new
2011-12-12 11:19 mtaal Resolution fixed => open
2011-12-12 11:34 hgbot Checkin
2011-12-12 11:34 hgbot Note Added: 0043790
2011-12-12 11:34 hgbot Status new => resolved
2011-12-12 11:34 hgbot Resolution open => fixed
2011-12-12 11:34 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/54a304b3a7ab26c18b4eef13cf657f99668e5bc6 [^] => http://code.openbravo.com/erp/devel/pi/rev/45ff7d718f068d025dc75b25b3807de2f03a4376 [^]
2011-12-12 11:50 mtaal Assigned To alostale => mtaal
2011-12-12 11:50 mtaal Note Added: 0043791
2011-12-12 11:50 mtaal Status resolved => new
2011-12-12 11:50 mtaal Resolution fixed => open
2011-12-12 11:50 mtaal Relationship added related to 0016014
2011-12-12 11:50 mtaal Note Added: 0043792
2011-12-12 11:53 hgbot Checkin
2011-12-12 11:53 hgbot Note Added: 0043793
2011-12-12 11:53 hgbot Status new => resolved
2011-12-12 11:53 hgbot Resolution open => fixed
2011-12-12 11:53 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/45ff7d718f068d025dc75b25b3807de2f03a4376 [^] => http://code.openbravo.com/erp/devel/pi/rev/bd7c690a637aabb8469e33a356d7fb74177aa33d [^]
2011-12-12 12:02 hgbot Checkin
2011-12-12 12:02 hgbot Note Added: 0043795
2011-12-12 16:31 marvintm Assigned To mtaal => alostale
2011-12-12 16:31 marvintm Note Added: 0043804
2011-12-12 16:31 marvintm Status resolved => new
2011-12-12 16:31 marvintm Resolution fixed => open
2011-12-12 16:36 mtaal Assigned To alostale => mtaal
2011-12-12 16:38 mtaal Assigned To mtaal => alostale
2011-12-13 10:32 hgbot Checkin
2011-12-13 10:32 hgbot Note Added: 0043813
2011-12-13 10:32 hgbot Status new => resolved
2011-12-13 10:32 hgbot Resolution open => fixed
2011-12-13 10:32 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/bd7c690a637aabb8469e33a356d7fb74177aa33d [^] => http://code.openbravo.com/erp/devel/pi/rev/067d0992e67d8907efbcb7c2e1ae24a2dd52c3cd [^]
2011-12-13 16:43 hudsonbot Checkin
2011-12-13 16:43 hudsonbot Note Added: 0043836
2011-12-13 16:43 hudsonbot Checkin
2011-12-13 16:43 hudsonbot Note Added: 0043843
2011-12-13 16:44 hudsonbot Checkin
2011-12-13 16:44 hudsonbot Note Added: 0043844
2011-12-13 16:44 hudsonbot Checkin
2011-12-13 16:44 hudsonbot Note Added: 0043845
2011-12-14 10:44 hudsonbot Checkin
2011-12-14 10:44 hudsonbot Note Added: 0043864
2011-12-14 12:51 marvintm Note Added: 0043874
2011-12-14 12:51 marvintm Status resolved => closed
2012-01-20 12:38 alostale Relationship added related to 0019366
2012-01-20 13:10 RenateNieuwkoop Note Added: 0044469
2012-01-20 13:11 RenateNieuwkoop Issue Monitored: RenateNieuwkoop
2012-01-27 11:12 marvintm Relationship added has duplicate 0018257
2012-06-06 10:23 alostale Relationship added related to 0020684

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker