Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0018288
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] B. User interfacemajoralways2011-08-16 17:382012-09-16 20:09
ReporterdbazView Statuspublic 
Assigned Todbaz 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision5aa53d4ad683
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0018288: [RTL] Navigation bar is rendered wrong

DescriptionNavigation bar is rendered wrong (see attached screenshot).
It should be rendered similar to LTR one but reflected.
Steps To ReproduceTo set default (English (USA)) language as RTL:

As "System Administrator" go to "Language" window
Select "English (USA)" (in "Name" column)
Activate "RTL Language" checkbox
Save
Log-off
Log-in

After that, you can take advantage of Keyboard Shortcuts to open menu options if the interface is not usable

https://docs.google.com/spreadsheet/ccc?authkey=CPjuiJsF&key=0AscCzhu_uHnCdFlJSkMxQTRoNHdYUE1PNDBYRDY1YUE&hl=en&authkey=CPjuiJsF#gid=0 [^]
TagsNo tags attached.
Attached Filespng file icon Navigation Bar.png [^] (8,057 bytes) 2011-08-16 17:38


png file icon SmartClient_SC_SNAPSHOT-2012-03-06_v83d_LGPL.png [^] (49,839 bytes) 2012-03-07 15:01

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0018286 closeddbaz [RTL] Login screenshot is rendered wrong 
related to design defect 0018287 closeddbaz [RTL] Workspace parts are not flipped 
related to defect 0018294 closeddbaz [RTL] A mechanism to load rtl style files is needed 
related to design defect 0018293 closeddbaz [RTL] Dialogs are rendered wrong 
related to design defect 0018292 closeddbaz [RTL] Form personalization window is rendered wrong 
related to design defect 0018291 closeddbaz [RTL] Form is rendered wrong 
related to design defect 0018290 closeddbaz [RTL] Grid is rendered wrong 
related to defect 0018289 closeddbaz [RTL] Tab bar is rendered wrong 
related to defect 0018308 closeddbaz [RTL] Status bar is rendered wrong 
related to defect 0018318 closeddbaz [RTL] Classic windows are rendered wrong 

-  Notes
(0046133)
dbaz (developer)
2012-03-07 15:01
edited on: 2012-03-07 15:28

 With "SmartClient_SC_SNAPSHOT-2012-03-06_v83d_LGPL" there is a huge improvement, but still some things fail:

* Logos shouldn't be just after the buttons but in the other side
* "Quick Launch" and "Quick Create" buttons should be flipped
* Opened menus doesn't have left border
* Application Menu separation line is in the right (it should be sepparating the text and the arrow)
* The "Application Menu" arrow is inverted
* The "Application Menu" third sub-level tree, is opened to the right instead to the left.
* Alerts parentheses () are not well placed. Just the text should be reviewed to manage the "(" position.
* Profile flyout has some alignments problems

Attached "SmartClient_SC_SNAPSHOT-2012-03-06_v83d_LGPL.png"
(0046634)
dbaz (developer)
2012-03-21 22:07
edited on: 2012-04-03 20:32

 Most of the issues resolved, by the moment, in branch pi-rtl

https://code.openbravo.com/erp/devel/pi-rtl/rev/5aa53d4ad683 [^]
https://code.openbravo.com/erp/devel/pi-rtl/rev/da3c5f9329d6 [^]
https://code.openbravo.com/erp/devel/pi-rtl/rev/49e1f2f9cbc1 [^]

The code-review can be already done, but the issue closure once pi-rtl be merged with pi (estimated by MP12)
(0046635)
dbaz (developer)
2012-03-21 22:11

 Remaining thigs (with "SmartClient_SC_SNAPSHOT-2012-03-20_v83d_LGPL"):
* The "Application Menu" third sub-level tree, is opened to the right instead to the left.
* Buttons in "User Options" ("Profile" and "Change password") are not centered
* IE9: 1px movement when hover a menu item
* IE9: "Application Menu" items are not shown until the sub-menu is hovered.
(0048259)
hgbot (developer)
2012-05-02 22:02

 Repository: erp/devel/pi
Changeset: 5aa53d4ad6836b9b72a70f78dd3659a8c0e85e81
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Mar 21 22:06:47 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5aa53d4ad6836b9b72a70f78dd3659a8c0e85e81 [^]

Fixed issue 18288: Adapted navigation bar to [RTL] mode

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/layout.js.ftl
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quickrun-widget.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-user-profile-widget.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-application-menu-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-application-menu-styles.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-navigation-bar-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-navigation-bar-styles.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-rtl-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-rtl-styles.js
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/menuSeparator-RTL.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/subMenu-RTL.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/subMenu-RTL_Disabled.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/subMenu.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/subMenu_Disabled.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/navbar/iconClose-RTL.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/navbar/iconCreateNew-RTL.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/navbar/iconQuickLaunch-RTL.png
---
(0048260)
hgbot (developer)
2012-05-02 22:02

 Repository: erp/devel/pi
Changeset: da3c5f9329d67ea107c6d2f2bc89dce85ceb8e4d
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Mar 21 23:39:47 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/da3c5f9329d67ea107c6d2f2bc89dce85ceb8e4d [^]

Related to issue 18288: [RTL] Improved CSS code to help skin modules

---
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-application-menu-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-application-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-navigation-bar-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-rtl-styles.css
---
(0048263)
hgbot (developer)
2012-05-02 22:04

 Repository: erp/devel/pi
Changeset: 49e1f2f9cbc162c2a5753bc2ce006e7f99c40131
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Apr 03 20:32:24 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/49e1f2f9cbc162c2a5753bc2ce006e7f99c40131 [^]

Related to issue 18288: Application menu now opens to the left in [RTL] mode

---
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-rtl-styles.js
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-rtl-styles.js
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/subMenu_Disabled_left.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/subMenu_left.png
R modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/subMenu-RTL.png
R modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/application-menu/subMenu-RTL_Disabled.png
---
(0048853)
guilleaer (developer)
2012-05-22 12:36

 verified in pi@87340d8f38a3
(0048953)
hudsonbot (developer)
2012-05-25 12:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0048954)
hudsonbot (developer)
2012-05-25 12:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0048957)
hudsonbot (developer)
2012-05-25 12:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049293)
guilleaer (developer)
2012-05-28 08:47

 Changing Fixed in Version to 3.0MP12
(0049294)
guilleaer (developer)
2012-05-28 08:48

 Changing Fixed in Version to 3.0MP12
(0049295)
guilleaer (developer)
2012-05-28 08:48

 Changing Fixed in Version to 3.0MP12
(0049296)
guilleaer (developer)
2012-05-28 08:48

 Changing Fixed in Version to 3.0MP12

- Issue History
Date Modified Username Field Change
2011-08-16 17:38 dbaz New Issue
2011-08-16 17:38 dbaz Assigned To => dbaz
2011-08-16 17:38 dbaz File Added: Navigation Bar.png
2011-08-16 17:38 dbaz Modules => Core
2011-08-16 18:12 dbaz Relationship added related to 0018286
2011-08-16 18:13 dbaz Relationship added related to 0018287
2011-08-16 18:13 dbaz Relationship added blocks 0018294
2011-08-16 18:14 dbaz Relationship deleted blocks 0018294
2011-08-16 18:14 dbaz Relationship added related to 0018294
2011-08-16 18:14 dbaz Relationship added related to 0018293
2011-08-16 18:14 dbaz Relationship added related to 0018292
2011-08-16 18:14 dbaz Relationship added related to 0018291
2011-08-16 18:14 dbaz Relationship added related to 0018290
2011-08-16 18:14 dbaz Relationship added related to 0018289
2011-08-17 15:20 dbaz Relationship added related to 0018308
2011-08-19 01:47 dbaz Relationship added related to 0018318
2012-03-07 15:01 dbaz Note Added: 0046133
2012-03-07 15:01 dbaz File Added: SmartClient_SC_SNAPSHOT-2012-03-06_v83d_LGPL.png
2012-03-07 15:24 dbaz Note Edited: 0046133 View Revisions
2012-03-07 15:28 dbaz Note Edited: 0046133 View Revisions
2012-03-15 16:30 dbaz Type defect => design defect
2012-03-21 22:07 dbaz Note Added: 0046634
2012-03-21 22:11 dbaz Note Added: 0046635
2012-03-21 23:40 dbaz Note Edited: 0046634 View Revisions
2012-04-03 20:32 dbaz Note Edited: 0046634 View Revisions
2012-05-02 22:02 hgbot Checkin
2012-05-02 22:02 hgbot Note Added: 0048259
2012-05-02 22:02 hgbot Status new => resolved
2012-05-02 22:02 hgbot Resolution open => fixed
2012-05-02 22:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5aa53d4ad6836b9b72a70f78dd3659a8c0e85e81 [^]
2012-05-02 22:02 hgbot Checkin
2012-05-02 22:02 hgbot Note Added: 0048260
2012-05-02 22:04 hgbot Checkin
2012-05-02 22:04 hgbot Note Added: 0048263
2012-05-22 12:36 guilleaer Note Added: 0048853
2012-05-22 12:36 guilleaer Status resolved => closed
2012-05-22 12:36 guilleaer Fixed in Version => pi
2012-05-25 12:07 hudsonbot Checkin
2012-05-25 12:07 hudsonbot Note Added: 0048953
2012-05-25 12:07 hudsonbot Checkin
2012-05-25 12:07 hudsonbot Note Added: 0048954
2012-05-25 12:07 hudsonbot Checkin
2012-05-25 12:07 hudsonbot Note Added: 0048957
2012-05-28 08:47 guilleaer Assigned To dbaz => guilleaer
2012-05-28 08:47 guilleaer Note Added: 0049293
2012-05-28 08:47 guilleaer Status closed => new
2012-05-28 08:47 guilleaer Resolution fixed => open
2012-05-28 08:47 guilleaer Fixed in Version pi =>
2012-05-28 08:48 guilleaer Status new => scheduled
2012-05-28 08:48 guilleaer Note Added: 0049294
2012-05-28 08:48 guilleaer fix_in_branch => pi
2012-05-28 08:48 guilleaer Note Added: 0049295
2012-05-28 08:48 guilleaer Status scheduled => resolved
2012-05-28 08:48 guilleaer Fixed in Version => 3.0MP12
2012-05-28 08:48 guilleaer Resolution open => fixed
2012-05-28 08:48 guilleaer Note Added: 0049296
2012-05-28 08:48 guilleaer Status resolved => closed
2012-09-16 20:08 guilleaer Assigned To guilleaer => dbaz
2012-09-16 20:08 guilleaer Status closed => new
2012-09-16 20:08 guilleaer Resolution fixed => open
2012-09-16 20:08 guilleaer Fixed in Version 3.0MP12 =>
2012-09-16 20:08 guilleaer Status new => scheduled
2012-09-16 20:09 guilleaer Status scheduled => resolved
2012-09-16 20:09 guilleaer Resolution open => fixed
2012-09-16 20:09 guilleaer Closed by => guilleaer
2012-09-16 20:09 guilleaer Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker