0018023: Not possible to enter a G/L Journal line using comma as decimal separator

Description

It is not possible to create a new G/L Journal Line using comma as decimal separator. (see attached screenshot)

The following callout is preventing the tab to be loaded properly:
SL_JournalLineAmt

Caused by: java.lang.NumberFormatException
    at java.math.BigDecimal.<init>(BigDecimal.java:470)
    at java.math.BigDecimal.<init>(BigDecimal.java:739)
    at org.openbravo.erpCommon.ad_callouts.SL_JournalLineAmt.printPage(SL_JournalLineAmt.java:98)
    at org.openbravo.erpCommon.ad_callouts.SL_JournalLineAmt.doPost(SL_JournalLineAmt.java:65)

Steps To Reproduce

1) Configure comma as decimal separator.
2) Create a new G/L Journal Batch
3) Create a new G/L Journal Header
4) Try to create a new G/L Journal Line

Proposed Solution

Use getNumericParameter instead of getStringParameter

Line 55
String strCurrencyRate = vars.getStringParameter("inpcurrencyrate", "1");

Tags

No tags attached.

Attached Files

GL Journal Line - comma as decimal separator.png [^] (28,538 bytes) 2011-07-18 17:29

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

0018024

closed

mirurita

Not possible to enter a G/L Journal line using comma as decimal separator

Notes
(0039192) hgbot (developer) 2011-07-18 18:37	Repository: erp/devel/pi Changeset: e751530b18c0418fb3d6beaa5963649f037eef2a Author: Mikel Irurita <mikel.irurita <at> openbravo.com> Date: Mon Jul 18 18:36:56 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e751530b18c0418fb3d6beaa5963649f037eef2a [^] Fixes issue 18023: Not possible to enter a G/L Journal line using comma as decimal separator --- M src/org/openbravo/erpCommon/ad_callouts/SL_JournalLineAmt.java ---

(0039618) hudsonbot (viewer) 2011-08-01 14:20	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2011-07-18 17:29	mirurita	New Issue
2011-07-18 17:29	mirurita	Assigned To	=> mirurita
2011-07-18 17:29	mirurita	File Added: GL Journal Line - comma as decimal separator.png
2011-07-18 17:29	mirurita	Modules	=> Core
2011-07-18 17:29	mirurita	OBNetwork customer	=> No
2011-07-18 18:36	mirurita	Status	new => scheduled
2011-07-18 18:36	mirurita	fix_in_branch	=> pi
2011-07-18 18:37	hgbot	Checkin
2011-07-18 18:37	hgbot	Note Added: 0039192
2011-07-18 18:37	hgbot	Status	scheduled => resolved
2011-07-18 18:37	hgbot	Resolution	open => fixed
2011-07-18 18:37	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/e751530b18c0418fb3d6beaa5963649f037eef2a [^]
2011-08-01 14:20	hudsonbot	Checkin
2011-08-01 14:20	hudsonbot	Note Added: 0039618
2011-08-12 13:43	gorkaion	Status	resolved => closed
2011-08-12 13:43	gorkaion	Fixed in Version	=> 3.0MP2