0017800: the lists are not ordered by field "sequence"

(0038589)
mtaal (manager)
2011-06-29 15:21
edited on: 2011-06-29 15:21

See this bug:
http://code.google.com/p/v8/issues/detail?id=164 [^]

When testing this html in chrome and ff:
<html>
<script>
var obj = {
  "first":"first",
  "2":"2",
  "34":"34",
  "1":"1",
  "second":"second"
};
for (var i in obj) { console.log(i); };</script>
</html>

In chrome you get the wrong order:
1
2
34
first
second

In ff 5 we get the order:
[15:20:09.797] second
[15:20:09.793] first
[15:20:09.794] 2
[15:20:09.795] 34
[15:20:09.796] 1

(0038590)
mtaal (manager)
2011-06-29 15:24

Changing to an array, gives the correct ordering in FF, but the wrong order in chrome:
<html>
<script>
var obj = [];
obj["first"] = "first";
obj["2"] = "2";
obj["34"] = "34";
obj["1"] = "1";
obj["second"] = "second";
for (var i in obj) { console.log(i); };</script>
</html>
Chrome:
1
2
34
first
second

FF:
[15:23:13.874] first
[15:23:13.876] 2
[15:23:13.877] 34
[15:23:13.878] 1
[15:23:13.879] second

(0038591)
mtaal (manager)
2011-06-29 15:25

This slightly different script gives the same result:
<html>
<script>
var obj = {};
obj["first"] = "first";
obj["2"] = "2";
obj["34"] = "34";
obj["1"] = "1";
obj["second"] = "second";
for (var i in obj) { console.log(i); };</script>
</html>

(0038593)
mtaal (manager)
2011-06-29 15:29

(0038596)
hgbot (developer)
2011-06-29 16:42

Repository: erp/devel/pi
Changeset: a0d98e07106abbd575b334604276e76209cc1050
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 29 16:41:57 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a0d98e07106abbd575b334604276e76209cc1050 [^]

Fixes issue 17800: the lists are not ordered by field "sequence"
Order of combobox items was not maintained, added new data entry array in form item list

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---

(0038660)
malsasua (developer)
2011-07-01 08:30

tested: it works fine

(0038699)
hgbot (developer)
2011-07-01 23:19

Repository: erp/devel/pi
Changeset: 653b385f9a757c847296ea5cd16f593e4b8d7a11
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Jul 01 23:19:19 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/653b385f9a757c847296ea5cd16f593e4b8d7a11 [^]

Related to issue 17800: the lists are not ordered by field "sequence"

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---

(0038824)
hudsonbot (developer)
2011-07-06 02:41

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test

(0038860)
hudsonbot (developer)
2011-07-06 02:42

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2011-06-28 09:34	malsasua	New Issue
2011-06-28 09:34	malsasua	Assigned To	=> alostale
2011-06-28 09:34	malsasua	Modules	=> Core
2011-06-28 15:40	malsasua	Target Version	3.0MP2 => 3.0MP1
2011-06-28 16:54	alostale	Status	new => scheduled
2011-06-28 16:54	alostale	fix_in_branch	=> pi
2011-06-29 13:07	alostale	Relationship added	has duplicate 0016424
2011-06-29 13:07	alostale	Assigned To	alostale => mtaal
2011-06-29 15:21	mtaal	Note Added: 0038589
2011-06-29 15:21	mtaal	Note Edited: 0038589	View Revisions
2011-06-29 15:24	mtaal	Note Added: 0038590
2011-06-29 15:25	mtaal	Note Added: 0038591
2011-06-29 15:29	mtaal	Note Added: 0038593
2011-06-29 16:42	hgbot	Checkin
2011-06-29 16:42	hgbot	Note Added: 0038596
2011-06-29 16:42	hgbot	Status	scheduled => resolved
2011-06-29 16:42	hgbot	Resolution	open => fixed
2011-06-29 16:42	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/a0d98e07106abbd575b334604276e76209cc1050 [^]
2011-07-01 08:30	malsasua	Note Added: 0038660
2011-07-01 08:30	malsasua	Status	resolved => closed
2011-07-01 08:30	malsasua	Fixed in Version	=> 3.0MP1
2011-07-01 23:19	hgbot	Checkin
2011-07-01 23:19	hgbot	Note Added: 0038699
2011-07-06 02:41	hudsonbot	Checkin
2011-07-06 02:41	hudsonbot	Note Added: 0038824
2011-07-06 02:42	hudsonbot	Checkin
2011-07-06 02:42	hudsonbot	Note Added: 0038860
2012-03-20 17:38	dbaz	Relationship added	related to 0020067

Notes
(0038589) mtaal (manager) 2011-06-29 15:21 edited on: 2011-06-29 15:21	See this bug: http://code.google.com/p/v8/issues/detail?id=164 [^] When testing this html in chrome and ff: <html> <script> var obj = { "first":"first", "2":"2", "34":"34", "1":"1", "second":"second" }; for (var i in obj) { console.log(i); };</script> </html> In chrome you get the wrong order: 1 2 34 first second In ff 5 we get the order: [15:20:09.797] second [15:20:09.793] first [15:20:09.794] 2 [15:20:09.795] 34 [15:20:09.796] 1

(0038590) mtaal (manager) 2011-06-29 15:24	Changing to an array, gives the correct ordering in FF, but the wrong order in chrome: <html> <script> var obj = []; obj["first"] = "first"; obj["2"] = "2"; obj["34"] = "34"; obj["1"] = "1"; obj["second"] = "second"; for (var i in obj) { console.log(i); };</script> </html> Chrome: 1 2 34 first second FF: [15:23:13.874] first [15:23:13.876] 2 [15:23:13.877] 34 [15:23:13.878] 1 [15:23:13.879] second

(0038591) mtaal (manager) 2011-06-29 15:25	This slightly different script gives the same result: <html> <script> var obj = {}; obj["first"] = "first"; obj["2"] = "2"; obj["34"] = "34"; obj["1"] = "1"; obj["second"] = "second"; for (var i in obj) { console.log(i); };</script> </html>

(0038593) mtaal (manager) 2011-06-29 15:29	See also these links: http://forums.smartclient.com/showthread.php?t=8325&highlight=valuemap+sort [^] http://code.google.com/p/chromium/issues/detail?id=20144 [^]

(0038596) hgbot (developer) 2011-06-29 16:42	Repository: erp/devel/pi Changeset: a0d98e07106abbd575b334604276e76209cc1050 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Jun 29 16:41:57 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/a0d98e07106abbd575b334604276e76209cc1050 [^] Fixes issue 17800: the lists are not ordered by field "sequence" Order of combobox items was not maintained, added new data entry array in form item list --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js ---

(0038660) malsasua (developer) 2011-07-01 08:30	tested: it works fine

(0038699) hgbot (developer) 2011-07-01 23:19	Repository: erp/devel/pi Changeset: 653b385f9a757c847296ea5cd16f593e4b8d7a11 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Fri Jul 01 23:19:19 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/653b385f9a757c847296ea5cd16f593e4b8d7a11 [^] Related to issue 17800: the lists are not ordered by field "sequence" --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js ---

(0038824) hudsonbot (developer) 2011-07-06 02:41	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^] Maturity status: Test

(0038860) hudsonbot (developer) 2011-07-06 02:42	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^] Maturity status: Test