Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0017611
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2011-06-12 08:492011-10-23 13:41
ReporterrgorisView Statuspublic 
Assigned Todbaz 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiond8d33141ff30
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0017611: Styling issue for Alerts

DescriptionSee image, checkbox looks funny
Steps To ReproduceSelect the first item in New. Unselect that same item again. Checkbox changes height now.
TagsNo tags attached.
Attached Filespng file icon AlertsStyling.PNG [^] (38,761 bytes) 2011-06-12 08:49

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0041879)
hgbot (developer)
2011-10-18 16:58

Repository: erp/devel/pi
Changeset: d8d33141ff3053d45b3cff1fd7f917efb78296d1
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Oct 18 16:57:21 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d8d33141ff3053d45b3cff1fd7f917efb78296d1 [^]

Fixed issue 17611: Removed frozen checkbox-column to avoid strange height changes

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
---
(0041997)
mtaal (manager)
2011-10-23 09:47

I am upgrading to the latest smartclient version (22-10), and there this issue seems to be solved.

Can you retry/retest on live.builds after this evening/night Rob?

gr. Martin
(0041998)
mtaal (manager)
2011-10-23 09:48

Eventhough it seems solved, for the record here is how to reproduce it in the smartclient feature explorer:
http://www.smartclient.com/#_Grids_Data.types_Text [^]

isc.ListGrid.create({
    ID: "countryList",
    cellHeight: 30,
    width:500, height:224, alternateRecordStyles:true,
    canEdit:true, editEvent:"click", modalEditing:true,
    data: countryData,
    selectionAppearance:"checkbox",
    initWidget: function() {
      this.checkboxFieldDefaults = isc.addProperties(this.checkboxFieldDefaults, {
          frozen: true
      });
      this.Super('initWidget', arguments);
    },
    fields:[
        {name:"countryName", title:"Country"},
        {name:"capital", title:"Capital"},
        {name:"continent", title:"Continent"}
    ]
})
(0042001)
dbaz (developer)
2011-10-23 13:25

Right now it works ok because I removed the frozen attribute of the checkbox column

https://code.openbravo.com/erp/devel/pi/file/6cb329cf1dad/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js#l108 [^]

But the issue is still not fixed even with this SC upgrade. If you put again the frozen attribute (needed to ensure checkbox column is always visible in the beginning of the grid), it still fails.

I removed the attribute as a TEMPORARY fix, because is better to have the checkbox not frozen instead of the ugly effect when checking.
(0042012)
hudsonbot (developer)
2011-10-23 13:41

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/35bf0a7aa166 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-06-12 08:49 rgoris New Issue
2011-06-12 08:49 rgoris Assigned To => alostale
2011-06-12 08:49 rgoris File Added: AlertsStyling.PNG
2011-06-12 08:49 rgoris Modules => Core
2011-06-22 19:26 dmitry_mezentsev Target Version 3.0MP1 => 3.0MP2
2011-06-22 20:29 dmitry_mezentsev Target Version 3.0MP2 => 3.0MP3
2011-06-27 11:38 rgoris Assigned To alostale => gorkaion
2011-06-27 11:38 rgoris Status new => scheduled
2011-06-27 11:38 rgoris Target Version 3.0MP3 => 3.0MP2
2011-07-12 10:05 gorkaion Assigned To gorkaion => iperdomo
2011-07-13 12:46 iperdomo Assigned To iperdomo => dbaz
2011-07-20 12:31 dbaz Target Version 3.0MP2 => 3.0MP3
2011-08-31 13:50 dbaz Target Version 3.0MP3 =>
2011-10-18 16:58 hgbot Checkin
2011-10-18 16:58 hgbot Note Added: 0041879
2011-10-18 16:58 hgbot Status scheduled => resolved
2011-10-18 16:58 hgbot Resolution open => fixed
2011-10-18 16:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d8d33141ff3053d45b3cff1fd7f917efb78296d1 [^]
2011-10-19 08:07 rgoris Status resolved => closed
2011-10-23 09:47 mtaal Note Added: 0041997
2011-10-23 09:48 mtaal Note Added: 0041998
2011-10-23 13:25 dbaz Note Added: 0042001
2011-10-23 13:41 hudsonbot Checkin
2011-10-23 13:41 hudsonbot Note Added: 0042012


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker