Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0017207 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 08. Project and service management | major | always | 2011-05-17 16:53 | 2011-06-01 20:24 | |||
| Reporter | xabiermerino | View Status | public | |||||
| Assigned To | adrianromero | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0MP0 | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 145fea0f4502 | |||
| Projection | none | ETA | none | Target Version | 3.0MP0 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 3.0RC6.1 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0017207: It is not possible save a Project Line with Planned Price = 0 | |||||||
| Description | It is not possible save a Project Line with Planned Price = 0. This error appears: ERROR: division by zero In several cases products with price 0 are used. | |||||||
| Steps To Reproduce | - As Openbravo Admin go to Project & Service Management || Transactions || Service Project || Service Project >> Project Line - Create a line with Planned Price = 0 - Save | |||||||
| Proposed Solution | In Trigger C_projectline_trg3: v_oldLine_PlannedMarginAmt:=COALESCE((COALESCE(old.PLANNEDPRICE,0)-COALESCE(old.PLANNEDPOPRICE,0))*100/COALESCE(old.PLANNEDPRICE,1),0); --> "IF (COALESCE(old.PLANNEDPRICE,0) <> 0) THEN v_oldLine_PlannedMarginAmt:=COALESCE((COALESCE(old.PLANNEDPRICE,0)-COALESCE(old.PLANNEDPOPRICE,0))*100/old.PLANNEDPRICE,0); END IF;" v_newLine_PlannedMarginAmt:=COALESCE((COALESCE(new.PLANNEDPRICE,0)-COALESCE(new.PLANNEDPOPRICE,0))*100/COALESCE(new.PLANNEDPRICE,1),0); --> IF (COALESCE(new.PLANNEDPRICE,0) <> 0) THEN v_newLine_PlannedMarginAmt:=COALESCE((COALESCE(new.PLANNEDPRICE,0)-COALESCE(new.PLANNEDPOPRICE,0))*100/new.PLANNEDPRICE,0); END IF; | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0037667) hgbot (developer) 2011-05-27 14:20 |
Repository: erp/devel/pi Changeset: 145fea0f45020f8605f410675ba77372d1ff3862 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Fri May 27 14:20:14 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/145fea0f45020f8605f410675ba77372d1ff3862 [^] Fixes issue 0017207: It is not possible save a Project Line with Planned Price = 0 It has been modified the related triggers in order to verify that if planned price is zero, calculate properly related values --- M src-db/database/model/triggers/C_PROJECTLINE_TRG.xml M src-db/database/model/triggers/C_PROJECTLINE_TRG3.xml --- |
|
(0037668) adrianromero (manager) 2011-05-27 14:25 |
* Testing the issue Follow carefully the steps to test and verify that the project line can be saved when planned price is 0 too. Because it has been modified triggers in the project lines table, it must be verfied also that records can be inserted, updated and deleted. Also all actions must be tested in both database engines: postgresql and oracle. Take into account that in 3.0 the application must be activated to show the Project & Service functionality. * Other areas affected. No other areas affected. Only the triggers of project lines has been modified. |
|
(0037785) hudsonbot (developer) 2011-05-31 09:44 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ea275e03a164 [^] Maturity status: Test |
|
(0037896) jonalegriaesarte (reporter) 2011-06-01 20:24 |
Verified |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-05-17 16:53 | xabiermerino | New Issue | |
| 2011-05-17 16:53 | xabiermerino | Assigned To | => adrianromero |
| 2011-05-17 16:53 | xabiermerino | Modules | => Core |
| 2011-05-17 16:53 | xabiermerino | Status | new => scheduled |
| 2011-05-17 16:53 | xabiermerino | fix_in_branch | => pi |
| 2011-05-17 17:46 | xabiermerino | Issue Monitored: networkb | |
| 2011-05-27 14:20 | hgbot | Checkin | |
| 2011-05-27 14:20 | hgbot | Note Added: 0037667 | |
| 2011-05-27 14:20 | hgbot | Status | scheduled => resolved |
| 2011-05-27 14:20 | hgbot | Resolution | open => fixed |
| 2011-05-27 14:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/145fea0f45020f8605f410675ba77372d1ff3862 [^] |
| 2011-05-27 14:25 | adrianromero | Note Added: 0037668 | |
| 2011-05-31 09:44 | hudsonbot | Checkin | |
| 2011-05-31 09:44 | hudsonbot | Note Added: 0037785 | |
| 2011-06-01 20:24 | jonalegriaesarte | Note Added: 0037896 | |
| 2011-06-01 20:24 | jonalegriaesarte | Status | resolved => closed |
| 2011-06-01 20:24 | jonalegriaesarte | Fixed in Version | => 3.0MP0 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |