Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0017176

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

have not tried

2011-05-16 13:34

2011-09-02 20:13

Reporter

shuehner

View Status

public

Assigned To

marvintm

Priority

normal

Resolution

fixed

Fixed in Version

3.0MP3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0MP3

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Web browser

Modules

User Interface Application

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0017176: MenuData.linkForms uses hql left join which now changed behavior but could just use normal join instead

Description

The hql-query in that function is affected by the hibernate library update which changes the sql-executed for it

However checking the query the use of left-join is not needed as the join fields are all marked as not-null so behave like a normal join.

Attached patch changes the query do do a normal join to simplify it and make that more obvious.

Tags

No tags attached.

17176.diff [^] (1,175 bytes) 2011-05-16 13:35 [Show Content] [Hide Content]

diff -r 0669ff6199ea modules/org.openbravo.client.application/src/org/openbravo/client/application/MenuManager.java
--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/MenuManager.java	Mon May 16 11:46:45 2011 +0200
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/MenuManager.java	Mon May 16 13:18:35 2011 +0200
@@ -277,8 +277,8 @@
   @SuppressWarnings("unchecked")
   private void linkWindows() {
     // collect the valid tabs/windows
-    final String tabsHql = "select t from ADTab t left join fetch t.window left join fetch t.table, ADWindowAccess awa "
-        + "where awa.role.id=:roleId and t.active = true and t.window.active = true and t.window = awa.window and t.tabLevel = 0";
+    final String tabsHql = "select t from ADTab t join fetch t.window w join fetch t.table, ADWindowAccess awa "
+        + "where awa.role.id=:roleId and t.active = true and w.active = true and w = awa.window and t.tabLevel = 0";
     final Query tabsQry = OBDal.getInstance().getSession().createQuery(tabsHql);
     tabsQry.setParameter("roleId", OBContext.getOBContext().getRole().getId());
     // force a load

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0040684) hgbot (developer) 2011-09-01 16:48	Repository: erp/devel/pi Changeset: aec4c4f24da5f041f2205d3b27ddf530d9d73009 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Sep 01 16:47:28 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/aec4c4f24da5f041f2205d3b27ddf530d9d73009 [^] Fixed issue 17176. Removed unnecesary left keyword. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/MenuManager.java ---

(0040703) mtaal (manager) 2011-09-02 10:14	Works

(0040733) hudsonbot (developer) 2011-09-02 20:13	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1065162150e [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2011-05-16 13:34	shuehner	New Issue
2011-05-16 13:34	shuehner	Assigned To	=> shuehner
2011-05-16 13:34	shuehner	Modules	=> User Interface Application
2011-05-16 13:35	shuehner	File Added: 17176.diff
2011-05-23 08:08	alostale	Status	new => scheduled
2011-06-02 10:53	dmitry_mezentsev	Target Version	3.0MP0 => 3.0MP1
2011-06-22 19:41	dmitry_mezentsev	Target Version	3.0MP1 => 3.0MP3
2011-08-30 17:23	shuehner	Assigned To	shuehner => marvintm
2011-09-01 16:48	hgbot	Checkin
2011-09-01 16:48	hgbot	Note Added: 0040684
2011-09-01 16:48	hgbot	Status	scheduled => resolved
2011-09-01 16:48	hgbot	Resolution	open => fixed
2011-09-01 16:48	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/aec4c4f24da5f041f2205d3b27ddf530d9d73009 [^]
2011-09-02 10:14	mtaal	Note Added: 0040703
2011-09-02 10:14	mtaal	Status	resolved => closed
2011-09-02 10:14	mtaal	Fixed in Version	=> 3.0MP3
2011-09-02 20:13	hudsonbot	Checkin
2011-09-02 20:13	hudsonbot	Note Added: 0040733

Copyright © 2000 - 2009 MantisBT Group