Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0017106
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2011-05-10 19:122011-06-02 09:49
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision38276e5dee09
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0017106: ad_message has lots of similar entries for same error message for various constraints / columns

DescriptionIn ad_message there are lots of similar entries for the following two error types:

- standard boolean constraint (around 200)
- not null constraint (around 1100)

For both cases the ErrorTextParser class can generate a basic error message based on a single template entry, so the many special entries (with the same basic text) are not needed.

Note: The not null messages are currently not parsed at all properly when using pgsql, however this cleanup doesn't not change this state and does not regress on this further.
Proposed SolutionDelete the duplicate entries.
Enable ErrorTextParser.notNull test on oracle only (instead of having it completely disabled)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0017107 closedshuehner try-api/355 fails because of AD_MESSAGE cleanup 

-  Notes
(0036652)
shuehner (administrator)
2011-05-10 19:14

 Note the two sets of deletions were done using the following sql (and quick manual recheck):

a.) delete from ad_message where msgtext like 'Only values ''Y'' or % may be entered%' and ad_module_id = '0';
b.) delete from ad_message where value like '%IS NOT NULL%' and ad_module_id = '0';

After that total ad_message count (for core module) goes down from around 3100 -> 1700
(0036655)
hgbot (developer)
2011-05-10 22:41

 Repository: erp/devel/pi
Changeset: 38276e5dee09264011cf7ff17c08369417e14ad6
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue May 10 19:15:45 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/38276e5dee09264011cf7ff17c08369417e14ad6 [^]

Fixed 17106: Remove many similar error message which are not needed with an
explicit entry but can be handled by the ErrorTextParser code using a single
message template.
Also activate ErrorTextParserTest.notNull testcase at least on oracle (that
functionality is still missing when using postgresql)

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-test/org/openbravo/test/system/ErrorTextParserTest.java
---
(0036880)
hudsonbot (developer)
2011-05-12 13:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-05-10 19:12 shuehner New Issue
2011-05-10 19:12 shuehner Assigned To => shuehner
2011-05-10 19:12 shuehner Modules => Core
2011-05-10 19:14 shuehner Note Added: 0036652
2011-05-10 22:38 shuehner Relationship added related to 0017107
2011-05-10 22:41 hgbot Checkin
2011-05-10 22:41 hgbot Note Added: 0036655
2011-05-10 22:41 hgbot Status new => resolved
2011-05-10 22:41 hgbot Resolution open => fixed
2011-05-10 22:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/38276e5dee09264011cf7ff17c08369417e14ad6 [^]
2011-05-12 13:31 hudsonbot Checkin
2011-05-12 13:31 hudsonbot Note Added: 0036880
2011-06-02 09:49 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker