Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017106Openbravo ERPA. Platformpublic2011-05-10 19:122011-06-02 09:49
Reportershuehner 
Assigned Toshuehner 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017106: ad_message has lots of similar entries for same error message for various constraints / columns
DescriptionIn ad_message there are lots of similar entries for the following two error types:

- standard boolean constraint (around 200)
- not null constraint (around 1100)

For both cases the ErrorTextParser class can generate a basic error message based on a single template entry, so the many special entries (with the same basic text) are not needed.

Note: The not null messages are currently not parsed at all properly when using pgsql, however this cleanup doesn't not change this state and does not regress on this further.
Steps To Reproduce
Proposed SolutionDelete the duplicate entries.
Enable ErrorTextParser.notNull test on oracle only (instead of having it completely disabled)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0017107 closed shuehner try-api/355 fails because of AD_MESSAGE cleanup 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-05-10 19:12shuehnerNew Issue
2011-05-10 19:12shuehnerAssigned To => shuehner
2011-05-10 19:12shuehnerModules => Core
2011-05-10 19:14shuehnerNote Added: 0036652
2011-05-10 22:38shuehnerRelationship addedrelated to 0017107
2011-05-10 22:41hgbotCheckin
2011-05-10 22:41hgbotNote Added: 0036655
2011-05-10 22:41hgbotStatusnew => resolved
2011-05-10 22:41hgbotResolutionopen => fixed
2011-05-10 22:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/38276e5dee09264011cf7ff17c08369417e14ad6 [^]
2011-05-12 13:31hudsonbotCheckin
2011-05-12 13:31hudsonbotNote Added: 0036880
2011-06-02 09:49marvintmStatusresolved => closed

Notes
(0036652)
shuehner   
2011-05-10 19:14   
Note the two sets of deletions were done using the following sql (and quick manual recheck):

a.) delete from ad_message where msgtext like 'Only values ''Y'' or % may be entered%' and ad_module_id = '0';
b.) delete from ad_message where value like '%IS NOT NULL%' and ad_module_id = '0';

After that total ad_message count (for core module) goes down from around 3100 -> 1700
(0036655)
hgbot   
2011-05-10 22:41   
Repository: erp/devel/pi
Changeset: 38276e5dee09264011cf7ff17c08369417e14ad6
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue May 10 19:15:45 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/38276e5dee09264011cf7ff17c08369417e14ad6 [^]

Fixed 17106: Remove many similar error message which are not needed with an
explicit entry but can be handled by the ErrorTextParser code using a single
message template.
Also activate ErrorTextParserTest.notNull testcase at least on oracle (that
functionality is still missing when using postgresql)

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-test/org/openbravo/test/system/ErrorTextParserTest.java
---
(0036880)
hudsonbot   
2011-05-12 13:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test