Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0016786 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | N/A | 2011-04-12 18:11 | 2012-10-10 13:01 | |||
| Reporter | elopio | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP15 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d28bc1767d0a | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | guilleaer | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0016786: Set a name to the iframe that contains the classic window | |||||||
| Description | When a classic view is opened, it is loaded on the frame with name "appFrame". This is a child of a iframe that has no name: <iframe height="100%" frameborder="0" width="100%" scrolling="auto" src="/qa-pi-inc-oracle/security/Menu.html?url=/ad_forms/ModuleManagement.html&noprefs=true&hideMenu=true&Command=DEFAULT" style="height: 242px;"> This makes it difficult for the automated tests to select the classic frame, because there is no reliable way to select the parent iframe. | |||||||
| Steps To Reproduce | Open a classic window, for example Module Management. Inspect the HTML with firebug, searching for the appFrame and its parent iframe. | |||||||
| Proposed Solution | Set a name to the iframe. | |||||||
| Tags | OB3-Reviewed | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0035869) elopio (reporter) 2011-04-12 18:11 |
Priority set to urgent because it is making the smoke test fail often. |
|
(0035883) elopio (reporter) 2011-04-13 08:58 |
On Module Management, the contents of the popups Module Details, Install Module and Rebuild the System are inside a frame called "BUTTON". It is also inside an iframe without name. Please set the name to these iframes too. |
|
(0035965) elopio (reporter) 2011-04-15 09:35 |
The OBClassicPopUps are also inside a frame called "process", whose parent again is an iframe without name. This happens, for example, on the Fiscal Calendar Year Create Periods popup. |
|
(0035967) iperdomo (reporter) 2011-04-15 10:27 |
@elopio: > "because there is no reliable way to select the parent iframe." This is not true. ClassicOBWindow has the API to access the iframe. https://code.openbravo.com/erp/devel/pi/file/5f47e83fbcb3/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-window.js#l135 [^] Why do you need to access the 'parent' iframe? |
|
(0035979) dbaz (developer) 2011-04-15 13:29 |
Two problems here: * The iframe you refeer is the one generated by Smartclient HTMLFlow * A modal popup can open another modal popup... and here if they share the name maybe you have a problem if they share the name... What is always right now is: <frame id="MDIPopupContainer" name="xx"> where name is different depending how is the classic window build... could you access to id="MDIPopupContainer" which is always the same? In case you can't, there is also a <frame id="paramFrameMenuLoading" scrolling="no" src="/pi-statusbar/utility/VerticalMenu.html?Command=HIDE" name="frameMenu"> which is fixed always (id and name)... could you access to it and go up? |
|
(0036012) elopio (reporter) 2011-04-19 02:34 |
@iperdomo, I didn't know about that function. I'll try it and see if it's possible with selenium to select the iframe that way. I need to access the iframe because with Selenium2 we have to select the frames before accessing the elements. So currently, I'm stepping through all the iframes in the page to see which one contains the frame I'm looking for, because I can only access them with the index and it changes. @dbaz, I can access those frames without issues. The problem is with the iframes. I first have to select the iframe and then the frame. Thanks for your answers. I will report back. |
|
(0036430) dmitry_mezentsev (developer) 2011-05-05 18:25 |
Does not fit RC7. |
|
(0051263) hgbot (developer) 2012-08-13 15:02 |
Repository: erp/devel/pi Changeset: d28bc1767d0a2e67b5092e681d13a2e9be70cca8 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Mon Aug 13 15:02:23 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/d28bc1767d0a2e67b5092e681d13a2e9be70cca8 [^] Fixed issue 16786: Added 'name' to the iframe containing OBClassicPopup --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/classic/ob-classic-compatibility.js --- |
|
(0051675) guilleaer (developer) 2012-08-30 12:35 |
verified in pi@1549d7119a63 |
|
(0053201) hgbot (developer) 2012-10-10 13:01 |
Repository: tools/automation/int Changeset: 1457b4ee1c00cdc881d6c49364e4478103f2f4a6 Author: Pablo Lujan <pablo.lujan <at> openbravo.com> Date: Mon Oct 08 19:05:28 2012 +0200 URL: http://code.openbravo.com/tools/automation/int/rev/1457b4ee1c00cdc881d6c49364e4478103f2f4a6 [^] Puts back the workaround for issue 16786 --- M src-test/com/openbravo/test/integration/erp/modules/client/application/gui/OBClassicPopUp.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-04-12 18:11 | elopio | New Issue | |
| 2011-04-12 18:11 | elopio | Assigned To | => alostale |
| 2011-04-12 18:11 | elopio | Modules | => Core |
| 2011-04-12 18:11 | elopio | Note Added: 0035869 | |
| 2011-04-13 08:58 | elopio | Note Added: 0035883 | |
| 2011-04-14 11:53 | alostale | Target Version | => 3.0RC7 |
| 2011-04-14 11:53 | alostale | Description Updated | View Revisions |
| 2011-04-14 11:53 | alostale | Status | new => scheduled |
| 2011-04-14 11:53 | alostale | Assigned To | alostale => dbaz |
| 2011-04-14 11:53 | alostale | fix_in_branch | => pi |
| 2011-04-15 09:35 | elopio | Note Added: 0035965 | |
| 2011-04-15 10:27 | iperdomo | Note Added: 0035967 | |
| 2011-04-15 13:29 | dbaz | Note Added: 0035979 | |
| 2011-04-19 02:34 | elopio | Note Added: 0036012 | |
| 2011-05-05 18:25 | dmitry_mezentsev | Note Added: 0036430 | |
| 2011-05-05 18:25 | dmitry_mezentsev | Target Version | 3.0RC7 => 3.0MP0 |
| 2011-05-05 18:25 | dmitry_mezentsev | fix_in_branch | pi => |
| 2011-05-17 09:15 | iperdomo | Priority | urgent => normal |
| 2011-05-23 16:41 | plujan | Target Version | 3.0MP0 => 3.0MP1 |
| 2011-06-22 19:57 | dmitry_mezentsev | Target Version | 3.0MP1 => 3.0MP2 |
| 2011-07-20 12:32 | dbaz | Target Version | 3.0MP2 => 3.0MP3 |
| 2011-08-31 13:51 | dbaz | Target Version | 3.0MP3 => |
| 2011-10-28 20:13 | iciordia | Tag Attached: OB3-Reviewed | |
| 2012-05-23 23:37 | shuehner | Issue Monitored: shuehner | |
| 2012-08-13 15:01 | dbaz | Closed by | => AugustoMauch |
| 2012-08-13 15:02 | hgbot | Checkin | |
| 2012-08-13 15:02 | hgbot | Note Added: 0051263 | |
| 2012-08-13 15:02 | hgbot | Status | scheduled => resolved |
| 2012-08-13 15:02 | hgbot | Resolution | open => fixed |
| 2012-08-13 15:02 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d28bc1767d0a2e67b5092e681d13a2e9be70cca8 [^] |
| 2012-08-30 12:35 | guilleaer | Closed by | AugustoMauch => guilleaer |
| 2012-08-30 12:35 | guilleaer | Note Added: 0051675 | |
| 2012-08-30 12:35 | guilleaer | Status | resolved => closed |
| 2012-08-30 12:35 | guilleaer | Fixed in Version | => 3.0MP15 |
| 2012-10-10 13:01 | hgbot | Checkin | |
| 2012-10-10 13:01 | hgbot | Note Added: 0053201 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |