Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0016684
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2011-04-07 12:462011-05-31 11:51
ReporterHexDumpView Statuspublic 
Assigned Tojpabloae 
PrioritynormalResolutionfixedFixed in Version3.0RC7
StatusclosedFix in branchpiFixed in SCM revisione2556cfac1b6
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0016684: Test for JAVA_HOME should be placed after root test is done in build.xml

Description<target name="init" depends="code.rev">
    <fail if="no.java.home" message="The environment variable JAVA_HOME is not $
    <fail if="root.user" message="Don't run ant tasks with the root user" />
</target>

This should be set as:

<target name="init" depends="code.rev">
    <fail if="root.user" message="Don't run ant tasks with the root user" />
    <fail if="no.java.home" message="The environment variable JAVA_HOME is not $
</target>

The problem here are environment vars. On ubuntu I had my java_home, etc... in /etc/environment. This seems not to be exported when going super user, so, I was getting an error saying that JAVA_HOME was not set, but it would have been much more better to flag that root account should not be used.

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0016685 closedjpabloae Test for JAVA_HOME should be placed after root test is done in build.xml 

-  Notes
(0035729)
hgbot (developer)
2011-04-07 12:56

Repository: erp/devel/pi
Changeset: e2556cfac1b64d6b0d2195932e815d817e498dab
Author: Juan Pablo Aroztegi <juanpablo.aroztegi <at> openbravo.com>
Date: Thu Apr 07 12:54:22 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e2556cfac1b64d6b0d2195932e815d817e498dab [^]

Fixes 16684: swap the order in the root.user and no.java.home checks.

Some Linux systems don't have JAVA_HOME set for the root user.
When a user runs ant commands in these cases they get an
error about the JAVA_HOME not being set, but the real cause
is that they're running the command as root. Hence the order
swapping.

---
M build.xml
---
(0035730)
jpabloae (reporter)
2011-04-07 12:57

Thank you HexDump for the bug report and the proposed solution. It makes sense.
(0037819)
gorka_gil (administrator)
2011-05-31 11:51

Verified.

- Issue History
Date Modified Username Field Change
2011-04-07 12:46 HexDump New Issue
2011-04-07 12:46 HexDump Assigned To => adrianromero
2011-04-07 12:46 HexDump Modules => Core
2011-04-07 12:48 iperdomo Assigned To adrianromero => iperdomo
2011-04-07 12:48 iperdomo Category 08. Project and service management => A. Platform
2011-04-07 12:49 iperdomo Status new => scheduled
2011-04-07 12:49 iperdomo fix_in_branch => pi
2011-04-07 12:51 iperdomo Assigned To iperdomo => jpabloae
2011-04-07 12:56 hgbot Checkin
2011-04-07 12:56 hgbot Note Added: 0035729
2011-04-07 12:56 hgbot Status scheduled => resolved
2011-04-07 12:56 hgbot Resolution open => fixed
2011-04-07 12:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e2556cfac1b64d6b0d2195932e815d817e498dab [^]
2011-04-07 12:57 jpabloae Note Added: 0035730
2011-05-31 11:51 gorka_gil Note Added: 0037819
2011-05-31 11:51 gorka_gil Status resolved => closed
2011-05-31 11:51 gorka_gil Fixed in Version => 3.0RC7


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker