Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0016621 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] I. Performance | minor | always | 2011-04-03 13:31 | 2013-01-09 18:04 | |||
Reporter | eintelau | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | low | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | pi | Fixed in SCM revision | 480d39749726 | |||
Projection | none | ETA | none | Target Version | 3.0RC7 | |||
OS | Any | Database | PostgreSQL | Java version | ||||
OS Version | Database version | 9 | Ant version | |||||
Product Version | pi | SCM revision | ||||||
Review Assigned To | ||||||||
Web browser | ||||||||
Modules | User Interface Selector | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0016621: Selector item does an unnecessary count operation on server | |||||||
Description | When the queries are done to populate a selector, the server is required to carry out a count query in addition to the results query. This count query appears to be unnecessary & can significantly slow down the speed of the call when dealing with large or complex datasets. | |||||||
Steps To Reproduce | (while debugging/monitoring database queries) 1) Open New Sales Order 2) Create a line 3) Click the product combo dropdown 4) Note: that the server does a count query, then a select query but only returns the first 75 results. | |||||||
Proposed Solution | Change the selector logic to prevent a count operation occurring on the server. | |||||||
Tags | No tags attached. | |||||||
Attached Files | 16621.patch [^] (1,104 bytes) 2011-04-03 13:33 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||||||||||||||||
|
Notes | |
(0036629) hgbot (developer) 2011-05-10 14:37 |
Repository: erp/devel/pi Changeset: 480d397497261c4ccb7e96fd513e8b6ae5b22b29 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue May 10 14:36:37 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/480d397497261c4ccb7e96fd513e8b6ae5b22b29 [^] Fixes issue 16621 Selector item does an unnecessary count operation on server --- M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js --- |
(0036873) hudsonbot (developer) 2011-05-12 13:31 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^] Maturity status: Test |
(0037030) shuehner (administrator) 2011-05-16 16:17 |
Tested on pi/pgsql (rev:e991f418d077). Now count is prevent for the normal datasource used for selectors so selector grid shows same behavior as normal grid. For numRecords < fetchPageSize scrollbar is more or less exact. And for bigger numRecords scrollbar extends itself when new data for new page is requested from server. |
(0055376) hgbot (developer) 2013-01-08 13:42 |
Repository: erp/devel/pi Changeset: a6b006e76cb2901e593570592a2a2d78953bbbf8 Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Tue Jan 08 18:09:57 2013 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/a6b006e76cb2901e593570592a2a2d78953bbbf8 [^] Fixes Issue 22684 : Only 76 values shown in Custom Query Selector picklist Modified Custom Query Selector to count the total number of rows. This is not needed in normal selectors because total rows is calculated irrespective of start row and end row. Also restored the changeset of issue 16621. --- M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js --- |
(0055397) hudsonbot (developer) 2013-01-09 05:41 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/195064f93651 [^] Maturity status: Test |
(0055412) hgbot (developer) 2013-01-09 10:28 |
Repository: erp/devel/pi Changeset: bedb82b9459e1fd7bd1a96303bffc9958752c06b Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Wed Jan 09 14:56:52 2013 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/bedb82b9459e1fd7bd1a96303bffc9958752c06b [^] Related to issue 22684 : Backout changeset 96927b00ddcc Backout changeset because it breaks another issue 16621. --- M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js --- |
(0055436) hudsonbot (developer) 2013-01-09 18:04 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/314b62ac40f7 [^] Maturity status: Test |
Issue History | |||
Date Modified | Username | Field | Change |
2011-04-03 13:31 | eintelau | New Issue | |
2011-04-03 13:31 | eintelau | Assigned To | => dbaz |
2011-04-03 13:31 | eintelau | Modules | => User Interface Selector |
2011-04-03 13:33 | eintelau | File Added: 16621.patch | |
2011-04-04 10:56 | dbaz | Assigned To | dbaz => mtaal |
2011-04-05 14:07 | shuehner | Category | B. User interface => I. Performance |
2011-04-05 17:19 | shuehner | Relationship added | related to 0016611 |
2011-04-11 10:23 | alostale | Target Version | => 3.0RC7 |
2011-04-11 10:23 | alostale | Status | new => scheduled |
2011-04-11 10:23 | alostale | Assigned To | mtaal => iperdomo |
2011-04-11 10:23 | alostale | fix_in_branch | => pi |
2011-04-26 12:55 | gorkaion | Relationship added | related to 0016622 |
2011-05-06 19:38 | dmitry_mezentsev | Assigned To | iperdomo => alostale |
2011-05-09 13:31 | alostale | Assigned To | alostale => mtaal |
2011-05-10 14:37 | hgbot | Checkin | |
2011-05-10 14:37 | hgbot | Note Added: 0036629 | |
2011-05-10 14:37 | hgbot | Status | scheduled => resolved |
2011-05-10 14:37 | hgbot | Resolution | open => fixed |
2011-05-10 14:37 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/480d397497261c4ccb7e96fd513e8b6ae5b22b29 [^] |
2011-05-12 13:31 | hudsonbot | Checkin | |
2011-05-12 13:31 | hudsonbot | Note Added: 0036873 | |
2011-05-16 16:17 | shuehner | Note Added: 0037030 | |
2011-05-16 16:17 | shuehner | Status | resolved => closed |
2011-06-17 13:13 | gorkaion | Relationship added | related to 0016373 |
2013-01-08 13:42 | hgbot | Checkin | |
2013-01-08 13:42 | hgbot | Note Added: 0055376 | |
2013-01-09 05:41 | hudsonbot | Checkin | |
2013-01-09 05:41 | hudsonbot | Note Added: 0055397 | |
2013-01-09 10:28 | hgbot | Checkin | |
2013-01-09 10:28 | hgbot | Note Added: 0055412 | |
2013-01-09 18:04 | hudsonbot | Checkin | |
2013-01-09 18:04 | hudsonbot | Note Added: 0055436 |
Copyright © 2000 - 2009 MantisBT Group |